From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailgw02.mediatek.com ([210.61.82.184]:57915 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726595AbeLSEDq (ORCPT ); Tue, 18 Dec 2018 23:03:46 -0500 Message-ID: <1545192203.4134.11.camel@mtkswgap22> Subject: Re: [PATCH v5] cdc-acm: fix abnormal DATA RX issue for Mediatek Preloader. From: Macpaul Lin To: Lars Melin CC: Oliver Neukum , Andrey Arapov , Johan Hovold , "Greg Kroah-Hartman" , Mediatek WSD Upstream , , Date: Wed, 19 Dec 2018 12:03:23 +0800 In-Reply-To: <3465233a-1afd-8112-ebd6-78cceb426c9d@gmail.com> References: <1544671676-23912-1-git-send-email-macpaul.lin@mediatek.com> <1545134386-5528-1-git-send-email-macpaul.lin@mediatek.com> <20181218123840.GP20658@localhost> <1545140229.18594.3.camel@suse.com> <1545143195.10193.6.camel@mtkswgap22> <1545146389.10193.12.camel@mtkswgap22> <5b0e5bf4-0411-0c58-ccae-fe66c937a36b@gmail.com> <1545155303.16619.11.camel@mtkswgap22> <1545186137.1821.5.camel@mtkswgap22> <1545189395.3262.2.camel@mtkswgap22> <3465233a-1afd-8112-ebd6-78cceb426c9d@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org List-ID: On Wed, 2018-12-19 at 10:31 +0700, Lars Melin wrote: > On 12/19/2018 10:16, Macpaul Lin wrote: > > Hi Macpaul, > your verbose usb listing show me that Mediatek has made two different > 0e8d:003 devices, see my verbose lsusb listing below. > (Notice also the reverse order for cmd and data interfaces in it > compared to yours). > USB id's are intended to identify a device and its needs so there should > never be more than one unique device per id. > > > Fairphone FP-1, MT6227 (no CDC union !!!) > Hi Lars, Ha ha ha, it is a little bit embarrassing. What I've used to capture verbose log is MT6765 platform. Then I've checked Fairphone FP-1, which is MT6589 a pretty old platform. The BROM (boot ROM) has been maintained by other teams and will vary by different SoC project in Mediatek. I'm not sure why they changed the descriptors. For the consistency of BROM's behavior, I'll update a new patch keeps PID:0003 remain untouched. I'll trying to report it to BROM team and see if they have any action on this issue. Regards, Macpaul Lin From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v5] cdc-acm: fix abnormal DATA RX issue for Mediatek Preloader. From: macpaul.lin@mediatek.com Message-Id: <1545192203.4134.11.camel@mtkswgap22> Date: Wed, 19 Dec 2018 12:03:23 +0800 To: Lars Melin Cc: Oliver Neukum , Andrey Arapov , Johan Hovold , Greg Kroah-Hartman , Mediatek WSD Upstream , linux-usb@vger.kernel.org, stable@vger.kernel.org List-ID: T24gV2VkLCAyMDE4LTEyLTE5IGF0IDEwOjMxICswNzAwLCBMYXJzIE1lbGluIHdyb3RlOgo+IE9u IDEyLzE5LzIwMTggMTA6MTYsIE1hY3BhdWwgTGluIHdyb3RlOiAKPiAKPiBIaSBNYWNwYXVsLAo+ IHlvdXIgdmVyYm9zZSB1c2IgbGlzdGluZyBzaG93IG1lIHRoYXQgTWVkaWF0ZWsgaGFzIG1hZGUg dHdvIGRpZmZlcmVudCAKPiAwZThkOjAwMyBkZXZpY2VzLCBzZWUgbXkgdmVyYm9zZSBsc3VzYiBs aXN0aW5nIGJlbG93Lgo+IChOb3RpY2UgYWxzbyB0aGUgcmV2ZXJzZSBvcmRlciBmb3IgY21kIGFu ZCBkYXRhIGludGVyZmFjZXMgaW4gaXQgCj4gY29tcGFyZWQgdG8geW91cnMpLgo+IFVTQiBpZCdz IGFyZSBpbnRlbmRlZCB0byBpZGVudGlmeSBhIGRldmljZSBhbmQgaXRzIG5lZWRzIHNvIHRoZXJl IHNob3VsZAo+IG5ldmVyIGJlIG1vcmUgdGhhbiBvbmUgdW5pcXVlIGRldmljZSBwZXIgaWQuCj4g Cj4gCj4gRmFpcnBob25lIEZQLTEsIE1UNjIyNyAgKG5vIENEQyB1bmlvbiAhISEpCj4gCkhpIExh cnMsCgpIYSBoYSBoYSwgaXQgaXMgYSBsaXR0bGUgYml0IGVtYmFycmFzc2luZy4KV2hhdCBJJ3Zl IHVzZWQgdG8gY2FwdHVyZSB2ZXJib3NlIGxvZyBpcyBNVDY3NjUgcGxhdGZvcm0uClRoZW4gSSd2 ZSBjaGVja2VkIEZhaXJwaG9uZSBGUC0xLCB3aGljaCBpcyBNVDY1ODkgYSBwcmV0dHkgb2xkIHBs YXRmb3JtLgpUaGUgQlJPTSAoYm9vdCBST00pIGhhcyBiZWVuIG1haW50YWluZWQgYnkgb3RoZXIg dGVhbXMgYW5kIHdpbGwgdmFyeSBieQpkaWZmZXJlbnQgU29DIHByb2plY3QgaW4gTWVkaWF0ZWsu IEknbSBub3Qgc3VyZSB3aHkgdGhleSBjaGFuZ2VkIHRoZQpkZXNjcmlwdG9ycy4KCkZvciB0aGUg Y29uc2lzdGVuY3kgb2YgQlJPTSdzIGJlaGF2aW9yLCBJJ2xsIHVwZGF0ZSBhIG5ldyBwYXRjaCBr ZWVwcwpQSUQ6MDAwMyByZW1haW4gdW50b3VjaGVkLiBJJ2xsIHRyeWluZyB0byByZXBvcnQgaXQg dG8gQlJPTSB0ZWFtIGFuZCBzZWUKaWYgdGhleSBoYXZlIGFueSBhY3Rpb24gb24gdGhpcyBpc3N1 ZS4KClJlZ2FyZHMsCk1hY3BhdWwgTGluCg==