From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:51400 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727801AbeLSI4e (ORCPT ); Wed, 19 Dec 2018 03:56:34 -0500 Message-ID: <1545209782.31763.2.camel@suse.com> Subject: Re: [PATCH v5] cdc-acm: fix abnormal DATA RX issue for Mediatek Preloader. From: Oliver Neukum To: Macpaul Lin , Lars Melin Cc: Andrey Arapov , Johan Hovold , Greg Kroah-Hartman , Mediatek WSD Upstream , linux-usb@vger.kernel.org, stable@vger.kernel.org Date: Wed, 19 Dec 2018 09:56:22 +0100 In-Reply-To: <1545192203.4134.11.camel@mtkswgap22> References: <1544671676-23912-1-git-send-email-macpaul.lin@mediatek.com> <1545134386-5528-1-git-send-email-macpaul.lin@mediatek.com> <20181218123840.GP20658@localhost> <1545140229.18594.3.camel@suse.com> <1545143195.10193.6.camel@mtkswgap22> <1545146389.10193.12.camel@mtkswgap22> <5b0e5bf4-0411-0c58-ccae-fe66c937a36b@gmail.com> <1545155303.16619.11.camel@mtkswgap22> <1545186137.1821.5.camel@mtkswgap22> <1545189395.3262.2.camel@mtkswgap22> <3465233a-1afd-8112-ebd6-78cceb426c9d@gmail.com> <1545192203.4134.11.camel@mtkswgap22> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: On Mi, 2018-12-19 at 12:03 +0800, Macpaul Lin wrote: > On Wed, 2018-12-19 at 10:31 +0700, Lars Melin wrote: > > On 12/19/2018 10:16, Macpaul Lin wrote: > > > > Hi Macpaul, > > your verbose usb listing show me that Mediatek has made two different > > 0e8d:003 devices, see my verbose lsusb listing below. > > (Notice also the reverse order for cmd and data interfaces in it > > compared to yours). > > USB id's are intended to identify a device and its needs so there should > > never be more than one unique device per id. > > > > > > Fairphone FP-1, MT6227 (no CDC union !!!) > > > > Hi Lars, > > Ha ha ha, it is a little bit embarrassing. > What I've used to capture verbose log is MT6765 platform. > Then I've checked Fairphone FP-1, which is MT6589 a pretty old platform. > The BROM (boot ROM) has been maintained by other teams and will vary by > different SoC project in Mediatek. I'm not sure why they changed the > descriptors. > > For the consistency of BROM's behavior, I'll update a new patch keeps > PID:0003 remain untouched. I'll trying to report it to BROM team and see > if they have any action on this issue. Thank you all for taking care of these important issues. Please submit that new patch. Regards Oliver From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v5] cdc-acm: fix abnormal DATA RX issue for Mediatek Preloader. From: Oliver Neukum Message-Id: <1545209782.31763.2.camel@suse.com> Date: Wed, 19 Dec 2018 09:56:22 +0100 To: Macpaul Lin , Lars Melin Cc: Andrey Arapov , Johan Hovold , Greg Kroah-Hartman , Mediatek WSD Upstream , linux-usb@vger.kernel.org, stable@vger.kernel.org List-ID: T24gTWksIDIwMTgtMTItMTkgYXQgMTI6MDMgKzA4MDAsIE1hY3BhdWwgTGluIHdyb3RlOgo+IE9u IFdlZCwgMjAxOC0xMi0xOSBhdCAxMDozMSArMDcwMCwgTGFycyBNZWxpbiB3cm90ZToKPiA+IE9u IDEyLzE5LzIwMTggMTA6MTYsIE1hY3BhdWwgTGluIHdyb3RlOiAKPiA+IAo+ID4gSGkgTWFjcGF1 bCwKPiA+IHlvdXIgdmVyYm9zZSB1c2IgbGlzdGluZyBzaG93IG1lIHRoYXQgTWVkaWF0ZWsgaGFz IG1hZGUgdHdvIGRpZmZlcmVudCAKPiA+IDBlOGQ6MDAzIGRldmljZXMsIHNlZSBteSB2ZXJib3Nl IGxzdXNiIGxpc3RpbmcgYmVsb3cuCj4gPiAoTm90aWNlIGFsc28gdGhlIHJldmVyc2Ugb3JkZXIg Zm9yIGNtZCBhbmQgZGF0YSBpbnRlcmZhY2VzIGluIGl0IAo+ID4gY29tcGFyZWQgdG8geW91cnMp Lgo+ID4gVVNCIGlkJ3MgYXJlIGludGVuZGVkIHRvIGlkZW50aWZ5IGEgZGV2aWNlIGFuZCBpdHMg bmVlZHMgc28gdGhlcmUgc2hvdWxkCj4gPiBuZXZlciBiZSBtb3JlIHRoYW4gb25lIHVuaXF1ZSBk ZXZpY2UgcGVyIGlkLgo+ID4gCj4gPiAKPiA+IEZhaXJwaG9uZSBGUC0xLCBNVDYyMjcgIChubyBD REMgdW5pb24gISEhKQo+ID4gCj4gCj4gSGkgTGFycywKPiAKPiBIYSBoYSBoYSwgaXQgaXMgYSBs aXR0bGUgYml0IGVtYmFycmFzc2luZy4KPiBXaGF0IEkndmUgdXNlZCB0byBjYXB0dXJlIHZlcmJv c2UgbG9nIGlzIE1UNjc2NSBwbGF0Zm9ybS4KPiBUaGVuIEkndmUgY2hlY2tlZCBGYWlycGhvbmUg RlAtMSwgd2hpY2ggaXMgTVQ2NTg5IGEgcHJldHR5IG9sZCBwbGF0Zm9ybS4KPiBUaGUgQlJPTSAo Ym9vdCBST00pIGhhcyBiZWVuIG1haW50YWluZWQgYnkgb3RoZXIgdGVhbXMgYW5kIHdpbGwgdmFy eSBieQo+IGRpZmZlcmVudCBTb0MgcHJvamVjdCBpbiBNZWRpYXRlay4gSSdtIG5vdCBzdXJlIHdo eSB0aGV5IGNoYW5nZWQgdGhlCj4gZGVzY3JpcHRvcnMuCj4gCj4gRm9yIHRoZSBjb25zaXN0ZW5j eSBvZiBCUk9NJ3MgYmVoYXZpb3IsIEknbGwgdXBkYXRlIGEgbmV3IHBhdGNoIGtlZXBzCj4gUElE OjAwMDMgcmVtYWluIHVudG91Y2hlZC4gSSdsbCB0cnlpbmcgdG8gcmVwb3J0IGl0IHRvIEJST00g dGVhbSBhbmQgc2VlCj4gaWYgdGhleSBoYXZlIGFueSBhY3Rpb24gb24gdGhpcyBpc3N1ZS4KClRo YW5rIHlvdSBhbGwgZm9yIHRha2luZyBjYXJlIG9mIHRoZXNlIGltcG9ydGFudCBpc3N1ZXMuClBs ZWFzZSBzdWJtaXQgdGhhdCBuZXcgcGF0Y2guCgoJUmVnYXJkcwoJCU9saXZlcgo=