All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Zhenyu Wang <zhenyuw@linux.intel.com>, intel-gfx@lists.freedesktop.org
Cc: intel-gvt-dev@lists.freedesktop.org, "Yuan, Hang" <hang.yuan@intel.com>
Subject: Re: [PATCH v6 3/3] drm/i915/gvt: Change KVMGT as self load module
Date: Thu, 20 Dec 2018 12:05:56 +0200	[thread overview]
Message-ID: <154530035637.6138.2841971380144117527@jlahtine-desk.ger.corp.intel.com> (raw)
In-Reply-To: <20181207081653.1216-4-zhenyuw@linux.intel.com>

Quoting Zhenyu Wang (2018-12-07 10:16:53)
> This trys to make 'kvmgt' module as self loadable instead of loading
> by i915/gvt device model. So hypervisor specific module could be
> stand-alone, e.g only after loading hypervisor specific module, GVT
> feature could be enabled via specific hypervisor interface, e.g VFIO/mdev.
> 
> So this trys to use hypervisor module register/unregister interface
> for that. Hypervisor module needs to take care of module reference
> itself when working for hypervisor interface, e.g for VFIO/mdev,
> hypervisor module would reference counting mdev when open and release.
> 
> This makes 'kvmgt' module really split from GVT device model. User
> needs to load 'kvmgt' to enable VFIO/mdev interface.
> 
> v6:
> - remove unused variable
> 
> v5:
> - put module reference in register error path
> 
> v4:
> - fix checkpatch warning
> 
> v3:
> - Fix module reference handling for device open and release. Unused
>   mdev devices would be cleaned up in device unregister when module unload.
> 
> v2:
> - Fix kvmgt order after i915 for built-in case
> 
> Cc: "Yuan, Hang" <hang.yuan@intel.com>
> Cc: Alex Williamson <alex.williamson@redhat.com>
> Cc: "He, Min" <min.he@intel.com>
> Reviewed-by: Yuan, Hang <hang.yuan@intel.com>
> Signed-off-by: Zhenyu Wang <zhenyuw@linux.intel.com>

For what i915 is concerned, this is the desireable direction. When
combined with the other series about making GVT build independantly,
and golden MMIO state (instead of capturing at boot).

With those This should both expedite the i915 driver loading on DOM0,
when GVT can be loaded as secondary module. And the golden MMIO state
instead of capturing from host would avoid leaking any changes in host
configuration (say, due to BIOS update) to the guests.

So as an intermediary step to that direction, for i915 portion (not that
much in this case) this is:

Acked-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

I'm expecting somebody with more inisght to review the code under
gvt/.

Regards, Joonas
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2018-12-20 10:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-07  8:16 [PATCH v6 0/3] Change KVMGT into self loadable module Zhenyu Wang
2018-12-07  8:16 ` [PATCH v6 1/3] drm/i915/gvt: mandatory require hypervisor's host_init Zhenyu Wang
2018-12-07  8:16 ` [PATCH v6 2/3] drm/i915/gvt: remove unused parameter for hypervisor's host_exit call Zhenyu Wang
2018-12-07  8:16 ` [PATCH v6 3/3] drm/i915/gvt: Change KVMGT as self load module Zhenyu Wang
2018-12-20 10:05   ` Joonas Lahtinen [this message]
2018-12-07  9:19 ` ✓ Fi.CI.BAT: success for Change KVMGT into self loadable module (rev4) Patchwork
2018-12-07 15:07 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=154530035637.6138.2841971380144117527@jlahtine-desk.ger.corp.intel.com \
    --to=joonas.lahtinen@linux.intel.com \
    --cc=hang.yuan@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-gvt-dev@lists.freedesktop.org \
    --cc=zhenyuw@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.