From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chee, Tien Fong <tien.fong.chee@intel.com>
Date: Fri, 21 Dec 2018 17:50:51 +0000
Subject: [U-Boot] [PATCH] Add support for initializing MMC
In-Reply-To: <CAPnjgZ0jj8BRWva8dm5aRAv=G1qc1yk-Mm6xn1GbtxPmarD+bg@mail.gmail.com>
References: <1544770433-7916-1-git-send-email-tien.fong.chee@intel.com>
 <1545380723.21117.0.camel@intel.com>
 <CAPnjgZ0jj8BRWva8dm5aRAv=G1qc1yk-Mm6xn1GbtxPmarD+bg@mail.gmail.com>
Message-ID: <1545414646.9789.4.camel@intel.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
To: u-boot@lists.denx.de

On Fri, 2018-12-21 at 10:16 -0700, Simon Glass wrote:
> Hi,
> 
> On Fri, 21 Dec 2018 at 01:25, Chee, Tien Fong <tien.fong.chee@intel.c
> om> wrote:
> > 
> > 
> > On Fri, 2018-12-14 at 14:53 +0800, tien.fong.chee at intel.com wrote:
> > > 
> > > From: Tien Fong Chee <tien.fong.chee@intel.com>
> > > 
> > > Firmware loader would encounter problem if the MMC is accessed
> > > before
> > > initializing it. This patch would adding the support of
> > > initializing
> > > MMC before the MMC is accessed by firmware loader.
> > > 
> > > Signed-off-by: Tien Fong Chee <tien.fong.chee@intel.com>
> > > ---
> > >  drivers/misc/fs_loader.c |   31 +++++++++++++++++++++++++++++++
> > >  1 files changed, 31 insertions(+), 0 deletions(-)
> > > 
> > Any comment for this patch?
> This should not be needed with CONFIG_DM_MMC enabled as it should be
> enough to probe the mmc device. Is that right?
No, CONFIG_DM_MMC is required, otherwise compiler would tell you error.
This whole mechanism is always developed in DM context.
What's your concern? You want me to add CONFIG_DM_MMC or replace with
CONFIG_MMC? or You want to improve the document?
> 
> Regards,
> Simon
> 
> > 
> > 
> > > 
> > > diff --git a/drivers/misc/fs_loader.c b/drivers/misc/fs_loader.c
> > > index 57a14a3..744fa46 100644
> > > --- a/drivers/misc/fs_loader.c
> > > +++ b/drivers/misc/fs_loader.c
> > > @@ -12,6 +12,7 @@
> > >  #include <linux/string.h>
> > >  #include <mapmem.h>
> > >  #include <malloc.h>
> > > +#include <mmc.h>
> > >  #include <spl.h>
> > > 
> > >  DECLARE_GLOBAL_DATA_PTR;
> > > @@ -252,6 +253,36 @@ static int
> > > fs_loader_ofdata_to_platdata(struct
> > > udevice *dev)
> > > 
> > >  static int fs_loader_probe(struct udevice *dev)
> > >  {
> > > +#ifdef CONFIG_MMC
> > > +     int ret;
> > > +     struct device_platdata *plat = dev->platdata;
> > > +
> > > +     ret = mmc_initialize(NULL);
> > > +     if (ret) {
> > > +             debug("MMC: could not initialize mmc. error: %d\n",
> > > ret);
> > > +
> > > +             return ret;
> > > +     }
> > > +
> > > +     if (plat->phandlepart.phandle) {
> > > +             ofnode node = ofnode_get_by_phandle(plat-
> > > > 
> > > > phandlepart.phandle);
> > > +
> > > +             struct udevice *mmc_dev = NULL;
> > > +
> > > +             ret = device_get_global_by_ofnode(node, &mmc_dev);
> > > +             if (!ret) {
> > > +                     struct mmc *mmc = mmc_get_mmc_dev(mmc_dev);
> > > +
> > > +                     ret = mmc_init(mmc);
> > > +                     if (ret) {
> > > +                             debug("MMC: mmc init failed with
> > > error: %d\n",
> > > +                                     ret);
> > > +
> > > +                             return ret;
> > > +                     }
> > > +             }
> > > +     }
> > > +#endif
> > >       return 0;
> > >  };
> > >