Re: [Qemu-devel] [PULL v3 00/44] pci, pc, virtio: fixes, features

[no-reply@patchew.org]

Patchew URL: https://patchew.org/QEMU/20181220183059.20726-1-mst@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20181220183059.20726-1-mst@redhat.com
Type: series
Subject: [Qemu-devel] [PULL v3 00/44] pci, pc, virtio: fixes, features

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
00bb933 x86-iommu: turn on IR by default if proper
84205d7 x86-iommu: switch intr_supported to OnOffAuto type
e90352f q35: set split kernel irqchip as default
5b42631 pci: Adjust PCI config limit based on bus topology
10af565 spapr_pci: perform unplug via the hotplug handler
19d636e pci/shpc: perform unplug via the hotplug handler
547f401 pci: Reuse pci-bridge hotplug handler handlers for pcie-pci-bridge
54491be pci/pcie: perform unplug via the hotplug handler
d48a499 pci/pcihp: perform unplug via the hotplug handler
69293f5 pci/pcihp: overwrite hotplug handler recursively from the start
cb4db34 pci/pcihp: perform check for bus capability in pre_plug handler
1966b59 s390x/pci: rename hotplug handler callbacks
c9b84c2 pci/shpc: rename hotplug handler callbacks
7d3cc09 pci/pcie: rename hotplug handler callbacks
14b804a hw/i386: Remove deprecated machines pc-0.10 and pc-0.11
2ecba91 hw: acpi: Remove AcpiRsdpDescriptor and fix tests
6eec914 hw: acpi: Export and share the ARM RSDP build
6ce7573 hw: arm: Support both legacy and current RSDP build
05e6bb6 hw: arm: Convert the RSDP build to the buid_append_foo() API
1e3f0b8 hw: arm: Carry RSDP specific data through AcpiRsdpData
1149d53 hw: i386: Use correct RSDT length for checksum
08f1f3d hw: arm: acpi: Fix incorrect checksums in RSDP
833c5a9 hw: acpi: The RSDP build API can return void
6764083 intel_iommu: remove "x-" prefix for "aw-bits"
073d52a intel_iommu: dma read/write draining support
f3f77a5 intel_iommu: convert invalid traces into error reports
3d38fe7 intel_iommu: dump correct iova when failed
bf967a3 pcie: Fast PCIe root ports for new machines
c116234 vfio/pci: Remove PCIe Link Status emulation
b2b0199 pcie: Allow generic PCIe root port to specify link speed and width
de6a18a pcie: Fill PCIESlot link fields to support higher speeds and widths
b19b53a pcie: Add link speed and width fields to PCIESlot
e909a5f qapi: Define PCIe link speed and width properties
2b940de pci: Sync PCIe downstream port LNKSTA on read
e9a0604 pcie: Create enums for link speed and width
d1ef1d5 hw/pci-bridge: Fix invalid free()
3f5466b hw/smbios: Move to the hw/firmware/ subdirectory
22e0d61 hw/smbios: Remove "smbios_ipmi.h"
8f50a34 hw/smbios: Restrict access to "hw/smbios/ipmi.h"
6075c5e tests: Remove unused include
b4cf945 virtio: Provide version-specific variants of virtio PCI devices
4dff116 virtio: Helper for registering virtio device types
be858a5 pc:piix4: Update smbus I/O space after a migration
9a3c2f2 pcie: set link state inactive/active after hot unplug/plug

=== OUTPUT BEGIN ===
Checking PATCH 1/44: pcie: set link state inactive/active after hot unplug/plug...
Checking PATCH 2/44: pc:piix4: Update smbus I/O space after a migration...
Checking PATCH 3/44: virtio: Helper for registering virtio device types...
WARNING: line over 80 characters
#498: FILE: hw/virtio/virtio-pci.h:443:
+     * Implements both INTERFACE_PCIE_DEVICE and INTERFACE_CONVENTIONAL_PCI_DEVICE,

WARNING: line over 80 characters
#507: FILE: hw/virtio/virtio-pci.h:452:
+     * Implements both INTERFACE_PCIE_DEVICE and INTERFACE_CONVENTIONAL_PCI_DEVICE.

total: 0 errors, 2 warnings, 469 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 4/44: virtio: Provide version-specific variants of virtio PCI devices...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#318: 
new file mode 100644

ERROR: line over 90 characters
#374: FILE: tests/acceptance/virtio_version.py:52:
+    return devtype in [d['name'] for d in vm.command('qom-list-types', implements=implements)]

WARNING: line over 80 characters
#429: FILE: tests/acceptance/virtio_version.py:107:
+        dev_1_0, nt_ifaces = self.run_device('%s-non-transitional' % (qemu_devtype))

WARNING: line over 80 characters
#453: FILE: tests/acceptance/virtio_version.py:131:
+        dev_trans, trans_ifaces = self.run_device('%s-transitional' % (qemu_devtype))

total: 1 errors, 3 warnings, 404 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 5/44: tests: Remove unused include...
Checking PATCH 6/44: hw/smbios: Restrict access to "hw/smbios/ipmi.h"...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#34: 
rename from include/hw/smbios/ipmi.h

total: 0 errors, 1 warnings, 27 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 7/44: hw/smbios: Remove "smbios_ipmi.h"...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#53: 
deleted file mode 100644

total: 0 errors, 1 warnings, 36 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 8/44: hw/smbios: Move to the hw/firmware/ subdirectory...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#124: 
rename from include/hw/smbios/smbios.h

total: 0 errors, 1 warnings, 80 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 9/44: hw/pci-bridge: Fix invalid free()...
Checking PATCH 10/44: pcie: Create enums for link speed and width...
Checking PATCH 11/44: pci: Sync PCIe downstream port LNKSTA on read...
Checking PATCH 12/44: qapi: Define PCIe link speed and width properties...
Checking PATCH 13/44: pcie: Add link speed and width fields to PCIESlot...
Checking PATCH 14/44: pcie: Fill PCIESlot link fields to support higher speeds and widths...
Checking PATCH 15/44: pcie: Allow generic PCIe root port to specify link speed and width...
Checking PATCH 16/44: vfio/pci: Remove PCIe Link Status emulation...
Checking PATCH 17/44: pcie: Fast PCIe root ports for new machines...
Checking PATCH 18/44: intel_iommu: dump correct iova when failed...
Checking PATCH 19/44: intel_iommu: convert invalid traces into error reports...
Checking PATCH 20/44: intel_iommu: dma read/write draining support...
Checking PATCH 21/44: intel_iommu: remove "x-" prefix for "aw-bits"...
Checking PATCH 22/44: hw: acpi: The RSDP build API can return void...
Checking PATCH 23/44: hw: arm: acpi: Fix incorrect checksums in RSDP...
WARNING: Block comments use a leading /* on a separate line
#42: FILE: hw/arm/virt-acpi-build.c:393:
+        (char *)rsdp - rsdp_table->data, 20 /* ACPI rev 1.0 RSDP size */,

WARNING: Block comments use a leading /* on a separate line
#47: FILE: hw/arm/virt-acpi-build.c:398:
+        (char *)rsdp - rsdp_table->data, 36 /* ACPI rev 2.0 RSDP size */,

total: 0 errors, 2 warnings, 14 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 24/44: hw: i386: Use correct RSDT length for checksum...
WARNING: Block comments use a leading /* on a separate line
#36: FILE: hw/i386/acpi-build.c:2553:
+    /* AcpiRsdpDescriptor describes revision 2 RSDP table and as result we

WARNING: Block comments use a leading /* on a separate line
#49: FILE: hw/i386/acpi-build.c:2575:
+        (char *)rsdp - rsdp_table->data, 20 /* ACPI rev 1.0 RSDP size */,

total: 0 errors, 2 warnings, 19 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 25/44: hw: arm: Carry RSDP specific data through AcpiRsdpData...
Checking PATCH 26/44: hw: arm: Convert the RSDP build to the buid_append_foo() API...
Checking PATCH 27/44: hw: arm: Support both legacy and current RSDP build...
Checking PATCH 28/44: hw: acpi: Export and share the ARM RSDP build...
WARNING: Block comments use a leading /* on a separate line
#49: FILE: hw/acpi/aml-build.c:1616:
+                             true /* fseg memory */);

WARNING: Block comments use a leading /* on a separate line
#226: FILE: hw/i386/acpi-build.c:2715:
+            /* We used to allocate some extra space for RSDP revision 2 but

total: 0 errors, 2 warnings, 214 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 29/44: hw: acpi: Remove AcpiRsdpDescriptor and fix tests...
WARNING: Block comments use a leading /* on a separate line
#63: FILE: tests/acpi-utils.c:58:
+    memcpy(&rsdt_physical_address, &rsdp_table[16 /* RsdtAddress offset */], 4);

WARNING: Block comments use a leading /* on a separate line
#70: FILE: tests/acpi-utils.c:65:
+    uint8_t revision = rsdp_table[15 /* Revision offset */];

WARNING: Block comments use a leading /* on a separate line
#75: FILE: tests/acpi-utils.c:70:
+    memcpy(&xsdt_physical_address, &rsdp_table[24 /* XsdtAddress offset */], 8);

WARNING: Block comments use a leading /* on a separate line
#85: FILE: tests/acpi-utils.c:80:
+    revision = rsdp_table[15 /* Revision offset */];

WARNING: Block comments use a leading /* on a separate line
#124: FILE: tests/bios-tables-test.c:30:
+    uint8_t rsdp_table[36 /* ACPI 2.0+ RSDP size */];

WARNING: Block comments use a leading /* on a separate line
#137: FILE: tests/bios-tables-test.c:93:
+    revision = rsdp_table[15 /* Revision offset */];

WARNING: Block comments use a leading /* on a separate line
#173: FILE: tests/vmgenid-test.c:38:
+    uint8_t rsdp_table[36 /* ACPI 2.0+ RSDP size */];

total: 0 errors, 7 warnings, 146 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 30/44: hw/i386: Remove deprecated machines pc-0.10 and pc-0.11...
Checking PATCH 31/44: pci/pcie: rename hotplug handler callbacks...
Checking PATCH 32/44: pci/shpc: rename hotplug handler callbacks...
Checking PATCH 33/44: s390x/pci: rename hotplug handler callbacks...
Checking PATCH 34/44: pci/pcihp: perform check for bus capability in pre_plug handler...
Checking PATCH 35/44: pci/pcihp: overwrite hotplug handler recursively from the start...
Checking PATCH 36/44: pci/pcihp: perform unplug via the hotplug handler...
Checking PATCH 37/44: pci/pcie: perform unplug via the hotplug handler...
Checking PATCH 38/44: pci: Reuse pci-bridge hotplug handler handlers for pcie-pci-bridge...
Checking PATCH 39/44: pci/shpc: perform unplug via the hotplug handler...
Checking PATCH 40/44: spapr_pci: perform unplug via the hotplug handler...
WARNING: Block comments use a leading /* on a separate line
#56: FILE: hw/ppc/spapr_pci.c:1487:
+    /* some version guests do not wait for completion of a device

total: 0 errors, 1 warnings, 51 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 41/44: pci: Adjust PCI config limit based on bus topology...
Checking PATCH 42/44: q35: set split kernel irqchip as default...
Checking PATCH 43/44: x86-iommu: switch intr_supported to OnOffAuto type...
Checking PATCH 44/44: x86-iommu: turn on IR by default if proper...
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20181220183059.20726-1-mst@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com