All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@kernel.org>
To: Brian Masney <masneyb@onstation.org>,
	andy.gross@linaro.org, bjorn.andersson@linaro.org,
	linus.walleij@linaro.org
Cc: marc.zyngier@arm.com, shawnguo@kernel.org, dianders@chromium.org,
	linux-gpio@vger.kernel.org, nicolas.dechesne@linaro.org,
	niklas.cassel@linaro.org, david.brown@linaro.org,
	robh+dt@kernel.org, mark.rutland@arm.com,
	thierry.reding@gmail.com, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 3/3] ARM: dts: qcom: msm8974: add interrupt properties
Date: Thu, 03 Jan 2019 16:29:37 -0800	[thread overview]
Message-ID: <154656177748.15366.4715288412613717364@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20181229114755.8711-4-masneyb@onstation.org>

Quoting Brian Masney (2018-12-29 03:47:55)
> Add interrupt properties now that spmi-gpio is a proper hierarchical IRQ
> chip.
> 
> Signed-off-by: Brian Masney <masneyb@onstation.org>
> ---
>  arch/arm/boot/dts/qcom-pm8941.dtsi | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/qcom-pm8941.dtsi b/arch/arm/boot/dts/qcom-pm8941.dtsi
> index 9a91b758f7aa..d0b7f0eff288 100644
> --- a/arch/arm/boot/dts/qcom-pm8941.dtsi
> +++ b/arch/arm/boot/dts/qcom-pm8941.dtsi
> @@ -65,6 +65,9 @@
>                         gpio-controller;
>                         gpio-ranges = <&pm8941_gpios 0 0 36>;
>                         #gpio-cells = <2>;
> +                       interrupt-parent = <&spmi_bus>;
> +                       interrupt-controller;
> +                       #interrupt-cells = <4>;
>                         interrupts = <0 0xc0 0 IRQ_TYPE_NONE>,
>                                      <0 0xc1 0 IRQ_TYPE_NONE>,
>                                      <0 0xc2 0 IRQ_TYPE_NONE>,

Shouldn't we remove the interrupts property here then? Although we use
it to count the number of gpios that are supported so I guess we'll have
to specify it all the time now just to know how many pins there are.
Alternatively we change the driver to know about all the different
compatibles and use the right number of gpios for each compatible string
that we see.

  reply	other threads:[~2019-01-04  0:29 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-29 11:47 [PATCH 0/3] qcom: spmi: add support for hierarchical IRQ chip Brian Masney
2018-12-29 11:47 ` [PATCH 1/3] spmi: pmic-arb: convert to v2 irq interfaces to support hierarchical IRQ chips Brian Masney
2019-01-05  0:25   ` Stephen Boyd
2019-01-05  1:45     ` Brian Masney
2019-01-11 12:29       ` Linus Walleij
2019-01-11 12:29         ` Linus Walleij
2018-12-29 11:47 ` [PATCH 2/3] qcom: spmi-gpio: add support for hierarchical IRQ chip Brian Masney
2019-01-04  0:48   ` Stephen Boyd
2019-01-05 12:08     ` Brian Masney
2019-01-05 12:51       ` Brian Masney
2018-12-29 11:47 ` [PATCH 3/3] ARM: dts: qcom: msm8974: add interrupt properties Brian Masney
2019-01-04  0:29   ` Stephen Boyd [this message]
2018-12-30 20:11 ` [PATCH 0/3] qcom: spmi: add support for hierarchical IRQ chip Linus Walleij
2018-12-30 20:11   ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=154656177748.15366.4715288412613717364@swboyd.mtv.corp.google.com \
    --to=sboyd@kernel.org \
    --cc=andy.gross@linaro.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=david.brown@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=mark.rutland@arm.com \
    --cc=masneyb@onstation.org \
    --cc=nicolas.dechesne@linaro.org \
    --cc=niklas.cassel@linaro.org \
    --cc=robh+dt@kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.