From mboxrd@z Thu Jan 1 00:00:00 1970 From: Luca Boccassi Subject: Re: [dpdk-stable] [dpdk-techboard] [PATCH 2/2] build: use dependency() instead of find_library() Date: Mon, 07 Jan 2019 21:09:23 +0000 Message-ID: <1546895363.6022.31.camel@debian.org> References: <20190103175725.5836-1-bluca@debian.org> <20190107165552.GA23828@bricha3-MOBL.ger.corp.intel.com> <4262310.sn7WroDi98@xps> <2105533.CpohIH1hI0@xps> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Cc: techboard@dpdk.org, dev@dpdk.org To: Thomas Monjalon , Bruce Richardson Return-path: In-Reply-To: <2105533.CpohIH1hI0@xps> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 2019-01-07 at 18:45 +0100, Thomas Monjalon wrote: > 07/01/2019 18:03, Thomas Monjalon: > > 07/01/2019 17:55, Bruce Richardson: > > > On Mon, Jan 07, 2019 at 04:39:34PM +0000, Luca Boccassi wrote: > > > > On Mon, 2019-01-07 at 14:28 +0000, Bruce Richardson wrote: > > > > > However, in > > > > > conjunction with meson version checks, I believe this was > > > > > done this > > > > > way > > > > > originally because of a meson bug which caused recursive > > > > > dependencies > > > > > for > > > > > things like this to get duplicated many times in the > > > > > build.ninja > > > > > file. > > > > >=20 > > > > > https://github.com/mesonbuild/meson/issues/2150 > > > > >=20 > > > > > If we take the approach of adding bsd explicitly using > > > > > dependency > > > > > object > > > > > our minimum version needs to have the fix for this bug > > > > > included. > > > >=20 > > > > Ah that's not nice. Just verified, and it happens with > > > > dependency() as > > > > well as find_library(). It was fixed in 0.47.1. > > > >=20 > > >=20 > > > Yep, it was a right royal pain when I was doing the original > > > work. Now that > > > there is a fix in, we can do cleanups like you suggest if we are > > > prepared > > > to bump our minimum version. > > >=20 > > > I'll refer back to the key question here: > > > "Is it reasonable to ask users compiling DPDK to pull meson from > > > pip rather > > > than using the distro built-in version?" > > > [Adding techboard on CC, in the hopes they might have some > > > thoughts] > > >=20 > > > If it is ok for most folks, and personally I don't think it's a > > > big deal, > > > then that gives us a faster path forward. If not, we raise the > > > minimum more > > > slowly, and keep the existing way of managing the dependencies > > > for a while > > > longer. Worst case, I'd still hope by 19.11 LTS for us to have > > > minimum > > > 0.47.1 to have the fix in question. > >=20 > > Please, could you describe what are the meson versions in major > > distros? >=20 > It was already listed by Luca in this thread (thanks Bruce). > I looks like latest Debian/Ubuntu and Fedora have meson 0.47 or > higher. >=20 > I vote for bumping to meson 0.47. For the benefit of the rest of the tech board which was not CCed directly in the original thread: Debian 10 0.49 Ubuntu 18.04 LTS 0.45 Ubuntu 18.10 0.47 Fedora 27 0.43 Fedora 28 0.45 SUSE Leap 15 0.46 FreeBSD 10 0.46 CentOS 7 0.47 --=20 Kind regards, Luca Boccassi