From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mimi Zohar Date: Wed, 09 Jan 2019 19:21:11 +0000 Subject: Re: [RFC PATCH 1/2] integrity, KEYS: add a reference to platform keyring Message-Id: <1547061671.19931.239.camel@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="ibm852" Content-Transfer-Encoding: base64 List-Id: References: <20190109164824.19708-1-kasong@redhat.com> <20190109164824.19708-2-kasong@redhat.com> In-Reply-To: <20190109164824.19708-2-kasong@redhat.com> To: Kairui Song , linux-kernel@vger.kernel.org Cc: dhowells@redhat.com, dwmw2@infradead.org, jwboyer@fedoraproject.org, keyrings@vger.kernel.org, jmorris@namei.org, serge@hallyn.com, bauerman@linux.ibm.com, ebiggers@google.com, nayna@linux.ibm.com, dyoung@redhat.com, linux-integrity@vger.kernel.org, kexec@lists.infradead.org T24gVGh1LCAyMDE5LTAxLTEwIGF0IDAwOjQ4ICswODAwLCBLYWlydWkgU29uZyB3cm90ZToKPiBD dXJyZW50bHkga2V4ZWNfZmlsZV9sb2FkIHdpbGwgdmVyaWZ5IHRoZSBrZXJuZWwgaW1hZ2UgYmVp bmcgbG9hZGVkCj4gYWdhaW5zdCAuYnVpbHRpbl90cnVzdGVkX2tleXMgb3IgLnNlY29uZGFyeV90 cnVzdGVkX2tleXMsIGJ1dCB0aGUKPiBpbWFnZSBjb3VsZCBiZSBzaWduZWQgd2l0aCB0aGlyZCBw YXJ0IGtleXMgd2hpY2ggd2lsbCBiZSBwcm92aWRlZCBieQo+IHBsYXRmb3JtIG9yIGZpcm13YXJl IGFuZCB0aGUga2V5cyB3b24ndCBiZSBhdmFpbGFibGUgaW4ga2V5cmluZ3MgbWVudGlvbmVkCj4g YWJvdmUuCj4gCj4gQWZ0ZXIgY29tbWl0IGVhOTMxMDJmMzIyNCAoJ2ludGVncml0eTogRGVmaW5l IGEgdHJ1c3RlZCBwbGF0Zm9ybSBrZXlyaW5nJykKPiBhIC5wbGF0Zm9ybSBrZXlyaW5nIGlzIGlu dHJvZHVjZWQgdG8gc3RvcmUgdGhlIGtleXMgcHJvdmlkZWQgYnkgcGxhdGZvcm0KPiBvciBmaXJt d2FyZS4gQW5kIHdpdGggYSBmZXcgZm9sbG93aW5nIGNvbW1pdHMsIG5vdyBrZXlzIHJlcXVpcmVk IHRvIHZlcmlmeQo+IHRoZSBpbWFnZSBpcyBiZWluZyBpbXBvcnRlZCB0byAucGxhdGZvcm0ga2V5 cmluZywgYnV0IGN1cnJlbnRseSwgb25seQo+IElNQS1hcHByYWlzYWwgY291bGQgdXNlIHRoZSBr ZXlyaW5nIGFuZCB2ZXJpZnkgdGhlIGltYWdlLgo+IAo+IFRoaXMgcGF0Y2ggZXhwb3NlcyB0aGUg LnBsYXRmb3JtIGFuZCBtYWtlcyBvdGhlciBjb21wb25lbnRzLCBsaWtlCj4ga2V4ZWNfZmlsZV9s b2FkLCBjb3VsZCB1c2UgdGhpcyAucGxhdGZvcm0ga2V5cmluZyB0byB2ZXJpZnkgdGhlCj4ga2Vy bmVsIGltYWdlLgoKVGhlICJwbGF0Zm9ybSIga2V5cmluZyB3YXMgdXBzdHJlYW1lZCBpbiBvcmRl ciB0byB2ZXJpZnkgdGhlIGtlcm5lbAppbWFnZSBiZWluZyBsb2FkZWQgYnkgdGhlIGtleGVjX2Zp bGVfbG9hZCBzeXNjYWxsLiDCoFRoZSBpbnRlbnRpb25zIG9mCnRoaXMgcGF0Y2ggZGVzY3JpcHRp b24gbmVlZHMgdG8gYmUgY2xlYXJlci4KCj4gCj4gU3VnZ2VzdGVkLWJ5OiBNaW1pIFpvaGFyIDx6 b2hhckBsaW51eC5pYm0uY29tPgo+IFNpZ25lZC1vZmYtYnk6IEthaXJ1aSBTb25nIDxrYXNvbmdA cmVkaGF0LmNvbT4KPiAtLS0KPiAgY2VydHMvc3lzdGVtX2tleXJpbmcuYyAgICAgICAgfCAzICsr Kwo+ICBpbmNsdWRlL2tleXMvc3lzdGVtX2tleXJpbmcuaCB8IDUgKysrKysKPiAgc2VjdXJpdHkv aW50ZWdyaXR5L2RpZ3NpZy5jICAgfCA0ICsrKysKPiAgMyBmaWxlcyBjaGFuZ2VkLCAxMiBpbnNl cnRpb25zKCspCj4gCj4gZGlmZiAtLWdpdCBhL2NlcnRzL3N5c3RlbV9rZXlyaW5nLmMgYi9jZXJ0 cy9zeXN0ZW1fa2V5cmluZy5jCj4gaW5kZXggODE3Mjg3MTc1MjNkLi5hNjFiOTUzOTBiODAgMTAw NjQ0Cj4gLS0tIGEvY2VydHMvc3lzdGVtX2tleXJpbmcuYwo+ICsrKyBiL2NlcnRzL3N5c3RlbV9r ZXlyaW5nLmMKPiBAQCAtMjQsNiArMjQsOSBAQCBzdGF0aWMgc3RydWN0IGtleSAqYnVpbHRpbl90 cnVzdGVkX2tleXM7Cj4gICNpZmRlZiBDT05GSUdfU0VDT05EQVJZX1RSVVNURURfS0VZUklORwo+ ICBzdGF0aWMgc3RydWN0IGtleSAqc2Vjb25kYXJ5X3RydXN0ZWRfa2V5czsKPiAgI2VuZGlmCj4g KyNpZmRlZiBDT05GSUdfSU5URUdSSVRZX1BMQVRGT1JNX0tFWVJJTkcKPiArc3RydWN0IGtleSAq cGxhdGZvcm1fdHJ1c3RlZF9rZXlzOwoKUGxlYXNlIG1ha2UgaXQgc3RhdGljLgoKTWltaQoKPiAr I2VuZGlmCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9182AC43387 for ; Wed, 9 Jan 2019 19:22:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 68B9B206BA for ; Wed, 9 Jan 2019 19:22:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728426AbfAITWc (ORCPT ); Wed, 9 Jan 2019 14:22:32 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:47308 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728173AbfAITWb (ORCPT ); Wed, 9 Jan 2019 14:22:31 -0500 Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id x09J8SC1053228 for ; Wed, 9 Jan 2019 14:22:30 -0500 Received: from e06smtp07.uk.ibm.com (e06smtp07.uk.ibm.com [195.75.94.103]) by mx0b-001b2d01.pphosted.com with ESMTP id 2pwn7pn7f7-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 09 Jan 2019 14:22:30 -0500 Received: from localhost by e06smtp07.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 9 Jan 2019 19:22:28 -0000 Received: from b06cxnps4074.portsmouth.uk.ibm.com (9.149.109.196) by e06smtp07.uk.ibm.com (192.168.101.137) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Wed, 9 Jan 2019 19:22:24 -0000 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x09JMMx49633820 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 9 Jan 2019 19:22:22 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id ABB85AE045; Wed, 9 Jan 2019 19:22:22 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E8F84AE057; Wed, 9 Jan 2019 19:21:31 +0000 (GMT) Received: from localhost.localdomain (unknown [9.80.105.240]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTP; Wed, 9 Jan 2019 19:21:31 +0000 (GMT) Subject: Re: [RFC PATCH 1/2] integrity, KEYS: add a reference to platform keyring From: Mimi Zohar To: Kairui Song , linux-kernel@vger.kernel.org Cc: dhowells@redhat.com, dwmw2@infradead.org, jwboyer@fedoraproject.org, keyrings@vger.kernel.org, jmorris@namei.org, serge@hallyn.com, bauerman@linux.ibm.com, ebiggers@google.com, nayna@linux.ibm.com, dyoung@redhat.com, linux-integrity@vger.kernel.org, kexec@lists.infradead.org Date: Wed, 09 Jan 2019 14:21:11 -0500 In-Reply-To: <20190109164824.19708-2-kasong@redhat.com> References: <20190109164824.19708-1-kasong@redhat.com> <20190109164824.19708-2-kasong@redhat.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 (3.20.5-1.fc24) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 19010919-0028-0000-0000-00000336AB22 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19010919-0029-0000-0000-000023F3BD09 Message-Id: <1547061671.19931.239.camel@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-01-09_10:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1901090157 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2019-01-10 at 00:48 +0800, Kairui Song wrote: > Currently kexec_file_load will verify the kernel image being loaded > against .builtin_trusted_keys or .secondary_trusted_keys, but the > image could be signed with third part keys which will be provided by > platform or firmware and the keys won't be available in keyrings mentioned > above. > > After commit ea93102f3224 ('integrity: Define a trusted platform keyring') > a .platform keyring is introduced to store the keys provided by platform > or firmware. And with a few following commits, now keys required to verify > the image is being imported to .platform keyring, but currently, only > IMA-appraisal could use the keyring and verify the image. > > This patch exposes the .platform and makes other components, like > kexec_file_load, could use this .platform keyring to verify the > kernel image. The "platform" keyring was upstreamed in order to verify the kernel image being loaded by the kexec_file_load syscall.  The intentions of this patch description needs to be clearer. > > Suggested-by: Mimi Zohar > Signed-off-by: Kairui Song > --- > certs/system_keyring.c | 3 +++ > include/keys/system_keyring.h | 5 +++++ > security/integrity/digsig.c | 4 ++++ > 3 files changed, 12 insertions(+) > > diff --git a/certs/system_keyring.c b/certs/system_keyring.c > index 81728717523d..a61b95390b80 100644 > --- a/certs/system_keyring.c > +++ b/certs/system_keyring.c > @@ -24,6 +24,9 @@ static struct key *builtin_trusted_keys; > #ifdef CONFIG_SECONDARY_TRUSTED_KEYRING > static struct key *secondary_trusted_keys; > #endif > +#ifdef CONFIG_INTEGRITY_PLATFORM_KEYRING > +struct key *platform_trusted_keys; Please make it static. Mimi > +#endif From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1ghJQu-0007Dm-A5 for kexec@lists.infradead.org; Wed, 09 Jan 2019 19:22:33 +0000 Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id x09J8U0V128082 for ; Wed, 9 Jan 2019 14:22:31 -0500 Received: from e06smtp07.uk.ibm.com (e06smtp07.uk.ibm.com [195.75.94.103]) by mx0a-001b2d01.pphosted.com with ESMTP id 2pwkbfb6vj-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 09 Jan 2019 14:22:30 -0500 Received: from localhost by e06smtp07.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 9 Jan 2019 19:22:28 -0000 Subject: Re: [RFC PATCH 1/2] integrity, KEYS: add a reference to platform keyring From: Mimi Zohar Date: Wed, 09 Jan 2019 14:21:11 -0500 In-Reply-To: <20190109164824.19708-2-kasong@redhat.com> References: <20190109164824.19708-1-kasong@redhat.com> <20190109164824.19708-2-kasong@redhat.com> Mime-Version: 1.0 Message-Id: <1547061671.19931.239.camel@linux.ibm.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Kairui Song , linux-kernel@vger.kernel.org Cc: jwboyer@fedoraproject.org, ebiggers@google.com, dyoung@redhat.com, nayna@linux.ibm.com, kexec@lists.infradead.org, jmorris@namei.org, dhowells@redhat.com, keyrings@vger.kernel.org, linux-integrity@vger.kernel.org, dwmw2@infradead.org, bauerman@linux.ibm.com, serge@hallyn.com T24gVGh1LCAyMDE5LTAxLTEwIGF0IDAwOjQ4ICswODAwLCBLYWlydWkgU29uZyB3cm90ZToKPiBD dXJyZW50bHkga2V4ZWNfZmlsZV9sb2FkIHdpbGwgdmVyaWZ5IHRoZSBrZXJuZWwgaW1hZ2UgYmVp bmcgbG9hZGVkCj4gYWdhaW5zdCAuYnVpbHRpbl90cnVzdGVkX2tleXMgb3IgLnNlY29uZGFyeV90 cnVzdGVkX2tleXMsIGJ1dCB0aGUKPiBpbWFnZSBjb3VsZCBiZSBzaWduZWQgd2l0aCB0aGlyZCBw YXJ0IGtleXMgd2hpY2ggd2lsbCBiZSBwcm92aWRlZCBieQo+IHBsYXRmb3JtIG9yIGZpcm13YXJl IGFuZCB0aGUga2V5cyB3b24ndCBiZSBhdmFpbGFibGUgaW4ga2V5cmluZ3MgbWVudGlvbmVkCj4g YWJvdmUuCj4gCj4gQWZ0ZXIgY29tbWl0IGVhOTMxMDJmMzIyNCAoJ2ludGVncml0eTogRGVmaW5l IGEgdHJ1c3RlZCBwbGF0Zm9ybSBrZXlyaW5nJykKPiBhIC5wbGF0Zm9ybSBrZXlyaW5nIGlzIGlu dHJvZHVjZWQgdG8gc3RvcmUgdGhlIGtleXMgcHJvdmlkZWQgYnkgcGxhdGZvcm0KPiBvciBmaXJt d2FyZS4gQW5kIHdpdGggYSBmZXcgZm9sbG93aW5nIGNvbW1pdHMsIG5vdyBrZXlzIHJlcXVpcmVk IHRvIHZlcmlmeQo+IHRoZSBpbWFnZSBpcyBiZWluZyBpbXBvcnRlZCB0byAucGxhdGZvcm0ga2V5 cmluZywgYnV0IGN1cnJlbnRseSwgb25seQo+IElNQS1hcHByYWlzYWwgY291bGQgdXNlIHRoZSBr ZXlyaW5nIGFuZCB2ZXJpZnkgdGhlIGltYWdlLgo+IAo+IFRoaXMgcGF0Y2ggZXhwb3NlcyB0aGUg LnBsYXRmb3JtIGFuZCBtYWtlcyBvdGhlciBjb21wb25lbnRzLCBsaWtlCj4ga2V4ZWNfZmlsZV9s b2FkLCBjb3VsZCB1c2UgdGhpcyAucGxhdGZvcm0ga2V5cmluZyB0byB2ZXJpZnkgdGhlCj4ga2Vy bmVsIGltYWdlLgoKVGhlICJwbGF0Zm9ybSIga2V5cmluZyB3YXMgdXBzdHJlYW1lZCBpbiBvcmRl ciB0byB2ZXJpZnkgdGhlIGtlcm5lbAppbWFnZSBiZWluZyBsb2FkZWQgYnkgdGhlIGtleGVjX2Zp bGVfbG9hZCBzeXNjYWxsLiDCoFRoZSBpbnRlbnRpb25zIG9mCnRoaXMgcGF0Y2ggZGVzY3JpcHRp b24gbmVlZHMgdG8gYmUgY2xlYXJlci4KCj4gCj4gU3VnZ2VzdGVkLWJ5OiBNaW1pIFpvaGFyIDx6 b2hhckBsaW51eC5pYm0uY29tPgo+IFNpZ25lZC1vZmYtYnk6IEthaXJ1aSBTb25nIDxrYXNvbmdA cmVkaGF0LmNvbT4KPiAtLS0KPiAgY2VydHMvc3lzdGVtX2tleXJpbmcuYyAgICAgICAgfCAzICsr Kwo+ICBpbmNsdWRlL2tleXMvc3lzdGVtX2tleXJpbmcuaCB8IDUgKysrKysKPiAgc2VjdXJpdHkv aW50ZWdyaXR5L2RpZ3NpZy5jICAgfCA0ICsrKysKPiAgMyBmaWxlcyBjaGFuZ2VkLCAxMiBpbnNl cnRpb25zKCspCj4gCj4gZGlmZiAtLWdpdCBhL2NlcnRzL3N5c3RlbV9rZXlyaW5nLmMgYi9jZXJ0 cy9zeXN0ZW1fa2V5cmluZy5jCj4gaW5kZXggODE3Mjg3MTc1MjNkLi5hNjFiOTUzOTBiODAgMTAw NjQ0Cj4gLS0tIGEvY2VydHMvc3lzdGVtX2tleXJpbmcuYwo+ICsrKyBiL2NlcnRzL3N5c3RlbV9r ZXlyaW5nLmMKPiBAQCAtMjQsNiArMjQsOSBAQCBzdGF0aWMgc3RydWN0IGtleSAqYnVpbHRpbl90 cnVzdGVkX2tleXM7Cj4gICNpZmRlZiBDT05GSUdfU0VDT05EQVJZX1RSVVNURURfS0VZUklORwo+ ICBzdGF0aWMgc3RydWN0IGtleSAqc2Vjb25kYXJ5X3RydXN0ZWRfa2V5czsKPiAgI2VuZGlmCj4g KyNpZmRlZiBDT05GSUdfSU5URUdSSVRZX1BMQVRGT1JNX0tFWVJJTkcKPiArc3RydWN0IGtleSAq cGxhdGZvcm1fdHJ1c3RlZF9rZXlzOwoKUGxlYXNlIG1ha2UgaXQgc3RhdGljLgoKTWltaQoKPiAr I2VuZGlmCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K a2V4ZWMgbWFpbGluZyBsaXN0CmtleGVjQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3Rz LmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9rZXhlYwo=