From: wentalou <Wentao.Lou-5C7GfCeVMHo@public.gmane.org>
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Cc: wentalou <Wentao.Lou-5C7GfCeVMHo@public.gmane.org>
Subject: [PATCH] drm/amdgpu: csa_vaddr should not larger than AMDGPU_GMC_HOLE_START
Date: Mon, 14 Jan 2019 16:40:36 +0800 [thread overview]
Message-ID: <1547455236-30130-1-git-send-email-Wentao.Lou@amd.com> (raw)
After removing unnecessary VM size calculations,
vm_manager.max_pfn would reach 0x10,0000,0000
max_pfn << AMDGPU_GPU_PAGE_SHIFT exceeding AMDGPU_GMC_HOLE_START
would caused GPU reset.
Change-Id: I47ad0be2b0bd9fb7490c4e1d7bb7bdacf71132cb
Signed-off-by: wentalou <Wentao.Lou@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_csa.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_csa.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_csa.c
index 7e22be7..dd3bd01 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_csa.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_csa.c
@@ -26,7 +26,8 @@
uint64_t amdgpu_csa_vaddr(struct amdgpu_device *adev)
{
- uint64_t addr = adev->vm_manager.max_pfn << AMDGPU_GPU_PAGE_SHIFT;
+ uint64_t addr = min(adev->vm_manager.max_pfn << AMDGPU_GPU_PAGE_SHIFT,
+ AMDGPU_GMC_HOLE_START);
addr -= AMDGPU_VA_RESERVED_SIZE;
addr = amdgpu_gmc_sign_extend(addr);
--
2.7.4
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next reply other threads:[~2019-01-14 8:40 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-14 8:40 wentalou [this message]
[not found] ` <1547455236-30130-1-git-send-email-Wentao.Lou-5C7GfCeVMHo@public.gmane.org>
2019-01-14 9:05 ` [PATCH] drm/amdgpu: csa_vaddr should not larger than AMDGPU_GMC_HOLE_START Liu, Monk
2019-01-14 13:05 ` Christian König
[not found] ` <37b395b0-8503-238f-8775-66eb8795d23f-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-01-15 6:19 ` Liu, Monk
[not found] ` <CY4PR1201MB0245AB79C8C8319D8DFB3A3884810-1iTaO6aE1DBfNQakwlCMTGrFom/aUZj6nBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2019-01-15 8:02 ` Koenig, Christian
[not found] ` <7f3f7b71-7acc-689a-e1d8-6fb184771f7b-5C7GfCeVMHo@public.gmane.org>
2019-01-16 9:34 ` Lou, Wentao
[not found] ` <BYAPR12MB2742181357E4D7DF7C171EE983820-ZGDeBxoHBPmbrehcvEBedAdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2019-01-16 9:47 ` Koenig, Christian
[not found] ` <574d6ca8-f1c8-8ac0-3dbe-23aed7c0125d-5C7GfCeVMHo@public.gmane.org>
2019-01-17 3:17 ` Lou, Wentao
[not found] ` <BYAPR12MB27427158A5684A31BF96AB4783830-ZGDeBxoHBPmbrehcvEBedAdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2019-01-17 7:39 ` Koenig, Christian
[not found] ` <361544e2-dd33-3b89-1211-4566b060b785-5C7GfCeVMHo@public.gmane.org>
2019-01-17 8:04 ` Liu, Monk
[not found] ` <CY4PR1201MB0245C5E3F6810C9157C9FDCF84830-1iTaO6aE1DBfNQakwlCMTGrFom/aUZj6nBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2019-01-17 8:30 ` Koenig, Christian
[not found] ` <859dcf48-f4bf-d3ec-0893-369c7fad51ed-5C7GfCeVMHo@public.gmane.org>
2019-01-17 13:19 ` Liu, Monk
[not found] ` <CY4PR1201MB0245C8076917864AA97A0FFA84830-1iTaO6aE1DBfNQakwlCMTGrFom/aUZj6nBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2019-01-17 13:25 ` Koenig, Christian
[not found] ` <cf3489f5-deb2-85ef-844a-b4c050f71d29-5C7GfCeVMHo@public.gmane.org>
2019-01-18 1:32 ` Liu, Monk
[not found] ` <CY4PR1201MB02457ECA700E3AE8B321AC90849C0-1iTaO6aE1DBfNQakwlCMTGrFom/aUZj6nBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2019-01-18 9:11 ` Christian König
[not found] ` <c83cd7ec-03a5-45c0-b497-d5a5ec838880-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-01-18 9:29 ` Chunming Zhou
[not found] ` <effb374a-9803-d451-41c4-991a2cd0aa9a-5C7GfCeVMHo@public.gmane.org>
2019-01-18 10:39 ` Koenig, Christian
2019-01-18 10:57 ` Liu, Monk
[not found] ` <CY4PR1201MB0245D532D38DBA7F9BC445B9849C0-1iTaO6aE1DBfNQakwlCMTGrFom/aUZj6nBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2019-01-18 12:20 ` Koenig, Christian
[not found] ` <eff1c302-1c8d-e358-077e-704b67c3bd41-5C7GfCeVMHo@public.gmane.org>
2019-01-21 4:35 ` Liu, Monk
[not found] ` <DM5PR1201MB02516E33597C13BAA8C72299849F0-grEf7a3NxMClG5oLOQIDXGrFom/aUZj6nBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2019-01-21 9:55 ` Koenig, Christian
[not found] ` <c700df28-900c-f097-4ceb-0e6e8dcd35e8-5C7GfCeVMHo@public.gmane.org>
2019-01-29 22:33 ` Kuehling, Felix
2019-01-18 4:44 ` Lou, Wentao
[not found] ` <BYAPR12MB274227E7B0D66F840747EB3C839C0-ZGDeBxoHBPmbrehcvEBedAdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2019-01-18 9:01 ` Koenig, Christian
[not found] ` <b5d15c16-a023-3fb0-d5e3-b12276b6fc04-5C7GfCeVMHo@public.gmane.org>
2019-01-18 11:07 ` Liu, Monk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1547455236-30130-1-git-send-email-Wentao.Lou@amd.com \
--to=wentao.lou-5c7gfcevmho@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.