All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] build: mention machine=default and its use in documentation
@ 2019-01-14 11:23 Luca Boccassi
  2019-01-14 13:32 ` Christian Ehrhardt
                   ` (2 more replies)
  0 siblings, 3 replies; 10+ messages in thread
From: Luca Boccassi @ 2019-01-14 11:23 UTC (permalink / raw)
  To: dev; +Cc: jerinj, bruce.richardson, Luca Boccassi

Signed-off-by: Luca Boccassi <bluca@debian.org>
---
 doc/build-sdk-meson.txt | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/doc/build-sdk-meson.txt b/doc/build-sdk-meson.txt
index 29a8bd387..2efff58e2 100644
--- a/doc/build-sdk-meson.txt
+++ b/doc/build-sdk-meson.txt
@@ -87,6 +87,8 @@ Project-specific options are passed used -Doption=value::
 
 	meson -Denable_docs=true fullbuild  # build and install docs
 
+	meson -Dmachine=default  # user builder-independent baseline -march
+
 Examples of setting the same options using meson configure::
 
 	meson configure -Dwerror=true
@@ -103,6 +105,9 @@ should be used to change the build settings within the directory, and when
 ``ninja`` is called to do the build itself, it will trigger the necessary
 re-scan from meson.
 
+NOTE: machine=default will use the minimum required -march on all architectures
+regardless of the capabilities of the machine where the build is happening.
+
 As well as those settings taken from ``meson configure``, other options
 such as the compiler to use can be passed via environment variables. For
 example::
-- 
2.20.1

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] build: mention machine=default and its use in documentation
  2019-01-14 11:23 [PATCH] build: mention machine=default and its use in documentation Luca Boccassi
@ 2019-01-14 13:32 ` Christian Ehrhardt
  2019-01-14 13:44   ` Luca Boccassi
  2019-01-14 13:41 ` [PATCH v2] " Luca Boccassi
  2019-04-18  9:30 ` [dpdk-dev] [PATCH v3] " luca.boccassi
  2 siblings, 1 reply; 10+ messages in thread
From: Christian Ehrhardt @ 2019-01-14 13:32 UTC (permalink / raw)
  To: Luca Boccassi; +Cc: dev, jerinj, Bruce Richardson

On Mon, Jan 14, 2019 at 1:23 PM Luca Boccassi <bluca@debian.org> wrote:
>
> Signed-off-by: Luca Boccassi <bluca@debian.org>
> ---
>  doc/build-sdk-meson.txt | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/doc/build-sdk-meson.txt b/doc/build-sdk-meson.txt
> index 29a8bd387..2efff58e2 100644
> --- a/doc/build-sdk-meson.txt
> +++ b/doc/build-sdk-meson.txt
> @@ -87,6 +87,8 @@ Project-specific options are passed used -Doption=value::
>
>         meson -Denable_docs=true fullbuild  # build and install docs
>
> +       meson -Dmachine=default  # user builder-independent baseline -march

Thanks for driving all the proper builder independent config Luca.
In this line I'd assume you meant "use" not "user" right?

Other than that:
Reviewed-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>

> +
>  Examples of setting the same options using meson configure::
>
>         meson configure -Dwerror=true
> @@ -103,6 +105,9 @@ should be used to change the build settings within the directory, and when
>  ``ninja`` is called to do the build itself, it will trigger the necessary
>  re-scan from meson.
>
> +NOTE: machine=default will use the minimum required -march on all architectures
> +regardless of the capabilities of the machine where the build is happening.
> +
>  As well as those settings taken from ``meson configure``, other options
>  such as the compiler to use can be passed via environment variables. For
>  example::
> --
> 2.20.1
>


-- 
Christian Ehrhardt
Software Engineer, Ubuntu Server
Canonical Ltd

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH v2] build: mention machine=default and its use in documentation
  2019-01-14 11:23 [PATCH] build: mention machine=default and its use in documentation Luca Boccassi
  2019-01-14 13:32 ` Christian Ehrhardt
@ 2019-01-14 13:41 ` Luca Boccassi
  2019-02-27 12:16   ` Luca Boccassi
  2019-04-17 20:17   ` [dpdk-dev] " Thomas Monjalon
  2019-04-18  9:30 ` [dpdk-dev] [PATCH v3] " luca.boccassi
  2 siblings, 2 replies; 10+ messages in thread
From: Luca Boccassi @ 2019-01-14 13:41 UTC (permalink / raw)
  To: dev; +Cc: jerinj, bruce.richardson, Luca Boccassi, Christian Ehrhardt

Document the new value, as it's useful for distributions and users
who need to use a stable baseline -march

Signed-off-by: Luca Boccassi <bluca@debian.org>
Reviewed-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
---
v2: fix typo, add commit body and reviewed-by

 doc/build-sdk-meson.txt | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/doc/build-sdk-meson.txt b/doc/build-sdk-meson.txt
index 29a8bd387..ab33ca82a 100644
--- a/doc/build-sdk-meson.txt
+++ b/doc/build-sdk-meson.txt
@@ -87,6 +87,8 @@ Project-specific options are passed used -Doption=value::
 
 	meson -Denable_docs=true fullbuild  # build and install docs
 
+	meson -Dmachine=default  # use builder-independent baseline -march
+
 Examples of setting the same options using meson configure::
 
 	meson configure -Dwerror=true
@@ -103,6 +105,9 @@ should be used to change the build settings within the directory, and when
 ``ninja`` is called to do the build itself, it will trigger the necessary
 re-scan from meson.
 
+NOTE: machine=default will use the minimum required -march on all architectures
+regardless of the capabilities of the machine where the build is happening.
+
 As well as those settings taken from ``meson configure``, other options
 such as the compiler to use can be passed via environment variables. For
 example::
-- 
2.20.1

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] build: mention machine=default and its use in documentation
  2019-01-14 13:32 ` Christian Ehrhardt
@ 2019-01-14 13:44   ` Luca Boccassi
  0 siblings, 0 replies; 10+ messages in thread
From: Luca Boccassi @ 2019-01-14 13:44 UTC (permalink / raw)
  To: Christian Ehrhardt; +Cc: dev, jerinj, Bruce Richardson

On Mon, 2019-01-14 at 15:32 +0200, Christian Ehrhardt wrote:
> On Mon, Jan 14, 2019 at 1:23 PM Luca Boccassi <bluca@debian.org>
> wrote:
> > 
> > Signed-off-by: Luca Boccassi <bluca@debian.org>
> > ---
> >  doc/build-sdk-meson.txt | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/doc/build-sdk-meson.txt b/doc/build-sdk-meson.txt
> > index 29a8bd387..2efff58e2 100644
> > --- a/doc/build-sdk-meson.txt
> > +++ b/doc/build-sdk-meson.txt
> > @@ -87,6 +87,8 @@ Project-specific options are passed used
> > -Doption=value::
> > 
> >         meson -Denable_docs=true fullbuild  # build and install
> > docs
> > 
> > +       meson -Dmachine=default  # user builder-independent
> > baseline -march
> 
> Thanks for driving all the proper builder independent config Luca.
> In this line I'd assume you meant "use" not "user" right?
> 
> Other than that:
> Reviewed-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>

Yes indeed it's a typo, fixed in v2, thanks

-- 
Kind regards,
Luca Boccassi

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2] build: mention machine=default and its use in documentation
  2019-01-14 13:41 ` [PATCH v2] " Luca Boccassi
@ 2019-02-27 12:16   ` Luca Boccassi
  2019-03-18 20:12     ` Jerin Jacob Kollanukkaran
  2019-04-17 20:17   ` [dpdk-dev] " Thomas Monjalon
  1 sibling, 1 reply; 10+ messages in thread
From: Luca Boccassi @ 2019-02-27 12:16 UTC (permalink / raw)
  To: dev

On Mon, 2019-01-14 at 13:41 +0000, Luca Boccassi wrote:
> Document the new value, as it's useful for distributions and users
> who need to use a stable baseline -march
> 
> Signed-off-by: Luca Boccassi <bluca@debian.org>
> Reviewed-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> ---
> v2: fix typo, add commit body and reviewed-by
> 
>  doc/build-sdk-meson.txt | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/doc/build-sdk-meson.txt b/doc/build-sdk-meson.txt
> index 29a8bd387..ab33ca82a 100644
> --- a/doc/build-sdk-meson.txt
> +++ b/doc/build-sdk-meson.txt
> @@ -87,6 +87,8 @@ Project-specific options are passed used
> -Doption=value::
>  
>  	meson -Denable_docs=true fullbuild  # build and install docs
>  
> +	meson -Dmachine=default  # use builder-independent baseline
> -march
> +
>  Examples of setting the same options using meson configure::
>  
>  	meson configure -Dwerror=true
> @@ -103,6 +105,9 @@ should be used to change the build settings
> within the directory, and when
>  ``ninja`` is called to do the build itself, it will trigger the
> necessary
>  re-scan from meson.
>  
> +NOTE: machine=default will use the minimum required -march on all
> architectures
> +regardless of the capabilities of the machine where the build is
> happening.
> +
>  As well as those settings taken from ``meson configure``, other
> options
>  such as the compiler to use can be passed via environment variables.
> For
>  example::

Ping - anything else I can do for this patch? Thanks!

-- 
Kind regards,
Luca Boccassi

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2] build: mention machine=default and its use in documentation
  2019-02-27 12:16   ` Luca Boccassi
@ 2019-03-18 20:12     ` Jerin Jacob Kollanukkaran
  0 siblings, 0 replies; 10+ messages in thread
From: Jerin Jacob Kollanukkaran @ 2019-03-18 20:12 UTC (permalink / raw)
  To: dev, bluca

On Wed, 2019-02-27 at 12:16 +0000, Luca Boccassi wrote:
> On Mon, 2019-01-14 at 13:41 +0000, Luca Boccassi wrote:
> > Document the new value, as it's useful for distributions and users
> > who need to use a stable baseline -march
> > 
> > Signed-off-by: Luca Boccassi <bluca@debian.org>
> > Reviewed-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>

Reviewed-by: Jerin Jacob <jerinj@marvell.com>



^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-dev] [PATCH v2] build: mention machine=default and its use in documentation
  2019-01-14 13:41 ` [PATCH v2] " Luca Boccassi
  2019-02-27 12:16   ` Luca Boccassi
@ 2019-04-17 20:17   ` Thomas Monjalon
  2019-04-18  9:30     ` Luca Boccassi
  1 sibling, 1 reply; 10+ messages in thread
From: Thomas Monjalon @ 2019-04-17 20:17 UTC (permalink / raw)
  To: Luca Boccassi
  Cc: dev, jerinj, bruce.richardson, Christian Ehrhardt, Yongseok Koh

14/01/2019 14:41, Luca Boccassi:
> Document the new value, as it's useful for distributions and users
> who need to use a stable baseline -march
> 
> Signed-off-by: Luca Boccassi <bluca@debian.org>
> Reviewed-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> ---
> +NOTE: machine=default will use the minimum required -march on all architectures
> +regardless of the capabilities of the machine where the build is happening.

This option is not really selecting the minimum but something which works
on every flavours of the CPU architecture.
For instance, on ARM it can select a cacheline of 128B to make it work
with 64B and 128B micro-architectures.

After discussing with Bruce and Luca I was convinced that "default"
is not a good name, and "machine=any" would be better.
The name "default" may also refer, in some contexts, to the config
of the basic/standard CPU design.
Even worst, "default" is not the default machine in DPDK...

Today I am not sure what is the best meaningful name,
and I tend to think that "default" is well understood by everyone.
So I am OK to apply this patch, but please replace
	"minimum required -march"
by
	"config working"
or something similar, thanks.



^ permalink raw reply	[flat|nested] 10+ messages in thread

* [dpdk-dev] [PATCH v3] build: mention machine=default and its use in documentation
  2019-01-14 11:23 [PATCH] build: mention machine=default and its use in documentation Luca Boccassi
  2019-01-14 13:32 ` Christian Ehrhardt
  2019-01-14 13:41 ` [PATCH v2] " Luca Boccassi
@ 2019-04-18  9:30 ` luca.boccassi
  2019-04-18 14:06   ` Thomas Monjalon
  2 siblings, 1 reply; 10+ messages in thread
From: luca.boccassi @ 2019-04-18  9:30 UTC (permalink / raw)
  To: dev; +Cc: thomas

From: Luca Boccassi <bluca@debian.org>

Document the new value, as it's useful for distributions and users
who need to use a stable baseline -march

Signed-off-by: Luca Boccassi <bluca@debian.org>
Reviewed-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Reviewed-by: Jerin Jacob <jerinj@marvell.com>
---
v2: fix typo, add commit body and reviewed-by
v3: added one more reviewed-by, reworded the note as suggested

 doc/build-sdk-meson.txt | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/doc/build-sdk-meson.txt b/doc/build-sdk-meson.txt
index 912cb3a8c..7b802442b 100644
--- a/doc/build-sdk-meson.txt
+++ b/doc/build-sdk-meson.txt
@@ -82,6 +82,8 @@ Project-specific options are passed used -Doption=value::
 
 	meson -Denable_docs=true fullbuild  # build and install docs
 
+	meson -Dmachine=default  # use builder-independent baseline -march
+
 Examples of setting the same options using meson configure::
 
 	meson configure -Dwerror=true
@@ -98,6 +100,9 @@ should be used to change the build settings within the directory, and when
 ``ninja`` is called to do the build itself, it will trigger the necessary
 re-scan from meson.
 
+NOTE: machine=default uses a config that works on all supported architectures
+regardless of the capabilities of the machine where the build is happening.
+
 As well as those settings taken from ``meson configure``, other options
 such as the compiler to use can be passed via environment variables. For
 example::
-- 
2.20.1


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-dev] [PATCH v2] build: mention machine=default and its use in documentation
  2019-04-17 20:17   ` [dpdk-dev] " Thomas Monjalon
@ 2019-04-18  9:30     ` Luca Boccassi
  0 siblings, 0 replies; 10+ messages in thread
From: Luca Boccassi @ 2019-04-18  9:30 UTC (permalink / raw)
  To: Thomas Monjalon; +Cc: dev

On Wed, 2019-04-17 at 22:17 +0200, Thomas Monjalon wrote:
> 14/01/2019 14:41, Luca Boccassi:
> > Document the new value, as it's useful for distributions and users
> > who need to use a stable baseline -march
> > 
> > Signed-off-by: Luca Boccassi <
> > bluca@debian.org
> > >
> > Reviewed-by: Christian Ehrhardt <
> > christian.ehrhardt@canonical.com
> > >
> > ---
> > +NOTE: machine=default will use the minimum required -march on all
> > architectures
> > +regardless of the capabilities of the machine where the build is
> > happening.
> 
> This option is not really selecting the minimum but something which
> works
> on every flavours of the CPU architecture.
> For instance, on ARM it can select a cacheline of 128B to make it
> work
> with 64B and 128B micro-architectures.
> 
> After discussing with Bruce and Luca I was convinced that "default"
> is not a good name, and "machine=any" would be better.
> The name "default" may also refer, in some contexts, to the config
> of the basic/standard CPU design.
> Even worst, "default" is not the default machine in DPDK...
> 
> Today I am not sure what is the best meaningful name,
> and I tend to think that "default" is well understood by everyone.
> So I am OK to apply this patch, but please replace
> 	"minimum required -march"
> by
> 	"config working"
> or something similar, thanks.

No problem, updated in v3, thanks.

-- 
Kind regards,
Luca Boccassi

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-dev] [PATCH v3] build: mention machine=default and its use in documentation
  2019-04-18  9:30 ` [dpdk-dev] [PATCH v3] " luca.boccassi
@ 2019-04-18 14:06   ` Thomas Monjalon
  0 siblings, 0 replies; 10+ messages in thread
From: Thomas Monjalon @ 2019-04-18 14:06 UTC (permalink / raw)
  To: luca.boccassi; +Cc: dev

18/04/2019 11:30, luca.boccassi@gmail.com:
> From: Luca Boccassi <bluca@debian.org>
> 
> Document the new value, as it's useful for distributions and users
> who need to use a stable baseline -march
> 
> Signed-off-by: Luca Boccassi <bluca@debian.org>
> Reviewed-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> Reviewed-by: Jerin Jacob <jerinj@marvell.com>
> ---
> v2: fix typo, add commit body and reviewed-by
> v3: added one more reviewed-by, reworded the note as suggested

Applied, thanks




^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2019-04-18 14:06 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-14 11:23 [PATCH] build: mention machine=default and its use in documentation Luca Boccassi
2019-01-14 13:32 ` Christian Ehrhardt
2019-01-14 13:44   ` Luca Boccassi
2019-01-14 13:41 ` [PATCH v2] " Luca Boccassi
2019-02-27 12:16   ` Luca Boccassi
2019-03-18 20:12     ` Jerin Jacob Kollanukkaran
2019-04-17 20:17   ` [dpdk-dev] " Thomas Monjalon
2019-04-18  9:30     ` Luca Boccassi
2019-04-18  9:30 ` [dpdk-dev] [PATCH v3] " luca.boccassi
2019-04-18 14:06   ` Thomas Monjalon

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.