From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7120C43387 for ; Tue, 15 Jan 2019 10:19:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AF2BA2085A for ; Tue, 15 Jan 2019 10:19:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728439AbfAOKTv (ORCPT ); Tue, 15 Jan 2019 05:19:51 -0500 Received: from relay.sw.ru ([185.231.240.75]:36314 "EHLO relay.sw.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728202AbfAOKTu (ORCPT ); Tue, 15 Jan 2019 05:19:50 -0500 Received: from [172.16.25.169] (helo=localhost.localdomain) by relay.sw.ru with esmtp (Exim 4.91) (envelope-from ) id 1gjLoy-000130-9F; Tue, 15 Jan 2019 13:19:48 +0300 Subject: [PATCH 6/7] fuse: Kill unused FR_ABORTED, FR_LOCKED and FR_PRIVATE flags From: Kirill Tkhai To: miklos@szeredi.hu, ktkhai@virtuozzo.com, linux-fsdevel@vger.kernel.org Date: Tue, 15 Jan 2019 13:19:47 +0300 Message-ID: <154754758730.4244.17451195008535612523.stgit@localhost.localdomain> In-Reply-To: <154754701031.4244.8089449938935364463.stgit@localhost.localdomain> References: <154754701031.4244.8089449938935364463.stgit@localhost.localdomain> User-Agent: StGit/0.18 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Signed-off-by: Kirill Tkhai --- fs/fuse/dev.c | 9 ++------- fs/fuse/fuse_i.h | 14 +------------- 2 files changed, 3 insertions(+), 20 deletions(-) diff --git a/fs/fuse/dev.c b/fs/fuse/dev.c index 4905abfb279e..c3bacf9191a6 100644 --- a/fs/fuse/dev.c +++ b/fs/fuse/dev.c @@ -1349,7 +1349,6 @@ static ssize_t fuse_dev_do_read(struct fuse_dev *fud, struct file *file, (struct fuse_arg *) in->args, 0); fuse_copy_finish(cs); spin_lock(&fpq->lock); - clear_bit(FR_LOCKED, &req->flags); if (!fpq->connected) { err = fc->aborted ? -ECONNABORTED : -ENODEV; goto out_end; @@ -1376,8 +1375,7 @@ static ssize_t fuse_dev_do_read(struct fuse_dev *fud, struct file *file, return reqsize; out_end: - if (!test_bit(FR_PRIVATE, &req->flags)) - list_del_init(&req->list); + list_del_init(&req->list); spin_unlock(&fpq->lock); request_end(fc, req); return err; @@ -1955,7 +1953,6 @@ static ssize_t fuse_dev_do_write(struct fuse_dev *fud, clear_bit(FR_SENT, &req->flags); list_move(&req->list, &fpq->io); req->out.h = oh; - set_bit(FR_LOCKED, &req->flags); spin_unlock(&fpq->lock); cs->req = req; if (!req->out.page_replace) @@ -1965,13 +1962,11 @@ static ssize_t fuse_dev_do_write(struct fuse_dev *fud, fuse_copy_finish(cs); spin_lock(&fpq->lock); - clear_bit(FR_LOCKED, &req->flags); if (!fpq->connected) err = -ENOENT; else if (err) req->out.h.error = -EIO; - if (!test_bit(FR_PRIVATE, &req->flags)) - list_del_init(&req->list); + list_del_init(&req->list); spin_unlock(&fpq->lock); request_end(fc, req); diff --git a/fs/fuse/fuse_i.h b/fs/fuse/fuse_i.h index b5f2265c437c..09ea5773ad81 100644 --- a/fs/fuse/fuse_i.h +++ b/fs/fuse/fuse_i.h @@ -332,35 +332,23 @@ struct fuse_io_priv { * FR_FORCE: force sending of the request even if interrupted * FR_BACKGROUND: request is sent in the background * FR_WAITING: request is counted as "waiting" - * FR_ABORTED: the request was aborted * FR_INTERRUPTED: the request has been interrupted - * FR_LOCKED: data is being copied to/from the request * FR_PENDING: request is not yet in userspace * FR_SENT: request is in userspace, waiting for an answer * FR_FINISHED: request is finished - * FR_PRIVATE: request is on private list */ enum fuse_req_flag { FR_ISREPLY, FR_FORCE, FR_BACKGROUND, FR_WAITING, - FR_ABORTED, FR_INTERRUPTED, - FR_LOCKED, FR_PENDING, FR_SENT, FR_FINISHED, - FR_PRIVATE, }; -/** - * A request to the client - * - * .waitq.lock protects the following fields: - * - FR_ABORTED - * - FR_LOCKED (may also be modified under fc->lock, tested under both) - */ +/* A request to the client */ struct fuse_req { /** This can be on either pending processing or io lists in fuse_conn */