From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A541DC43387 for ; Wed, 16 Jan 2019 09:39:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6F1C420840 for ; Wed, 16 Jan 2019 09:39:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391734AbfAPJjL (ORCPT ); Wed, 16 Jan 2019 04:39:11 -0500 Received: from Mailgw01.mediatek.com ([1.203.163.78]:58213 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1729019AbfAPJjL (ORCPT ); Wed, 16 Jan 2019 04:39:11 -0500 X-UUID: 078d37c2db33413ea58da6945614a314-20190116 X-UUID: 078d37c2db33413ea58da6945614a314-20190116 Received: from mtkcas32.mediatek.inc [(172.27.4.250)] by mailgw01.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLS) with ESMTP id 621702362; Wed, 16 Jan 2019 17:39:06 +0800 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 16 Jan 2019 17:39:04 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Wed, 16 Jan 2019 17:39:02 +0800 Message-ID: <1547631542.4433.232.camel@mhfsdcap03> Subject: Re: [PATCH v2 4/4] usb: musb: Add support for MediaTek musb controller From: Min Guo To: Bin Liu CC: Rob Herring , Greg Kroah-Hartman , Mark Rutland , "Matthias Brugger" , Alan Stern , , , , , , , Yonglong Wu Date: Wed, 16 Jan 2019 17:39:02 +0800 In-Reply-To: <20190115203815.GD18026@uda0271908> References: <1547516626-5084-1-git-send-email-min.guo@mediatek.com> <1547516626-5084-5-git-send-email-min.guo@mediatek.com> <20190115203815.GD18026@uda0271908> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Bin, On Tue, 2019-01-15 at 14:38 -0600, Bin Liu wrote: > Hi Min, > > very close, thanks. > Below I tried to explain a further cleanup in musb_clearb/w() and > musb_get/set_toggle() implementation. Please let me know if it is not > clear. > > Basically, we don't need musb_default_clearb/w(), just assign the > musb_io function pointers to musb_readb/w(). > > Then the mtk platform musb_clearb/w() calls musb_readb/w() and > musb_writeb/w() to handle W1C. Sorry to bother you again, I encounter a problem when prepare the patch. The define of musb_clearb/w and musb_readb/w are difference as follow, and cannot be directly assigned: u8/u16 (*readb/w)(const void __iomem *addr, unsigned offset) void (*clearb/w)(void __iomem *addr, unsigned int offset)) if modify clearb/w as: u8/u16 (*clearb/w)(const void __iomem *addr, unsigned int offset)) then musb_clear needs writeb/w the const addr. Can I delete const in (*readb/w)? > regards, > -Bin. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Min Guo Subject: Re: [PATCH v2 4/4] usb: musb: Add support for MediaTek musb controller Date: Wed, 16 Jan 2019 17:39:02 +0800 Message-ID: <1547631542.4433.232.camel@mhfsdcap03> References: <1547516626-5084-1-git-send-email-min.guo@mediatek.com> <1547516626-5084-5-git-send-email-min.guo@mediatek.com> <20190115203815.GD18026@uda0271908> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190115203815.GD18026@uda0271908> Sender: linux-kernel-owner@vger.kernel.org To: Bin Liu Cc: Rob Herring , Greg Kroah-Hartman , Mark Rutland , Matthias Brugger , Alan Stern , chunfeng.yun@mediatek.com, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Yonglong Wu List-Id: devicetree@vger.kernel.org Hi Bin, On Tue, 2019-01-15 at 14:38 -0600, Bin Liu wrote: > Hi Min, > > very close, thanks. > Below I tried to explain a further cleanup in musb_clearb/w() and > musb_get/set_toggle() implementation. Please let me know if it is not > clear. > > Basically, we don't need musb_default_clearb/w(), just assign the > musb_io function pointers to musb_readb/w(). > > Then the mtk platform musb_clearb/w() calls musb_readb/w() and > musb_writeb/w() to handle W1C. Sorry to bother you again, I encounter a problem when prepare the patch. The define of musb_clearb/w and musb_readb/w are difference as follow, and cannot be directly assigned: u8/u16 (*readb/w)(const void __iomem *addr, unsigned offset) void (*clearb/w)(void __iomem *addr, unsigned int offset)) if modify clearb/w as: u8/u16 (*clearb/w)(const void __iomem *addr, unsigned int offset)) then musb_clear needs writeb/w the const addr. Can I delete const in (*readb/w)? > regards, > -Bin. From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2,4/4] usb: musb: Add support for MediaTek musb controller From: min.guo@mediatek.com Message-Id: <1547631542.4433.232.camel@mhfsdcap03> Date: Wed, 16 Jan 2019 17:39:02 +0800 To: Bin Liu Cc: Rob Herring , Greg Kroah-Hartman , Mark Rutland , Matthias Brugger , Alan Stern , chunfeng.yun@mediatek.com, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Yonglong Wu List-ID: SGkgQmluLAoKT24gVHVlLCAyMDE5LTAxLTE1IGF0IDE0OjM4IC0wNjAwLCBCaW4gTGl1IHdyb3Rl Ogo+IEhpIE1pbiwKPiAKPiB2ZXJ5IGNsb3NlLCB0aGFua3MuCj4gQmVsb3cgSSB0cmllZCB0byBl eHBsYWluIGEgZnVydGhlciBjbGVhbnVwIGluIG11c2JfY2xlYXJiL3coKSBhbmQKPiBtdXNiX2dl dC9zZXRfdG9nZ2xlKCkgaW1wbGVtZW50YXRpb24uIFBsZWFzZSBsZXQgbWUga25vdyBpZiBpdCBp cyBub3QKPiBjbGVhci4KPiAKPiBCYXNpY2FsbHksIHdlIGRvbid0IG5lZWQgbXVzYl9kZWZhdWx0 X2NsZWFyYi93KCksIGp1c3QgYXNzaWduIHRoZQo+IG11c2JfaW8gZnVuY3Rpb24gcG9pbnRlcnMg dG8gbXVzYl9yZWFkYi93KCkuCj4gCj4gVGhlbiB0aGUgbXRrIHBsYXRmb3JtIG11c2JfY2xlYXJi L3coKSBjYWxscyBtdXNiX3JlYWRiL3coKSBhbmQKPiBtdXNiX3dyaXRlYi93KCkgdG8gaGFuZGxl IFcxQy4KClNvcnJ5IHRvIGJvdGhlciB5b3UgYWdhaW4sIEkgZW5jb3VudGVyIGEgcHJvYmxlbSB3 aGVuIHByZXBhcmUgdGhlIHBhdGNoLgpUaGUgZGVmaW5lIG9mIG11c2JfY2xlYXJiL3cgYW5kIG11 c2JfcmVhZGIvdyBhcmUgZGlmZmVyZW5jZSBhcyBmb2xsb3csCmFuZCBjYW5ub3QgYmUgZGlyZWN0 bHkgYXNzaWduZWQ6CnU4L3UxNiAoKnJlYWRiL3cpKGNvbnN0IHZvaWQgX19pb21lbSAqYWRkciwg dW5zaWduZWQgb2Zmc2V0KQp2b2lkICgqY2xlYXJiL3cpKHZvaWQgX19pb21lbSAqYWRkciwgdW5z aWduZWQgaW50IG9mZnNldCkpIAoKaWYgbW9kaWZ5IGNsZWFyYi93IGFzOgp1OC91MTYgKCpjbGVh cmIvdykoY29uc3Qgdm9pZCBfX2lvbWVtICphZGRyLCB1bnNpZ25lZCBpbnQgb2Zmc2V0KSkgCnRo ZW4gbXVzYl9jbGVhciBuZWVkcyB3cml0ZWIvdyB0aGUgY29uc3QgYWRkci4KQ2FuIEkgZGVsZXRl IGNvbnN0IGluICgqcmVhZGIvdyk/Cgo+IHJlZ2FyZHMsCj4gLUJpbi4K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 428CCC43387 for ; Wed, 16 Jan 2019 09:39:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1153120840 for ; Wed, 16 Jan 2019 09:39:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="VE5ft43z" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1153120840 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mafzf/KO4Rl/1B209yktSCeUD68yUckodppluJllv7E=; b=VE5ft43zVnZaO4 AM0Q5K+dk9Pf2LOiI8h/+PCnBTlsvZWXn5htlTZ3005Z2CMJnQi7lzc9LbWnd/D3X/91R5A6KEuA2 AF81c0UpY8VA9N0HTXg4CZGEhhEozuUZPq5xmba2f3Hw+UdV8nSzqzyrBflQ5t+rqzlpwRQDXw6yY Jl+UAPSY/e/SG79VUNuGj/GnTSVr8dO7OXOuavF6d1ocGtkvoPJ0oE+aMem3CXGCXxLZKDMla1N9b H9VpcZiWjwErjOXbCBjSsRBii+3C43zbZZOAxCywrbB3M029XFylooUc0f6aKAW3hkvzRsqsBhG40 TefmuIzBOdPqRokAShUQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gjhfZ-0005aB-K4; Wed, 16 Jan 2019 09:39:33 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gjhfG-0005Gf-9h; Wed, 16 Jan 2019 09:39:16 +0000 X-UUID: 9b0eb878327c4cb5b90d2898359db0a4-20190116 X-UUID: 9b0eb878327c4cb5b90d2898359db0a4-20190116 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1226075562; Wed, 16 Jan 2019 01:39:08 -0800 Received: from MTKMBS31N2.mediatek.inc (172.27.4.87) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 16 Jan 2019 01:39:06 -0800 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 16 Jan 2019 17:39:04 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Wed, 16 Jan 2019 17:39:02 +0800 Message-ID: <1547631542.4433.232.camel@mhfsdcap03> Subject: Re: [PATCH v2 4/4] usb: musb: Add support for MediaTek musb controller From: Min Guo To: Bin Liu Date: Wed, 16 Jan 2019 17:39:02 +0800 In-Reply-To: <20190115203815.GD18026@uda0271908> References: <1547516626-5084-1-git-send-email-min.guo@mediatek.com> <1547516626-5084-5-git-send-email-min.guo@mediatek.com> <20190115203815.GD18026@uda0271908> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190116_013914_807458_4A0EA676 X-CRM114-Status: GOOD ( 10.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Yonglong Wu , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Matthias Brugger , Rob Herring , Alan Stern , chunfeng.yun@mediatek.com, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Bin, On Tue, 2019-01-15 at 14:38 -0600, Bin Liu wrote: > Hi Min, > > very close, thanks. > Below I tried to explain a further cleanup in musb_clearb/w() and > musb_get/set_toggle() implementation. Please let me know if it is not > clear. > > Basically, we don't need musb_default_clearb/w(), just assign the > musb_io function pointers to musb_readb/w(). > > Then the mtk platform musb_clearb/w() calls musb_readb/w() and > musb_writeb/w() to handle W1C. Sorry to bother you again, I encounter a problem when prepare the patch. The define of musb_clearb/w and musb_readb/w are difference as follow, and cannot be directly assigned: u8/u16 (*readb/w)(const void __iomem *addr, unsigned offset) void (*clearb/w)(void __iomem *addr, unsigned int offset)) if modify clearb/w as: u8/u16 (*clearb/w)(const void __iomem *addr, unsigned int offset)) then musb_clear needs writeb/w the const addr. Can I delete const in (*readb/w)? > regards, > -Bin. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel