* [PATCH v2 net-next] net: sock: do not set sk_cookie in sk_clone_lock()
@ 2019-01-18 5:00 Yafang Shao
2019-01-19 18:35 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Yafang Shao @ 2019-01-18 5:00 UTC (permalink / raw)
To: davem, edumazet; +Cc: netdev, shaoyafang, Yafang Shao
The only call site of sk_clone_lock is in inet_csk_clone_lock,
and sk_cookie will be set there.
So we don't need to set sk_cookie in sk_clone_lock().
Reviewed-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: Yafang Shao <laoar.shao@gmail.com>
---
net/core/sock.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/core/sock.c b/net/core/sock.c
index f00902c..21e2a84 100644
--- a/net/core/sock.c
+++ b/net/core/sock.c
@@ -1726,7 +1726,6 @@ struct sock *sk_clone_lock(const struct sock *sk, const gfp_t priority)
newsk->sk_err_soft = 0;
newsk->sk_priority = 0;
newsk->sk_incoming_cpu = raw_smp_processor_id();
- atomic64_set(&newsk->sk_cookie, 0);
if (likely(newsk->sk_net_refcnt))
sock_inuse_add(sock_net(newsk), 1);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2 net-next] net: sock: do not set sk_cookie in sk_clone_lock()
2019-01-18 5:00 [PATCH v2 net-next] net: sock: do not set sk_cookie in sk_clone_lock() Yafang Shao
@ 2019-01-19 18:35 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-01-19 18:35 UTC (permalink / raw)
To: laoar.shao; +Cc: edumazet, netdev, shaoyafang
From: Yafang Shao <laoar.shao@gmail.com>
Date: Fri, 18 Jan 2019 13:00:51 +0800
> The only call site of sk_clone_lock is in inet_csk_clone_lock,
> and sk_cookie will be set there.
> So we don't need to set sk_cookie in sk_clone_lock().
>
> Reviewed-by: Eric Dumazet <edumazet@google.com>
> Signed-off-by: Yafang Shao <laoar.shao@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-19 18:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-18 5:00 [PATCH v2 net-next] net: sock: do not set sk_cookie in sk_clone_lock() Yafang Shao
2019-01-19 18:35 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.