From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0C05C43387 for ; Fri, 18 Jan 2019 08:48:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B2D6220855 for ; Fri, 18 Jan 2019 08:48:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727406AbfARIsO (ORCPT ); Fri, 18 Jan 2019 03:48:14 -0500 Received: from metis.ext.pengutronix.de ([85.220.165.71]:37213 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726302AbfARIsN (ORCPT ); Fri, 18 Jan 2019 03:48:13 -0500 Received: from kresse.hi.pengutronix.de ([2001:67c:670:100:1d::2a]) by metis.ext.pengutronix.de with esmtp (Exim 4.89) (envelope-from ) id 1gkPoy-0007kL-2d; Fri, 18 Jan 2019 09:48:12 +0100 Message-ID: <1547801291.2626.3.camel@pengutronix.de> Subject: Re: [PATCH 1/4] dt-binding: irq: imx-irqsteer: use irq number per channel instead of group number From: Lucas Stach To: Aisheng Dong , "linux-kernel@vger.kernel.org" Cc: "linux-arm-kernel@lists.infradead.org" , "shawnguo@kernel.org" , dl-linux-imx , "robh+dt@kernel.org" , "devicetree@vger.kernel.org" , "tglx@linutronix.de" , Marc Zyngier Date: Fri, 18 Jan 2019 09:48:11 +0100 In-Reply-To: <1547797668-30342-2-git-send-email-aisheng.dong@nxp.com> References: <1547797668-30342-1-git-send-email-aisheng.dong@nxp.com> <1547797668-30342-2-git-send-email-aisheng.dong@nxp.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::2a X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Freitag, den 18.01.2019, 07:53 +0000 schrieb Aisheng Dong: > Not all 64 interrupts may be used in one group. e.g. most irqsteer in > imx8qxp and imx8qm subsystems supports only 32 interrupts. > > As the IP integration parameters are Channel number and interrupts number, > let's use fsl,irqs-per-chan to represents how many interrupts supported > by this irqsteer channel. Sorry, but total NACK. I've got to great lengths with dumping the actually implemented register layout on i.MX8M and AFAICS the IRQs are always managed in groups of 64 IRQs, even if less than that are connected as input IRQs. This is what the actually present register set on i.MX8M tells us. Regards, Lucas > Cc: Marc Zyngier > > Cc: Rob Herring > > Cc: Lucas Stach > > Cc: Shawn Guo > Cc: devicetree@vger.kernel.org > > Signed-off-by: Dong Aisheng > --- >  .../devicetree/bindings/interrupt-controller/fsl,irqsteer.txt       | 6 +++--- >  1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt > index 45790ce..eaabcda 100644 > --- a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt > +++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt > @@ -16,8 +16,8 @@ Required properties: >  - #interrupt-cells: Specifies the number of cells needed to encode an >    interrupt source. The value must be 1. >  - fsl,channel: The output channel that all input IRQs should be steered into. > -- fsl,irq-groups: Number of IRQ groups managed by this controller instance. > -  Each group manages 64 input interrupts. > +- fsl,irqs-per-chan: Number of input interrupts per channel. Should be multiple of 32 > +  input interrupts and up to 512 interrupts. >   >  Example: >   > @@ -28,7 +28,7 @@ Example: > >   clocks = <&clk IMX8MQ_CLK_DISP_APB_ROOT>; > >   clock-names = "ipg"; > >   fsl,channel = <0>; > > - fsl,irq-groups = <1>; > > + fsl,irqs-per-chan= <64>; > >   interrupt-controller; > >   #interrupt-cells = <1>; > >   }; From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lucas Stach Subject: Re: [PATCH 1/4] dt-binding: irq: imx-irqsteer: use irq number per channel instead of group number Date: Fri, 18 Jan 2019 09:48:11 +0100 Message-ID: <1547801291.2626.3.camel@pengutronix.de> References: <1547797668-30342-1-git-send-email-aisheng.dong@nxp.com> <1547797668-30342-2-git-send-email-aisheng.dong@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <1547797668-30342-2-git-send-email-aisheng.dong@nxp.com> Sender: linux-kernel-owner@vger.kernel.org To: Aisheng Dong , "linux-kernel@vger.kernel.org" Cc: "linux-arm-kernel@lists.infradead.org" , "shawnguo@kernel.org" , dl-linux-imx , "robh+dt@kernel.org" , "devicetree@vger.kernel.org" , "tglx@linutronix.de" , Marc Zyngier List-Id: devicetree@vger.kernel.org Am Freitag, den 18.01.2019, 07:53 +0000 schrieb Aisheng Dong: > Not all 64 interrupts may be used in one group. e.g. most irqsteer in > imx8qxp and imx8qm subsystems supports only 32 interrupts. > > As the IP integration parameters are Channel number and interrupts number, > let's use fsl,irqs-per-chan to represents how many interrupts supported > by this irqsteer channel. Sorry, but total NACK. I've got to great lengths with dumping the actually implemented register layout on i.MX8M and AFAICS the IRQs are always managed in groups of 64 IRQs, even if less than that are connected as input IRQs. This is what the actually present register set on i.MX8M tells us. Regards, Lucas > Cc: Marc Zyngier > > Cc: Rob Herring > > Cc: Lucas Stach > > Cc: Shawn Guo > Cc: devicetree@vger.kernel.org > > Signed-off-by: Dong Aisheng > --- >  .../devicetree/bindings/interrupt-controller/fsl,irqsteer.txt       | 6 +++--- >  1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt > index 45790ce..eaabcda 100644 > --- a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt > +++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt > @@ -16,8 +16,8 @@ Required properties: >  - #interrupt-cells: Specifies the number of cells needed to encode an >    interrupt source. The value must be 1. >  - fsl,channel: The output channel that all input IRQs should be steered into. > -- fsl,irq-groups: Number of IRQ groups managed by this controller instance. > -  Each group manages 64 input interrupts. > +- fsl,irqs-per-chan: Number of input interrupts per channel. Should be multiple of 32 > +  input interrupts and up to 512 interrupts. >   >  Example: >   > @@ -28,7 +28,7 @@ Example: > >   clocks = <&clk IMX8MQ_CLK_DISP_APB_ROOT>; > >   clock-names = "ipg"; > >   fsl,channel = <0>; > > - fsl,irq-groups = <1>; > > + fsl,irqs-per-chan= <64>; > >   interrupt-controller; > >   #interrupt-cells = <1>; > >   }; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE9F4C43387 for ; Fri, 18 Jan 2019 08:48:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AD1AD20855 for ; Fri, 18 Jan 2019 08:48:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lQtC9kRU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AD1AD20855 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3cykw+u+phQBN5+yqwOxRwqBNi1rzNxAf6fPiXBPUds=; b=lQtC9kRU4M7Pgd 4UR/kSyfnLfR3tGZUg4RcojELX7JHi4Zay/ZQx/bnWj2l+p5Xsp5LJScfGKaAtgl/Od27pElmYQ42 vbUp3SJP6PxD1Ka7APhME2geV7ZdDXCadFVlfwFbohKykAATNnAJ5K0AluvvwD3LIYHnJ5TjlClCJ SCFJlPE5vKJAS95FklOBPhoJHjH/MwVxJoHg/lCsqBoFLRdJ+pvIHHX/tBGqibxwD3+GzVg7crxfP rC6BvV9mG2JKThs9FpGrNFfhM4HUkoWHbeVOZ8qfv4TGa4hzQOLCZD5I4h80eESpMqrpDa3omFgUw n1ibITd4mLeoGodqSi7w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gkPp6-0008EM-Lw; Fri, 18 Jan 2019 08:48:20 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gkPp3-0008Dh-0V for linux-arm-kernel@lists.infradead.org; Fri, 18 Jan 2019 08:48:18 +0000 Received: from kresse.hi.pengutronix.de ([2001:67c:670:100:1d::2a]) by metis.ext.pengutronix.de with esmtp (Exim 4.89) (envelope-from ) id 1gkPoy-0007kL-2d; Fri, 18 Jan 2019 09:48:12 +0100 Message-ID: <1547801291.2626.3.camel@pengutronix.de> Subject: Re: [PATCH 1/4] dt-binding: irq: imx-irqsteer: use irq number per channel instead of group number From: Lucas Stach To: Aisheng Dong , "linux-kernel@vger.kernel.org" Date: Fri, 18 Jan 2019 09:48:11 +0100 In-Reply-To: <1547797668-30342-2-git-send-email-aisheng.dong@nxp.com> References: <1547797668-30342-1-git-send-email-aisheng.dong@nxp.com> <1547797668-30342-2-git-send-email-aisheng.dong@nxp.com> X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::2a X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190118_004817_206647_DC661C07 X-CRM114-Status: GOOD ( 16.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , Marc Zyngier , "robh+dt@kernel.org" , dl-linux-imx , "tglx@linutronix.de" , "shawnguo@kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org QW0gRnJlaXRhZywgZGVuIDE4LjAxLjIwMTksIDA3OjUzICswMDAwIHNjaHJpZWIgQWlzaGVuZyBE b25nOgo+IE5vdCBhbGwgNjQgaW50ZXJydXB0cyBtYXkgYmUgdXNlZCBpbiBvbmUgZ3JvdXAuIGUu Zy4gbW9zdCBpcnFzdGVlciBpbgo+IGlteDhxeHAgYW5kIGlteDhxbSBzdWJzeXN0ZW1zIHN1cHBv cnRzIG9ubHkgMzIgaW50ZXJydXB0cy4KPiAKPiBBcyB0aGUgSVAgaW50ZWdyYXRpb24gcGFyYW1l dGVycyBhcmUgQ2hhbm5lbCBudW1iZXIgYW5kIGludGVycnVwdHMgbnVtYmVyLAo+IGxldCdzIHVz ZSBmc2wsaXJxcy1wZXItY2hhbiB0byByZXByZXNlbnRzIGhvdyBtYW55IGludGVycnVwdHMgc3Vw cG9ydGVkCj4gYnkgdGhpcyBpcnFzdGVlciBjaGFubmVsLgoKU29ycnksIGJ1dCB0b3RhbCBOQUNL LiBJJ3ZlIGdvdCB0byBncmVhdCBsZW5ndGhzIHdpdGggZHVtcGluZyB0aGUKYWN0dWFsbHkgaW1w bGVtZW50ZWQgcmVnaXN0ZXIgbGF5b3V0IG9uIGkuTVg4TSBhbmQgQUZBSUNTIHRoZSBJUlFzIGFy ZQphbHdheXMgbWFuYWdlZCBpbiBncm91cHMgb2YgNjQgSVJRcywgZXZlbiBpZiBsZXNzIHRoYW4g dGhhdCBhcmUKY29ubmVjdGVkIGFzIGlucHV0IElSUXMuIFRoaXMgaXMgd2hhdCB0aGUgYWN0dWFs bHkgcHJlc2VudCByZWdpc3RlciBzZXQKb24gaS5NWDhNIHRlbGxzIHVzLgoKUmVnYXJkcywKTHVj YXMKCj4gQ2M6IE1hcmMgWnluZ2llciA8bWFyYy56eW5naWVyQGFybS5jb20+Cj4gPiBDYzogUm9i IEhlcnJpbmcgPHJvYmgrZHRAa2VybmVsLm9yZz4KPiA+IENjOiBMdWNhcyBTdGFjaCA8bC5zdGFj aEBwZW5ndXRyb25peC5kZT4KPiA+IENjOiBTaGF3biBHdW8gPHNoYXduZ3VvQGtlcm5lbC5vcmc+ Cj4gQ2M6IGRldmljZXRyZWVAdmdlci5rZXJuZWwub3JnCj4gPiBTaWduZWQtb2ZmLWJ5OiBEb25n IEFpc2hlbmcgPGFpc2hlbmcuZG9uZ0BueHAuY29tPgo+IC0tLQo+IMKgLi4uL2RldmljZXRyZWUv YmluZGluZ3MvaW50ZXJydXB0LWNvbnRyb2xsZXIvZnNsLGlycXN0ZWVyLnR4dMKgwqDCoMKgwqDC oMKgfCA2ICsrKy0tLQo+IMKgMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwgMyBkZWxl dGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRp bmdzL2ludGVycnVwdC1jb250cm9sbGVyL2ZzbCxpcnFzdGVlci50eHQgYi9Eb2N1bWVudGF0aW9u L2RldmljZXRyZWUvYmluZGluZ3MvaW50ZXJydXB0LWNvbnRyb2xsZXIvZnNsLGlycXN0ZWVyLnR4 dAo+IGluZGV4IDQ1NzkwY2UuLmVhYWJjZGEgMTAwNjQ0Cj4gLS0tIGEvRG9jdW1lbnRhdGlvbi9k ZXZpY2V0cmVlL2JpbmRpbmdzL2ludGVycnVwdC1jb250cm9sbGVyL2ZzbCxpcnFzdGVlci50eHQK PiArKysgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvaW50ZXJydXB0LWNvbnRy b2xsZXIvZnNsLGlycXN0ZWVyLnR4dAo+IEBAIC0xNiw4ICsxNiw4IEBAIFJlcXVpcmVkIHByb3Bl cnRpZXM6Cj4gwqAtICNpbnRlcnJ1cHQtY2VsbHM6IFNwZWNpZmllcyB0aGUgbnVtYmVyIG9mIGNl bGxzIG5lZWRlZCB0byBlbmNvZGUgYW4KPiDCoMKgwqBpbnRlcnJ1cHQgc291cmNlLiBUaGUgdmFs dWUgbXVzdCBiZSAxLgo+IMKgLSBmc2wsY2hhbm5lbDogVGhlIG91dHB1dCBjaGFubmVsIHRoYXQg YWxsIGlucHV0IElSUXMgc2hvdWxkIGJlIHN0ZWVyZWQgaW50by4KPiAtLSBmc2wsaXJxLWdyb3Vw czogTnVtYmVyIG9mIElSUSBncm91cHMgbWFuYWdlZCBieSB0aGlzIGNvbnRyb2xsZXIgaW5zdGFu Y2UuCj4gLcKgwqBFYWNoIGdyb3VwIG1hbmFnZXMgNjQgaW5wdXQgaW50ZXJydXB0cy4KPiArLSBm c2wsaXJxcy1wZXItY2hhbjogTnVtYmVyIG9mIGlucHV0IGludGVycnVwdHMgcGVyIGNoYW5uZWwu IFNob3VsZCBiZSBtdWx0aXBsZSBvZiAzMgo+ICvCoMKgaW5wdXQgaW50ZXJydXB0cyBhbmQgdXAg dG8gNTEyIGludGVycnVwdHMuCj4gwqAKPiDCoEV4YW1wbGU6Cj4gwqAKPiBAQCAtMjgsNyArMjgs NyBAQCBFeGFtcGxlOgo+ID4gwqAJCWNsb2NrcyA9IDwmY2xrIElNWDhNUV9DTEtfRElTUF9BUEJf Uk9PVD47Cj4gPiDCoAkJY2xvY2stbmFtZXMgPSAiaXBnIjsKPiA+IMKgCQlmc2wsY2hhbm5lbCA9 IDwwPjsKPiA+IC0JCWZzbCxpcnEtZ3JvdXBzID0gPDE+Owo+ID4gKwkJZnNsLGlycXMtcGVyLWNo YW49IDw2ND47Cj4gPiDCoAkJaW50ZXJydXB0LWNvbnRyb2xsZXI7Cj4gPiDCoAkJI2ludGVycnVw dC1jZWxscyA9IDwxPjsKPiA+IMKgCX07CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0t a2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFp bG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==