From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xen.org>
Cc: "Juergen Gross" <jgross@suse.com>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Wei Liu" <wei.liu2@citrix.com>,
"Jan Beulich" <JBeulich@suse.com>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: [PATCH 1/3] x86/pvh-dom0: Remove unnecessary function pointer call from modify_identity_mmio()
Date: Mon, 21 Jan 2019 15:37:19 +0000 [thread overview]
Message-ID: <1548085041-23786-2-git-send-email-andrew.cooper3@citrix.com> (raw)
In-Reply-To: <1548085041-23786-1-git-send-email-andrew.cooper3@citrix.com>
Function pointer calls are far more expensive in a post-Spectre world, and
this one doesn't need to be.
No functional change.
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Wei Liu <wei.liu2@citrix.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Juergen Gross <jgross@suse.com>
---
xen/arch/x86/hvm/dom0_build.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/xen/arch/x86/hvm/dom0_build.c b/xen/arch/x86/hvm/dom0_build.c
index 303c44b..51cf490 100644
--- a/xen/arch/x86/hvm/dom0_build.c
+++ b/xen/arch/x86/hvm/dom0_build.c
@@ -79,8 +79,8 @@ static int __init modify_identity_mmio(struct domain *d, unsigned long pfn,
for ( ; ; )
{
- rc = (map ? map_mmio_regions : unmap_mmio_regions)
- (d, _gfn(pfn), nr_pages, _mfn(pfn));
+ rc = map ? map_mmio_regions(d, _gfn(pfn), nr_pages, _mfn(pfn))
+ : unmap_mmio_regions(d, _gfn(pfn), nr_pages, _mfn(pfn));
if ( rc == 0 )
break;
if ( rc < 0 )
--
2.1.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-01-21 15:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-21 15:37 [PATCH for-4.12 0/3] x86/pvh: Misc fixes and cleanup Andrew Cooper
2019-01-21 15:37 ` Andrew Cooper [this message]
2019-01-21 15:52 ` [PATCH 1/3] x86/pvh-dom0: Remove unnecessary function pointer call from modify_identity_mmio() Wei Liu
2019-01-23 11:22 ` Jan Beulich
2019-01-21 15:37 ` [PATCH 2/3] x86/pvh: Fixes to convert_pvh_info() Andrew Cooper
2019-01-21 15:52 ` Wei Liu
2019-01-21 15:54 ` Andrew Cooper
2019-01-23 11:35 ` Jan Beulich
2019-01-29 20:43 ` Andrew Cooper
2019-01-30 9:46 ` Jan Beulich
2019-01-21 15:37 ` [PATCH 3/3] x86/pvh: Print the PVH start info more concisely Andrew Cooper
2019-01-21 15:53 ` Wei Liu
2019-01-23 11:42 ` Jan Beulich
2019-01-23 12:26 ` Andrew Cooper
2019-01-23 11:27 ` [PATCH for-4.12 0/3] x86/pvh: Misc fixes and cleanup Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1548085041-23786-2-git-send-email-andrew.cooper3@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=jgross@suse.com \
--cc=roger.pau@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.