* [PATCH 0/2] scsi: trivial header search path fixups
@ 2019-01-25 7:09 Masahiro Yamada
2019-01-25 7:09 ` [PATCH 1/2] scsi: remove unneeded header search paths Masahiro Yamada
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Masahiro Yamada @ 2019-01-25 7:09 UTC (permalink / raw)
To: James E . J . Bottomley, Martin K . Petersen, linux-scsi
Cc: Masahiro Yamada, Don Brace, esc.storagedev, Hannes Reinecke,
linux-kernel, Adaptec OEM Raid Solutions
My main motivation is to get rid of crappy header search path manipulation
from Kbuild core.
Before that, I want to do as many treewide cleanups as possible.
The full work of this is available at:
git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git build-test
Masahiro Yamada (2):
scsi: remove unneeded header search paths
scsi: prefix header search paths with $(srctree)/
drivers/scsi/aacraid/Makefile | 2 --
drivers/scsi/aic7xxx/Makefile | 1 -
drivers/scsi/cxgbi/Makefile | 2 +-
drivers/scsi/pcmcia/Makefile | 2 +-
drivers/scsi/smartpqi/Makefile | 1 -
5 files changed, 2 insertions(+), 6 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/2] scsi: remove unneeded header search paths
2019-01-25 7:09 [PATCH 0/2] scsi: trivial header search path fixups Masahiro Yamada
@ 2019-01-25 7:09 ` Masahiro Yamada
2019-01-25 7:09 ` [PATCH 2/2] scsi: prefix header search paths with $(srctree)/ Masahiro Yamada
2019-01-29 6:24 ` [PATCH 0/2] scsi: trivial header search path fixups Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Masahiro Yamada @ 2019-01-25 7:09 UTC (permalink / raw)
To: James E . J . Bottomley, Martin K . Petersen, linux-scsi
Cc: Masahiro Yamada, Don Brace, esc.storagedev, Hannes Reinecke,
linux-kernel, Adaptec OEM Raid Solutions
I was able to build without these extra header search paths.
Especially, the header search path -I. in kernel Makefiles is always
suspicious; it allows the compiler to search for headers in the top
of $(srctree), where obviously no header file exists.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
drivers/scsi/aacraid/Makefile | 2 --
drivers/scsi/aic7xxx/Makefile | 1 -
drivers/scsi/smartpqi/Makefile | 1 -
3 files changed, 4 deletions(-)
diff --git a/drivers/scsi/aacraid/Makefile b/drivers/scsi/aacraid/Makefile
index 1bd9fd1..3893b95 100644
--- a/drivers/scsi/aacraid/Makefile
+++ b/drivers/scsi/aacraid/Makefile
@@ -4,5 +4,3 @@ obj-$(CONFIG_SCSI_AACRAID) := aacraid.o
aacraid-objs := linit.o aachba.o commctrl.o comminit.o commsup.o \
dpcsup.o rx.o sa.o rkt.o nark.o src.o
-
-ccflags-y := -Idrivers/scsi
diff --git a/drivers/scsi/aic7xxx/Makefile b/drivers/scsi/aic7xxx/Makefile
index c15be25..e0188ec 100644
--- a/drivers/scsi/aic7xxx/Makefile
+++ b/drivers/scsi/aic7xxx/Makefile
@@ -34,7 +34,6 @@ aic79xx-y += aic79xx_osm.o \
aic79xx_proc.o \
aic79xx_osm_pci.o
-ccflags-y += -Idrivers/scsi
ifdef WARNINGS_BECOME_ERRORS
ccflags-y += -Werror
endif
diff --git a/drivers/scsi/smartpqi/Makefile b/drivers/scsi/smartpqi/Makefile
index e6b7799..a03a6ed 100644
--- a/drivers/scsi/smartpqi/Makefile
+++ b/drivers/scsi/smartpqi/Makefile
@@ -1,3 +1,2 @@
-ccflags-y += -I.
obj-$(CONFIG_SCSI_SMARTPQI) += smartpqi.o
smartpqi-objs := smartpqi_init.o smartpqi_sis.o smartpqi_sas_transport.o
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] scsi: prefix header search paths with $(srctree)/
2019-01-25 7:09 [PATCH 0/2] scsi: trivial header search path fixups Masahiro Yamada
2019-01-25 7:09 ` [PATCH 1/2] scsi: remove unneeded header search paths Masahiro Yamada
@ 2019-01-25 7:09 ` Masahiro Yamada
2019-01-29 6:24 ` [PATCH 0/2] scsi: trivial header search path fixups Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Masahiro Yamada @ 2019-01-25 7:09 UTC (permalink / raw)
To: James E . J . Bottomley, Martin K . Petersen, linux-scsi
Cc: Masahiro Yamada, linux-kernel
Currently, the Kbuild core manipulates header search paths in a crazy
way [1].
To fix this mess, I want all Makefiles to add explicit $(srctree)/ to
the search paths in the srctree. Some Makefiles are already written in
that way, but not all. The goal of this work is to make the notation
consistent, and finally get rid of the gross hacks.
Having whitespaces after -I does not matter since commit 48f6e3cf5bc6
("kbuild: do not drop -I without parameter").
[1]: https://patchwork.kernel.org/patch/9632347/
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
drivers/scsi/cxgbi/Makefile | 2 +-
drivers/scsi/pcmcia/Makefile | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/cxgbi/Makefile b/drivers/scsi/cxgbi/Makefile
index a73781a..f78c9cc 100644
--- a/drivers/scsi/cxgbi/Makefile
+++ b/drivers/scsi/cxgbi/Makefile
@@ -1,4 +1,4 @@
-ccflags-y += -Idrivers/net/ethernet/chelsio/libcxgb
+ccflags-y += -I $(srctree)/drivers/net/ethernet/chelsio/libcxgb
obj-$(CONFIG_SCSI_CXGB3_ISCSI) += libcxgbi.o cxgb3i/
obj-$(CONFIG_SCSI_CXGB4_ISCSI) += libcxgbi.o cxgb4i/
diff --git a/drivers/scsi/pcmcia/Makefile b/drivers/scsi/pcmcia/Makefile
index faa87a4..a5a24dd 100644
--- a/drivers/scsi/pcmcia/Makefile
+++ b/drivers/scsi/pcmcia/Makefile
@@ -1,6 +1,6 @@
# SPDX-License-Identifier: GPL-2.0
-ccflags-y := -Idrivers/scsi
+ccflags-y := -I $(srctree)/drivers/scsi
# 16-bit client drivers
obj-$(CONFIG_PCMCIA_QLOGIC) += qlogic_cs.o
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 0/2] scsi: trivial header search path fixups
2019-01-25 7:09 [PATCH 0/2] scsi: trivial header search path fixups Masahiro Yamada
2019-01-25 7:09 ` [PATCH 1/2] scsi: remove unneeded header search paths Masahiro Yamada
2019-01-25 7:09 ` [PATCH 2/2] scsi: prefix header search paths with $(srctree)/ Masahiro Yamada
@ 2019-01-29 6:24 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2019-01-29 6:24 UTC (permalink / raw)
To: Masahiro Yamada
Cc: James E . J . Bottomley, Martin K . Petersen, linux-scsi,
Don Brace, esc.storagedev, Hannes Reinecke, linux-kernel,
Adaptec OEM Raid Solutions
Masahiro,
> My main motivation is to get rid of crappy header search path manipulation
> from Kbuild core.
>
> Before that, I want to do as many treewide cleanups as possible.
Applied to 5.1/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-01-29 6:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-25 7:09 [PATCH 0/2] scsi: trivial header search path fixups Masahiro Yamada
2019-01-25 7:09 ` [PATCH 1/2] scsi: remove unneeded header search paths Masahiro Yamada
2019-01-25 7:09 ` [PATCH 2/2] scsi: prefix header search paths with $(srctree)/ Masahiro Yamada
2019-01-29 6:24 ` [PATCH 0/2] scsi: trivial header search path fixups Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.