All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 4/6] net: phy: ar803x: Explicitly disable RGMII delays
Date: Sat, 26 Jan 2019 00:40:39 +0000	[thread overview]
Message-ID: <1548463214-18159-5-git-send-email-vladimir.oltean@nxp.com> (raw)
In-Reply-To: <1548463214-18159-1-git-send-email-vladimir.oltean@nxp.com>

To eliminate any doubts about the out-of-reset value of the PHY, that
the driver previously relied on.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
Changes in v3:
 * Patch added in this version.

 drivers/net/phy/atheros.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/net/phy/atheros.c b/drivers/net/phy/atheros.c
index 72e7fac..02aa61f 100644
--- a/drivers/net/phy/atheros.c
+++ b/drivers/net/phy/atheros.c
@@ -82,10 +82,14 @@ static int ar8031_config(struct phy_device *phydev)
 	if (phydev->interface == PHY_INTERFACE_MODE_RGMII_TXID ||
 	    phydev->interface == PHY_INTERFACE_MODE_RGMII_ID)
 		ar803x_enable_tx_delay(phydev, true);
+	else
+		ar803x_enable_tx_delay(phydev, false);
 
 	if (phydev->interface == PHY_INTERFACE_MODE_RGMII_RXID ||
 	    phydev->interface == PHY_INTERFACE_MODE_RGMII_ID)
 		ar803x_enable_rx_delay(phydev, true);
+	else
+		ar803x_enable_rx_delay(phydev, false);
 
 	phydev->supported = phydev->drv->features;
 
@@ -113,10 +117,14 @@ static int ar8035_config(struct phy_device *phydev)
 	if ((phydev->interface == PHY_INTERFACE_MODE_RGMII_ID) ||
 	    (phydev->interface == PHY_INTERFACE_MODE_RGMII_TXID))
 		ar803x_enable_tx_delay(phydev, true);
+	else
+		ar803x_enable_tx_delay(phydev, false);
 
 	if ((phydev->interface == PHY_INTERFACE_MODE_RGMII_ID) ||
 	    (phydev->interface == PHY_INTERFACE_MODE_RGMII_RXID))
 		ar803x_enable_rx_delay(phydev, true);
+	else
+		ar803x_enable_rx_delay(phydev, false);
 
 	phydev->supported = phydev->drv->features;
 
-- 
2.7.4

  parent reply	other threads:[~2019-01-26  0:40 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-26  0:40 [U-Boot] [PATCH v3 0/6] net: phy: Allow disabling SmartEEE for Atheros PHYs Vladimir Oltean
2019-01-26  0:40 ` [U-Boot] [PATCH v3 1/6] net: phy: ar803x: Address packet drops at low traffic rate due to SmartEEE feature Vladimir Oltean
2019-03-05 18:04   ` [U-Boot] " Joe Hershberger
2019-01-26  0:40 ` [U-Boot] [PATCH v3 2/6] net: phy: ar803x: Make RGMII Tx delays actually configurable for AR8035 Vladimir Oltean
2019-02-04 22:53   ` Joe Hershberger
2019-03-05 18:04   ` [U-Boot] " Joe Hershberger
2019-01-26  0:40 ` [U-Boot] [PATCH v3 3/6] net: phy: ar803x: Use common functions for RGMII internal delays Vladimir Oltean
2019-02-04 23:02   ` Joe Hershberger
2019-03-05 18:04   ` [U-Boot] " Joe Hershberger
2019-01-26  0:40 ` [U-Boot] [PATCH v3 5/6] net: phy: ar803x: Clarify the configuration of the CLK_25M output pin Vladimir Oltean
2019-02-04 23:09   ` Joe Hershberger
2019-03-05 18:04   ` [U-Boot] " Joe Hershberger
2019-01-26  0:40 ` Vladimir Oltean [this message]
2019-02-04 23:03   ` [U-Boot] [PATCH v3 4/6] net: phy: ar803x: Explicitly disable RGMII delays Joe Hershberger
2019-03-05 18:04   ` [U-Boot] " Joe Hershberger
2019-01-26  0:40 ` [U-Boot] [PATCH v3 6/6] net: phy: ar803x: Clarify the intention of ar8021_config Vladimir Oltean
2019-02-04 23:18   ` Joe Hershberger
2019-03-05 18:04   ` [U-Boot] " Joe Hershberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1548463214-18159-5-git-send-email-vladimir.oltean@nxp.com \
    --to=vladimir.oltean@nxp.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.