All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Intel-gfx@lists.freedesktop.org,
	Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Subject: Re: [PATCH 1/5] drm/i915: Record the sseu configuration per-context & engine
Date: Wed, 30 Jan 2019 09:40:46 +0000	[thread overview]
Message-ID: <154884124149.21797.10552168318721416480@skylake-alporthouse-com> (raw)
In-Reply-To: <20190130093416.3513-2-tvrtko.ursulin@linux.intel.com>

Quoting Tvrtko Ursulin (2019-01-30 09:34:12)
> diff --git a/drivers/gpu/drm/i915/i915_request.h b/drivers/gpu/drm/i915/i915_request.h
> index 3cffb96203b9..ecef6256dd24 100644
> --- a/drivers/gpu/drm/i915/i915_request.h
> +++ b/drivers/gpu/drm/i915/i915_request.h
> @@ -38,6 +38,16 @@ struct drm_i915_gem_object;
>  struct i915_request;
>  struct i915_timeline;
>  
> +/*
> + * Powergating configuration for a particular (context,engine).
> + */
> +struct intel_sseu {
> +       u8 slice_mask;
> +       u8 subslice_mask;
> +       u8 min_eus_per_subslice;
> +       u8 max_eus_per_subslice;
> +};

Was there a reason why it ended up here? I noticed when I splitting out
the intel_context into its own header. It doesn't matter in this series,
just wondering if I broke a good rationale :)
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2019-01-30  9:41 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-30  9:34 [PATCH 0/5] Per context dynamic (sub)slice power-gating Tvrtko Ursulin
2019-01-30  9:34 ` [PATCH 1/5] drm/i915: Record the sseu configuration per-context & engine Tvrtko Ursulin
2019-01-30  9:40   ` Chris Wilson [this message]
2019-01-30  9:56     ` Tvrtko Ursulin
2019-01-30 10:14   ` [PATCH v16 " Tvrtko Ursulin
2019-01-30  9:34 ` [PATCH 2/5] drm/i915/perf: lock powergating configuration to default when active Tvrtko Ursulin
2019-01-30  9:34 ` [PATCH 3/5] drm/i915: Add timeline barrier support Tvrtko Ursulin
2019-01-30  9:34 ` [PATCH 4/5] drm/i915: Expose RPCS (SSEU) configuration to userspace (Gen11 only) Tvrtko Ursulin
2019-01-30  9:45   ` Chris Wilson
2019-01-30  9:59     ` Tvrtko Ursulin
2019-01-30 10:15   ` [PATCH v29 " Tvrtko Ursulin
2019-01-31  8:47     ` [PATCH v30 " Tvrtko Ursulin
2019-01-31  9:15       ` Chris Wilson
2019-01-31  9:34         ` Tvrtko Ursulin
2019-01-31 10:47       ` [PATCH v31 " Tvrtko Ursulin
2019-01-31 10:59         ` Chris Wilson
2019-01-31 11:46         ` Joonas Lahtinen
2019-01-30  9:34 ` [PATCH 5/5] drm/i915/selftests: Context SSEU reconfiguration tests Tvrtko Ursulin
2019-01-30  9:47 ` ✗ Fi.CI.CHECKPATCH: warning for Per context dynamic (sub)slice power-gating (rev21) Patchwork
2019-01-30  9:50 ` ✗ Fi.CI.SPARSE: " Patchwork
2019-01-30 10:12 ` ✓ Fi.CI.BAT: success " Patchwork
2019-01-30 11:12 ` ✗ Fi.CI.CHECKPATCH: warning for Per context dynamic (sub)slice power-gating (rev23) Patchwork
2019-01-30 11:15 ` ✗ Fi.CI.SPARSE: " Patchwork
2019-01-30 11:31 ` ✗ Fi.CI.IGT: failure for Per context dynamic (sub)slice power-gating (rev21) Patchwork
2019-01-30 11:45 ` ✓ Fi.CI.BAT: success for Per context dynamic (sub)slice power-gating (rev23) Patchwork
2019-01-30 13:12 ` ✗ Fi.CI.CHECKPATCH: warning for Per context dynamic (sub)slice power-gating (rev24) Patchwork
2019-01-30 13:15 ` ✗ Fi.CI.SPARSE: " Patchwork
2019-01-30 13:34 ` ✓ Fi.CI.BAT: success " Patchwork
2019-01-30 13:52 ` ✗ Fi.CI.CHECKPATCH: warning for Per context dynamic (sub)slice power-gating (rev25) Patchwork
2019-01-30 13:55 ` ✗ Fi.CI.SPARSE: " Patchwork
2019-01-30 14:14 ` ✗ Fi.CI.BAT: failure " Patchwork
2019-01-30 16:23 ` ✗ Fi.CI.CHECKPATCH: warning for Per context dynamic (sub)slice power-gating (rev26) Patchwork
2019-01-30 16:26 ` ✗ Fi.CI.SPARSE: " Patchwork
2019-01-30 16:45 ` ✓ Fi.CI.BAT: success " Patchwork
2019-01-30 20:51 ` ✓ Fi.CI.IGT: " Patchwork
2019-01-31  7:25   ` Tvrtko Ursulin
2019-01-31  7:30     ` Chris Wilson
2019-01-31  8:26 ` ✗ Fi.CI.CHECKPATCH: warning for Per context dynamic (sub)slice power-gating (rev27) Patchwork
2019-01-31  8:29 ` ✗ Fi.CI.SPARSE: " Patchwork
2019-01-31  8:48 ` ✓ Fi.CI.BAT: success " Patchwork
2019-01-31  9:49 ` ✗ Fi.CI.CHECKPATCH: warning for Per context dynamic (sub)slice power-gating (rev28) Patchwork
2019-01-31  9:51 ` ✗ Fi.CI.SPARSE: " Patchwork
2019-01-31 10:14 ` ✓ Fi.CI.BAT: success " Patchwork
2019-01-31 11:11 ` ✗ Fi.CI.CHECKPATCH: warning for Per context dynamic (sub)slice power-gating (rev29) Patchwork
2019-01-31 11:14 ` ✗ Fi.CI.SPARSE: " Patchwork
2019-01-31 11:32 ` ✓ Fi.CI.BAT: success " Patchwork
2019-01-31 21:49 ` ✓ Fi.CI.IGT: " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2019-01-25 15:24 [PATCH 0/5] Per context dynamic (sub)slice power-gating Tvrtko Ursulin
2019-01-25 15:24 ` [PATCH 1/5] drm/i915: Record the sseu configuration per-context & engine Tvrtko Ursulin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=154884124149.21797.10552168318721416480@skylake-alporthouse-com \
    --to=chris@chris-wilson.co.uk \
    --cc=Intel-gfx@lists.freedesktop.org \
    --cc=tvrtko.ursulin@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.