From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A57A5C282D7 for ; Wed, 30 Jan 2019 13:41:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 803A020855 for ; Wed, 30 Jan 2019 13:41:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726332AbfA3Nle (ORCPT ); Wed, 30 Jan 2019 08:41:34 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:42738 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726233AbfA3Nle (ORCPT ); Wed, 30 Jan 2019 08:41:34 -0500 Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x0UDYbAs023539 for ; Wed, 30 Jan 2019 08:41:32 -0500 Received: from e06smtp07.uk.ibm.com (e06smtp07.uk.ibm.com [195.75.94.103]) by mx0a-001b2d01.pphosted.com with ESMTP id 2qbaykxjbe-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 30 Jan 2019 08:41:31 -0500 Received: from localhost by e06smtp07.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 30 Jan 2019 13:41:28 -0000 Received: from b06cxnps4076.portsmouth.uk.ibm.com (9.149.109.198) by e06smtp07.uk.ibm.com (192.168.101.137) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Wed, 30 Jan 2019 13:41:25 -0000 Received: from b06wcsmtp001.portsmouth.uk.ibm.com (b06wcsmtp001.portsmouth.uk.ibm.com [9.149.105.160]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x0UDfOsY39845980 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 30 Jan 2019 13:41:24 GMT Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A3A41A405F; Wed, 30 Jan 2019 13:41:24 +0000 (GMT) Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D403EA4054; Wed, 30 Jan 2019 13:41:23 +0000 (GMT) Received: from localhost.localdomain (unknown [9.80.91.219]) by b06wcsmtp001.portsmouth.uk.ibm.com (Postfix) with ESMTP; Wed, 30 Jan 2019 13:41:23 +0000 (GMT) Subject: Re: [PATCH] ima-evm-utils: remove redundant call to OpenSSL_add_all_algorithms From: Mimi Zohar To: Vitaly Chikunov Cc: Mimi Zohar , Dmitry Kasatkin , linux-integrity@vger.kernel.org, "Bruno E. O. Meneguele" , Petr Vorel Date: Wed, 30 Jan 2019 08:41:13 -0500 In-Reply-To: <20190130132521.edhtrv54labxlbyc@altlinux.org> References: <20190127023916.2425-1-vt@altlinux.org> <1548851697.20210.91.camel@linux.ibm.com> <20190130132521.edhtrv54labxlbyc@altlinux.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 (3.20.5-1.fc24) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 19013013-0028-0000-0000-00000340D27A X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19013013-0029-0000-0000-000023FDDA10 Message-Id: <1548855673.20210.102.camel@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-01-30_10:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1901300109 Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org [Cc'ing Bruno, Petr] On Wed, 2019-01-30 at 16:25 +0300, Vitaly Chikunov wrote: > On Wed, Jan 30, 2019 at 07:34:57AM -0500, Mimi Zohar wrote: > > On Sun, 2019-01-27 at 05:39 +0300, Vitaly Chikunov wrote: > > > Because of call to OPENSSL_add_all_algorithms_conf() calling > > > OpenSSL_add_all_algorithms() is not needed. There was not be any > > > problems though because double initialization is permitted. > > > --- > > > src/libimaevm.c | 1 - > > > 1 file changed, 1 deletion(-) > > > > > > diff --git a/src/libimaevm.c b/src/libimaevm.c > > > index 7501303..b038d0c 100644 > > > --- a/src/libimaevm.c > > > +++ b/src/libimaevm.c > > > @@ -995,7 +995,6 @@ int sign_hash(const char *hashalgo, const unsigned char *hash, int size, const c > > > > > > static void libinit() > > > { > > > - OpenSSL_add_all_algorithms(); > > > OPENSSL_add_all_algorithms_conf(); > > > ERR_load_crypto_strings(); > > > } > > > > The only difference between the two calls seems to be reading the > > system openssl.cnf file.  In the original call that is dependent on > > OPENSSL_LOAD_CONF being defined.  Calling > > OPENSSL_add_all_algorithms_conf(), forces reading the system > > openssl.cnf. > > Yes. OPENSSL_LOAD_CONF is per application define, which is by default > undefined. And instead of defining it, we could just call > OPENSSL_add_all_algorithms_conf(), which is required for GOST support. > Otherwise enabling Streebog via OPENSSL_CONF will not work. I think this is basically a packaging question.  Instead of hard coding this change, it could be an autoconf option (eg. enable/disable-gost). Bruno, Petr, any preference? Thanks, Mimi