Re: [Qemu-devel] [PATCH] linux-user: fix emulation of accept4/getpeername/getsockname/recvfrom syscalls

[no-reply@patchew.org]

Patchew URL: https://patchew.org/QEMU/mvmh8dt3vrp.fsf@suse.de/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH] linux-user: fix emulation of accept4/getpeername/getsockname/recvfrom syscalls
Type: series
Message-id: mvmh8dt3vrp.fsf@suse.de

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
ca8c625f2b linux-user: fix emulation of accept4/getpeername/getsockname/recvfrom syscalls

=== OUTPUT BEGIN ===
ERROR: braces {} are necessary for all arms of this statement
#41: FILE: linux-user/syscall.c:2877:
+        if (put_user_u32(ret_addrlen, target_addrlen_addr))
[...]

ERROR: braces {} are necessary for all arms of this statement
#65: FILE: linux-user/syscall.c:2907:
+        if (put_user_u32(ret_addrlen, target_addrlen_addr))
[...]

ERROR: braces {} are necessary for all arms of this statement
#89: FILE: linux-user/syscall.c:2937:
+        if (put_user_u32(ret_addrlen, target_addrlen_addr))
[...]

total: 3 errors, 0 warnings, 98 lines checked

Commit ca8c625f2b00 (linux-user: fix emulation of accept4/getpeername/getsockname/recvfrom syscalls) has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/mvmh8dt3vrp.fsf@suse.de/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com