Re: [Qemu-devel] [PULL 0/8] NBD patches for 2019-02-04

[no-reply@patchew.org]

Patchew URL: https://patchew.org/QEMU/20190205035704.26014-1-eblake@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20190205035704.26014-1-eblake@redhat.com
Subject: [Qemu-devel] [PULL 0/8] NBD patches for 2019-02-04
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/1549336101-17623-1-git-send-email-thuth@redhat.com -> patchew/1549336101-17623-1-git-send-email-thuth@redhat.com
 - [tag update]      patchew/20190204204517.23698-1-philmd@redhat.com -> patchew/20190204204517.23698-1-philmd@redhat.com
 * [new tag]         patchew/20190205035704.26014-1-eblake@redhat.com -> patchew/20190205035704.26014-1-eblake@redhat.com
Switched to a new branch 'test'
9f22048 block/nbd-client: rename read_reply_co to connection_co
e81ab27 block/nbd-client: don't check ioc
ce55b4b block/nbd-client: fix nbd_reply_chunk_iter_receive
80c093f block/nbd-client: split connection from initialization
a24543e block/nbd: move connection code from block/nbd to block/nbd-client
467a28d block/nbd-client: split channel errors from export errors
bd906b0 nbd: generalize usage of nbd_read
3d3be1f qemu-nbd: Deprecate qemu-nbd --partition

=== OUTPUT BEGIN ===
1/8 Checking commit 3d3be1f9bcc8 (qemu-nbd: Deprecate qemu-nbd --partition)
2/8 Checking commit bd906b01ffe8 (nbd: generalize usage of nbd_read)
ERROR: spaces required around that '*' (ctx:WxV)
#85: FILE: include/block/nbd.h:356:
+                                 uint##bits##_t *val,                   \
                                                 ^

total: 1 errors, 0 warnings, 386 lines checked

Patch 2/8 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/8 Checking commit 467a28dbf261 (block/nbd-client: split channel errors from export errors)
4/8 Checking commit a24543ee7b41 (block/nbd: move connection code from block/nbd to block/nbd-client)
5/8 Checking commit 80c093f3b180 (block/nbd-client: split connection from initialization)
6/8 Checking commit ce55b4b331f9 (block/nbd-client: fix nbd_reply_chunk_iter_receive)
7/8 Checking commit e81ab27f828e (block/nbd-client: don't check ioc)
8/8 Checking commit 9f22048c0a07 (block/nbd-client: rename read_reply_co to connection_co)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190205035704.26014-1-eblake@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com