From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3C01C282CB for ; Tue, 5 Feb 2019 16:01:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 534F42080F for ; Tue, 5 Feb 2019 16:01:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="fRyEZpxv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730204AbfBEQB3 (ORCPT ); Tue, 5 Feb 2019 11:01:29 -0500 Received: from m12-12.163.com ([220.181.12.12]:57565 "EHLO m12-12.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729118AbfBEQB2 (ORCPT ); Tue, 5 Feb 2019 11:01:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=5Ffe5J8cgq/aUuFbLh 0w3StsYPrcEZLZHlkB53LqOCk=; b=fRyEZpxv5URe1G9sj7yoCx4D8pAZSBM4pd zcRsWC8DrcjGBdiLOaGdR1zi4970d9r6GbXiUBe8JfVGMkEi1cfvLx7hwQ7G7oiP dLQTAq7O2go0jy0mchZ2jcfab6nd3QAZYCh1L5G9XXugnjYcm8pEwKM+rCJJC/2P RR5azSj5w= Received: from localhost.localdomain (unknown [171.210.152.198]) by smtp8 (Coremail) with SMTP id DMCowAB3CMhCs1lc2rxiEQ--.19630S3; Wed, 06 Feb 2019 00:01:08 +0800 (CST) From: Yang Wei To: netdev@vger.kernel.org Cc: macro@linux-mips.org, davem@davemloft.net, yang.wei9@zte.com.cn, albin_yang@163.com Subject: [PATCH net] net: defxx: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles Date: Wed, 6 Feb 2019 00:01:04 +0800 Message-Id: <1549382464-5138-1-git-send-email-albin_yang@163.com> X-Mailer: git-send-email 2.7.4 X-CM-TRANSID: DMCowAB3CMhCs1lc2rxiEQ--.19630S3 X-Coremail-Antispam: 1Uf129KBjvdXoWrtrWDKF4Uur4fJF1Dtr4kXrb_yoW3KFg_W3 Wjq3ZrZws0kr9IyrsFyFnYyryS9a4UZr4kurySgay5Z34jyw1DXFZ7Grn0kr93Ww4rXFnr KasFgF4DZryftjkaLaAFLSUrUUUU8b8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU0znmJUUUUU== X-Originating-IP: [171.210.152.198] X-CM-SenderInfo: pdoex0xb1d0wi6rwjhhfrp/1tbiqwRSolUMOAmLfgAAsC Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Yang Wei dev_consume_skb_irq() should be called in dfx_xmt_done() when skb xmit done. It makes drop profiles(dropwatch, perf) more friendly. Signed-off-by: Yang Wei --- drivers/net/fddi/defxx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/fddi/defxx.c b/drivers/net/fddi/defxx.c index 38ac8ef..56b7791 100644 --- a/drivers/net/fddi/defxx.c +++ b/drivers/net/fddi/defxx.c @@ -3512,7 +3512,7 @@ static int dfx_xmt_done(DFX_board_t *bp) bp->descr_block_virt->xmt_data[comp].long_1, p_xmt_drv_descr->p_skb->len, DMA_TO_DEVICE); - dev_kfree_skb_irq(p_xmt_drv_descr->p_skb); + dev_consume_skb_irq(p_xmt_drv_descr->p_skb); /* * Move to start of next packet by updating completion index -- 2.7.4