Re: [Qemu-devel] [PATCH v6 00/51] Support Kconfig in QEMU

[no-reply@patchew.org]

Patchew URL: https://patchew.org/QEMU/1549562254-41157-1-git-send-email-pbonzini@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH v6 00/51] Support Kconfig in QEMU
Type: series
Message-id: 1549562254-41157-1-git-send-email-pbonzini@redhat.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
93b682d47a FIXME vhost: add more stubs
a680cbcdd4 .travis.yml: test that no-default-device builds do not regress
cc20b7d742 xtensa-softmmu.mak: express dependencies with Kconfig
4c76d60e72 unicore32-softmmu.mak: express dependencies with Kconfig
8b1a2a062a sparc64-softmmu.mak: express dependencies with Kconfig
f793fdb000 sparc-softmmu.mak: express dependencies with Kconfig
7818fa31ae sh4-softmmu.mak: express dependencies with Kconfig
3c21174903 s390x: express dependencies with Kconfig
5fec60ab42 or1k-softmmu.mak: express dependencies with Kconfig
8935c96d83 nios2-softmmu.mak: express dependencies with Kconfig
1d6c5fce70 moxie-softmmu.mak: express dependencies with Kconfig
11526a8d82 microblaze-softmmu.mak: express dependencies with Kconfig
6df43a7964 m68k-softmmu.mak: express dependencies with Kconfig
cd790311a0 lm32-softmmu.mak: express dependencies with Kconfig
590c6d7ee0 hppa-softmmu.mak: express dependencies with Kconfig
36cbe4512a cris-softmmu.mak: express dependencies with Kconfig
c0cd646ca5 alpha-softmmu.mak: express dependencies with Kconfig
6e35550c42 ppc: Express dependencies of the embedded machines with kconfig
ae2bd5b51d ppc: Express dependencies of the Sam460EX machines with kconfig
60bb2e0d9b ppc: Express dependencies of the Mac machines with kconfig
cf8ea0c0e8 ppc: Express dependencies of the 'prep' and '40p' machines with kconfig
93a603ffb1 ppc64: Express dependencies of 'pseries' and 'powernv' machines with kconfig
2822ebf95e i386-softmmu.mak: remove all CONFIG_* except boards definitions
db3747cb76 ipmi: express dependencies with kconfig
ca1cfdc1c9 sd: express dependencies with kconfig
82ee5e5ac5 ssi: express dependencies with kconfig
0d5d1a4505 isa: express SuperIO dependencies with Kconfig
544527ca12 tpm: express dependencies with Kconfig
cb5c04b9b9 virtio: express virtio dependencies with Kconfig
e4395d9fa3 vfio: express vfio dependencies with Kconfig
7fabf6c407 hyperv: express dependencies with kconfig
43c36b4f58 display: express dependencies with kconfig
c5adaaac9b ptimer: express dependencies with Kconfig
140aadc9a3 i2c: express dependencies with Kconfig
192e864c27 i386: express dependencies with Kconfig
85489ef70e isa: express dependencies with kconfig
99b3ea362b scsi: express dependencies with Kconfig
b0e9cf2004 block: fix recursion in hw/block/dataplane
c68b0736c9 build: convert usb.mak to Kconfig
8b145f086b build: convert sound.mak to Kconfig
1b95de09b9 build: convert pci.mak to Kconfig
4af86cca3a hw/pci/Makefile.objs: make pcie configurable
2e3edb8704 ide: express dependencies with Kconfig
f7bef1a446 kconfig: introduce CONFIG_TEST_DEVICES
07a8e8887f minikconfig: implement allnoconfig and defconfig modes
fb806e7b4c build: switch to Kconfig
a95f7d77ea kconfig: introduce kconfig files
1a214f85cd hw/display: make edid configurable
5a8f973a47 minikconfig: add semantic analysis
b5c153b336 minikconfig: add AST
bff54501a3 minikconfig: add parser skeleton

=== OUTPUT BEGIN ===
1/51 Checking commit bff54501a325 (minikconfig: add parser skeleton)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#36: 
new file mode 100644

WARNING: line over 80 characters
#260: FILE: scripts/minikconf.py:220:
+                           'Expected identifier starting with "CONFIG_"', TOK_NONE)

WARNING: line over 80 characters
#359: FILE: scripts/minikconf.py:319:
+            raise KconfigParserError(self, 'expected "source", "config", identifier, '

WARNING: line over 80 characters
#385: FILE: scripts/minikconf.py:345:
+            raise KconfigParserError(self, 'expected "source", "config" or identifier')

ERROR: line over 90 characters
#410: FILE: scripts/minikconf.py:370:
+        if self.src[self.cursor + length].isalnum() or self.src[self.cursor + length] == '|':

WARNING: line over 80 characters
#465: FILE: scripts/minikconf.py:425:
+            while self.src[self.cursor].isalnum() or self.src[self.cursor] == '_':

total: 1 errors, 5 warnings, 441 lines checked

Patch 1/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/51 Checking commit b5c153b336bc (minikconfig: add AST)
WARNING: line over 80 characters
#90: FILE: scripts/minikconf.py:90:
+                return "config %s default %s if %s" % (self.dest, value, self.cond)

total: 0 errors, 1 warnings, 177 lines checked

Patch 2/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/51 Checking commit 5a8f973a474b (minikconfig: add semantic analysis)
ERROR: line over 90 characters
#113: FILE: scripts/minikconf.py:106:
+                raise KconfigParserError('contradiction between clauses when setting %s' % self)

WARNING: line over 80 characters
#216: FILE: scripts/minikconf.py:218:
+            debug_print(i, "->", [str(x) for x in self.referenced_vars[i].outgoing])

total: 1 errors, 1 warnings, 235 lines checked

Patch 3/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/51 Checking commit 1a214f85cdc5 (hw/display: make edid configurable)
5/51 Checking commit a95f7d77eaa6 (kconfig: introduce kconfig files)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#45: 
new file mode 100644

WARNING: line over 80 characters
#1754: FILE: scripts/minikconf.py:653:
+        print ("%s: at least one argument is required" % argv[0], file=sys.stderr)

total: 0 errors, 2 warnings, 1354 lines checked

Patch 5/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/51 Checking commit fb806e7b4c22 (build: switch to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#505: 
deleted file mode 100644

total: 0 errors, 1 warnings, 346 lines checked

Patch 6/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/51 Checking commit 07a8e8887f8f (minikconfig: implement allnoconfig and defconfig modes)
8/51 Checking commit f7bef1a4465c (kconfig: introduce CONFIG_TEST_DEVICES)
9/51 Checking commit 2e3edb87047c (ide: express dependencies with Kconfig)
10/51 Checking commit 4af86cca3ac9 (hw/pci/Makefile.objs: make pcie configurable)
11/51 Checking commit 1b95de09b99d (build: convert pci.mak to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#146: 
deleted file mode 100644

total: 0 errors, 1 warnings, 490 lines checked

Patch 11/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/51 Checking commit 8b145f086b06 (build: convert sound.mak to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#69: 
deleted file mode 100644

total: 0 errors, 1 warnings, 49 lines checked

Patch 12/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
13/51 Checking commit c68b0736c930 (build: convert usb.mak to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#159: 
deleted file mode 100644

total: 0 errors, 1 warnings, 165 lines checked

Patch 13/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
14/51 Checking commit b0e9cf200479 (block: fix recursion in hw/block/dataplane)
15/51 Checking commit 99b3ea362b48 (scsi: express dependencies with Kconfig)
16/51 Checking commit 85489ef70ed6 (isa: express dependencies with kconfig)
17/51 Checking commit 192e864c272e (i386: express dependencies with Kconfig)
18/51 Checking commit 140aadc9a3b0 (i2c: express dependencies with Kconfig)
19/51 Checking commit c5adaaac9bf3 (ptimer: express dependencies with Kconfig)
20/51 Checking commit 43c36b4f580c (display: express dependencies with kconfig)
21/51 Checking commit 7fabf6c407db (hyperv: express dependencies with kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#18: 
deleted file mode 100644

total: 0 errors, 1 warnings, 21 lines checked

Patch 21/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
22/51 Checking commit e4395d9fa320 (vfio: express vfio dependencies with Kconfig)
23/51 Checking commit cb5c04b9b9a6 (virtio: express virtio dependencies with Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38: 
deleted file mode 100644

total: 0 errors, 1 warnings, 104 lines checked

Patch 23/51 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
24/51 Checking commit 544527ca12b3 (tpm: express dependencies with Kconfig)
25/51 Checking commit 0d5d1a45050c (isa: express SuperIO dependencies with Kconfig)
26/51 Checking commit 82ee5e5ac54f (ssi: express dependencies with kconfig)
27/51 Checking commit ca1cfdc1c94d (sd: express dependencies with kconfig)
28/51 Checking commit db3747cb76b5 (ipmi: express dependencies with kconfig)
29/51 Checking commit 2822ebf95eae (i386-softmmu.mak: remove all CONFIG_* except boards definitions)
30/51 Checking commit 93a603ffb1f9 (ppc64: Express dependencies of 'pseries' and 'powernv' machines with kconfig)
31/51 Checking commit cf8ea0c0e8bb (ppc: Express dependencies of the 'prep' and '40p' machines with kconfig)
32/51 Checking commit 60bb2e0d9b9d (ppc: Express dependencies of the Mac machines with kconfig)
33/51 Checking commit ae2bd5b51dc8 (ppc: Express dependencies of the Sam460EX machines with kconfig)
34/51 Checking commit 6e35550c423c (ppc: Express dependencies of the embedded machines with kconfig)
35/51 Checking commit c0cd646ca528 (alpha-softmmu.mak: express dependencies with Kconfig)
36/51 Checking commit 36cbe4512aa8 (cris-softmmu.mak: express dependencies with Kconfig)
37/51 Checking commit 590c6d7ee0a4 (hppa-softmmu.mak: express dependencies with Kconfig)
38/51 Checking commit cd790311a0a8 (lm32-softmmu.mak: express dependencies with Kconfig)
39/51 Checking commit 6df43a796440 (m68k-softmmu.mak: express dependencies with Kconfig)
40/51 Checking commit 11526a8d824c (microblaze-softmmu.mak: express dependencies with Kconfig)
41/51 Checking commit 1d6c5fce702d (moxie-softmmu.mak: express dependencies with Kconfig)
42/51 Checking commit 8935c96d830f (nios2-softmmu.mak: express dependencies with Kconfig)
43/51 Checking commit 5fec60ab4271 (or1k-softmmu.mak: express dependencies with Kconfig)
44/51 Checking commit 3c211749036b (s390x: express dependencies with Kconfig)
45/51 Checking commit 7818fa31aef9 (sh4-softmmu.mak: express dependencies with Kconfig)
46/51 Checking commit f793fdb00094 (sparc-softmmu.mak: express dependencies with Kconfig)
47/51 Checking commit 8b1a2a062a57 (sparc64-softmmu.mak: express dependencies with Kconfig)
48/51 Checking commit 4c76d60e7289 (unicore32-softmmu.mak: express dependencies with Kconfig)
49/51 Checking commit cc20b7d742e3 (xtensa-softmmu.mak: express dependencies with Kconfig)
50/51 Checking commit a680cbcdd4e2 (.travis.yml: test that no-default-device builds do not regress)
51/51 Checking commit 93b682d47aba (FIXME vhost: add more stubs)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/1549562254-41157-1-git-send-email-pbonzini@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com