From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C672C169C4 for ; Mon, 11 Feb 2019 16:13:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4600520700 for ; Mon, 11 Feb 2019 16:13:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732269AbfBKQNF (ORCPT ); Mon, 11 Feb 2019 11:13:05 -0500 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:37394 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727799AbfBKQM7 (ORCPT ); Mon, 11 Feb 2019 11:12:59 -0500 Received: from pps.filterd (m0046037.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x1BG89Ce026964; Mon, 11 Feb 2019 17:12:46 +0100 Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 2qhurhu1dh-1 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 11 Feb 2019 17:12:46 +0100 Received: from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id ABE2D31; Mon, 11 Feb 2019 16:12:44 +0000 (GMT) Received: from Webmail-eu.st.com (sfhdag5node3.st.com [10.75.127.15]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id C8E9751C1; Mon, 11 Feb 2019 16:12:43 +0000 (GMT) Received: from localhost (10.75.127.49) by SFHDAG5NODE3.st.com (10.75.127.15) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Mon, 11 Feb 2019 17:12:43 +0100 From: Fabrice Gasnier To: , CC: , , , , , , , , , , Subject: [PATCH v2 3/3] pwm: core: add consumer device link Date: Mon, 11 Feb 2019 17:12:02 +0100 Message-ID: <1549901522-15071-4-git-send-email-fabrice.gasnier@st.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1549901522-15071-1-git-send-email-fabrice.gasnier@st.com> References: <1549901522-15071-1-git-send-email-fabrice.gasnier@st.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.75.127.49] X-ClientProxiedBy: SFHDAG6NODE1.st.com (10.75.127.16) To SFHDAG5NODE3.st.com (10.75.127.15) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-02-11_10:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add a device link between the PWM consumer and the PWM provider. This enforces the PWM user to get suspended before the PWM provider. It allows proper synchronization of suspend/resume sequences: the PWM user is responsible for properly stopping PWM, before the provider gets suspended: see [1]. Add the device link in: - pwm_get() - devm_pwm_get() - devm_of_pwm_get() as it requires a reference to the device for the PWM consumer. [1] https://lkml.org/lkml/2019/2/5/770 Suggested-by: Thierry Reding Signed-off-by: Fabrice Gasnier --- drivers/pwm/core.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c index 1581f6a..2835e27 100644 --- a/drivers/pwm/core.c +++ b/drivers/pwm/core.c @@ -770,8 +770,13 @@ struct pwm_device *pwm_get(struct device *dev, const char *con_id) int err; /* look up via DT first */ - if (IS_ENABLED(CONFIG_OF) && dev && dev->of_node) - return of_pwm_get(dev->of_node, con_id); + if (IS_ENABLED(CONFIG_OF) && dev && dev->of_node) { + pwm = of_pwm_get(dev->of_node, con_id); + if (!IS_ERR(pwm)) + device_link_add(dev, pwm->chip->dev, + DL_FLAG_AUTOREMOVE_CONSUMER); + return pwm; + } /* * We look up the provider in the static table typically provided by @@ -851,6 +856,8 @@ struct pwm_device *pwm_get(struct device *dev, const char *con_id) pwm->args.period = chosen->period; pwm->args.polarity = chosen->polarity; + device_link_add(dev, pwm->chip->dev, DL_FLAG_AUTOREMOVE_CONSUMER); + return pwm; } EXPORT_SYMBOL_GPL(pwm_get); @@ -943,6 +950,8 @@ struct pwm_device *devm_of_pwm_get(struct device *dev, struct device_node *np, if (!IS_ERR(pwm)) { *ptr = pwm; devres_add(dev, ptr); + device_link_add(dev, pwm->chip->dev, + DL_FLAG_AUTOREMOVE_CONSUMER); } else { devres_free(ptr); } -- 1.9.1 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fabrice Gasnier Subject: [PATCH v2 3/3] pwm: core: add consumer device link Date: Mon, 11 Feb 2019 17:12:02 +0100 Message-ID: <1549901522-15071-4-git-send-email-fabrice.gasnier@st.com> References: <1549901522-15071-1-git-send-email-fabrice.gasnier@st.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <1549901522-15071-1-git-send-email-fabrice.gasnier@st.com> Sender: linux-kernel-owner@vger.kernel.org To: thierry.reding@gmail.com, robh+dt@kernel.org Cc: u.kleine-koenig@pengutronix.de, tduszyns@gmail.com, mark.rutland@arm.com, alexandre.torgue@st.com, mcoquelin.stm32@gmail.com, fabrice.gasnier@st.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com List-Id: devicetree@vger.kernel.org Add a device link between the PWM consumer and the PWM provider. This enforces the PWM user to get suspended before the PWM provider. It allows proper synchronization of suspend/resume sequences: the PWM user is responsible for properly stopping PWM, before the provider gets suspended: see [1]. Add the device link in: - pwm_get() - devm_pwm_get() - devm_of_pwm_get() as it requires a reference to the device for the PWM consumer. [1] https://lkml.org/lkml/2019/2/5/770 Suggested-by: Thierry Reding Signed-off-by: Fabrice Gasnier --- drivers/pwm/core.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c index 1581f6a..2835e27 100644 --- a/drivers/pwm/core.c +++ b/drivers/pwm/core.c @@ -770,8 +770,13 @@ struct pwm_device *pwm_get(struct device *dev, const char *con_id) int err; /* look up via DT first */ - if (IS_ENABLED(CONFIG_OF) && dev && dev->of_node) - return of_pwm_get(dev->of_node, con_id); + if (IS_ENABLED(CONFIG_OF) && dev && dev->of_node) { + pwm = of_pwm_get(dev->of_node, con_id); + if (!IS_ERR(pwm)) + device_link_add(dev, pwm->chip->dev, + DL_FLAG_AUTOREMOVE_CONSUMER); + return pwm; + } /* * We look up the provider in the static table typically provided by @@ -851,6 +856,8 @@ struct pwm_device *pwm_get(struct device *dev, const char *con_id) pwm->args.period = chosen->period; pwm->args.polarity = chosen->polarity; + device_link_add(dev, pwm->chip->dev, DL_FLAG_AUTOREMOVE_CONSUMER); + return pwm; } EXPORT_SYMBOL_GPL(pwm_get); @@ -943,6 +950,8 @@ struct pwm_device *devm_of_pwm_get(struct device *dev, struct device_node *np, if (!IS_ERR(pwm)) { *ptr = pwm; devres_add(dev, ptr); + device_link_add(dev, pwm->chip->dev, + DL_FLAG_AUTOREMOVE_CONSUMER); } else { devres_free(ptr); } -- 1.9.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48252C169C4 for ; Mon, 11 Feb 2019 16:13:40 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0410221B1C for ; Mon, 11 Feb 2019 16:13:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SiP/9lnf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0410221B1C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=st.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=r4BWf4eQLQXsZxfnhpjijtgocTvNPsrxOmo3prnjsdE=; b=SiP/9lnfGkfSY/ WWZSzA6JUbG+GootG555beNkuevT1RqCKoGTmOL+t7cAvDzXS0vTKt1Bxkx5O3EkftmAa3r9TAMkK H6w6UPZKnuP8LGkhxjjejFYJezYCIFeULKweJuDe0AoT7BVW97rPFYk9bq6/W6k2L7AMVHo/4vT1U +j4bQGeQvBgEfTer1VtMEBU23US0MJIU/1ciICIExcdFQsBloMo/Dbap1D0dhEfdtHJGyjPz8xB98 VKPXABx2vMIIDZRq+x3LoLrq2GBiulyP08GFNnLvo+o4pALvAUF7CxCXlHX6SpX19IjfaCcIymp8V 3qBCYEnP+JPkT6dxkU7g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gtED8-00038Q-MM; Mon, 11 Feb 2019 16:13:34 +0000 Received: from mx07-00178001.pphosted.com ([62.209.51.94]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gtECR-0002Sj-Nf for linux-arm-kernel@lists.infradead.org; Mon, 11 Feb 2019 16:12:55 +0000 Received: from pps.filterd (m0046037.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x1BG89Ce026964; Mon, 11 Feb 2019 17:12:46 +0100 Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 2qhurhu1dh-1 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 11 Feb 2019 17:12:46 +0100 Received: from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id ABE2D31; Mon, 11 Feb 2019 16:12:44 +0000 (GMT) Received: from Webmail-eu.st.com (sfhdag5node3.st.com [10.75.127.15]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id C8E9751C1; Mon, 11 Feb 2019 16:12:43 +0000 (GMT) Received: from localhost (10.75.127.49) by SFHDAG5NODE3.st.com (10.75.127.15) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Mon, 11 Feb 2019 17:12:43 +0100 From: Fabrice Gasnier To: , Subject: [PATCH v2 3/3] pwm: core: add consumer device link Date: Mon, 11 Feb 2019 17:12:02 +0100 Message-ID: <1549901522-15071-4-git-send-email-fabrice.gasnier@st.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1549901522-15071-1-git-send-email-fabrice.gasnier@st.com> References: <1549901522-15071-1-git-send-email-fabrice.gasnier@st.com> MIME-Version: 1.0 X-Originating-IP: [10.75.127.49] X-ClientProxiedBy: SFHDAG6NODE1.st.com (10.75.127.16) To SFHDAG5NODE3.st.com (10.75.127.15) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-02-11_10:, , signatures=0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190211_081252_262858_353E9BF0 X-CRM114-Status: GOOD ( 13.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, alexandre.torgue@st.com, tduszyns@gmail.com, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, mcoquelin.stm32@gmail.com, u.kleine-koenig@pengutronix.de, fabrice.gasnier@st.com, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Add a device link between the PWM consumer and the PWM provider. This enforces the PWM user to get suspended before the PWM provider. It allows proper synchronization of suspend/resume sequences: the PWM user is responsible for properly stopping PWM, before the provider gets suspended: see [1]. Add the device link in: - pwm_get() - devm_pwm_get() - devm_of_pwm_get() as it requires a reference to the device for the PWM consumer. [1] https://lkml.org/lkml/2019/2/5/770 Suggested-by: Thierry Reding Signed-off-by: Fabrice Gasnier --- drivers/pwm/core.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c index 1581f6a..2835e27 100644 --- a/drivers/pwm/core.c +++ b/drivers/pwm/core.c @@ -770,8 +770,13 @@ struct pwm_device *pwm_get(struct device *dev, const char *con_id) int err; /* look up via DT first */ - if (IS_ENABLED(CONFIG_OF) && dev && dev->of_node) - return of_pwm_get(dev->of_node, con_id); + if (IS_ENABLED(CONFIG_OF) && dev && dev->of_node) { + pwm = of_pwm_get(dev->of_node, con_id); + if (!IS_ERR(pwm)) + device_link_add(dev, pwm->chip->dev, + DL_FLAG_AUTOREMOVE_CONSUMER); + return pwm; + } /* * We look up the provider in the static table typically provided by @@ -851,6 +856,8 @@ struct pwm_device *pwm_get(struct device *dev, const char *con_id) pwm->args.period = chosen->period; pwm->args.polarity = chosen->polarity; + device_link_add(dev, pwm->chip->dev, DL_FLAG_AUTOREMOVE_CONSUMER); + return pwm; } EXPORT_SYMBOL_GPL(pwm_get); @@ -943,6 +950,8 @@ struct pwm_device *devm_of_pwm_get(struct device *dev, struct device_node *np, if (!IS_ERR(pwm)) { *ptr = pwm; devres_add(dev, ptr); + device_link_add(dev, pwm->chip->dev, + DL_FLAG_AUTOREMOVE_CONSUMER); } else { devres_free(ptr); } -- 1.9.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel