From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192]) by gabe.freedesktop.org (Postfix) with ESMTPS id 46FF76E04D for ; Mon, 11 Feb 2019 23:01:35 +0000 (UTC) MIME-Version: 1.0 From: Chris Wilson In-Reply-To: <20190211223825.GV23159@phenom.ffwll.local> References: <20190211180208.29406-1-daniel.vetter@ffwll.ch> <20190211180208.29406-3-daniel.vetter@ffwll.ch> <154991899170.15715.1631719136617848704@skylake-alporthouse-com> <20190211223825.GV23159@phenom.ffwll.local> Message-ID: <154992607608.14378.13727024411543835857@skylake-alporthouse-com> Date: Mon, 11 Feb 2019 23:01:16 +0000 Subject: Re: [igt-dev] [PATCH i-g-t 3/9] lib: Don't leak children in igt_waitchildren_timeout List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Daniel Vetter Cc: IGT development , Daniel Vetter List-ID: UXVvdGluZyBEYW5pZWwgVmV0dGVyICgyMDE5LTAyLTExIDIyOjM4OjI1KQo+IE9uIE1vbiwgRmVi IDExLCAyMDE5IGF0IDA5OjAzOjEyUE0gKzAwMDAsIENocmlzIFdpbHNvbiB3cm90ZToKPiA+IFF1 b3RpbmcgRGFuaWVsIFZldHRlciAoMjAxOS0wMi0xMSAxODowMjowMikKPiA+ID4gSW5zdGVhZCBv ZiBjbGVhbmluZyB1cCB0aGUgbWVzcyBpbiBpZ3RfZXhpdCBtYWtlIHN1cmUgd2UgZG9uJ3QgZXZl bgo+ID4gPiBsZXQgaXQgb3V0IG9mIHRoZSBjb250YWluZXIuIFNlZSBhbHNvCj4gPiA+IAo+ID4g PiBjb21taXQgNzU0ODc2Mzc4ZDZjOWIyNzc1ZThjMDdiNGQxNmY5ODc4YzU1OTQ5Zgo+ID4gPiBB dXRob3I6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+ID4gPiBEYXRl OiAgIEZyaSBGZWIgMjYgMjI6MTE6MTAgMjAxNiArMDAwMAo+ID4gPiAKPiA+ID4gICAgIGlndC9n ZW1fc3luYzogRW5mb3JjZSBhIHRpbWVvdXQgb2YgMjBzCj4gPiA+IAo+ID4gPiB3aGljaCBhZGRl ZCB0aGlzIGhlbHBlci4KPiA+ID4gCj4gPiA+IFRvIG1ha2Ugc3VyZSB0aGF0IGV2ZXJ5b25lIGZv bGxvd3MgdGhlIHJ1bGVzLCBhZGQgYW4gYXNzZXJ0Lgo+ID4gPiAKPiA+ID4gV2UncmUga2VlcGlu ZyB0aGUgY2xlYW51cCBjb2RlIGFzIGEgZmFpbHNhZmUsIGFuZCBiZWNhdXNlIGl0IHNwZWVkcwo+ ID4gPiB1cCB0aGUgdGVzdGNhc2UgSSdtIGZvbGxvd2luZyB1cCB3aXRoLgo+ID4gPiAKPiA+ID4g djI6IENocmlzIHBvaW50ZWQgb3V0IHRoYXQgbXkgb3JpZ2luYWwgcGF0Y2ggZGlkIG5vdGhpbmcu IFdoaWNoIEkKPiA+ID4gZGlkbid0IGNhdGNoIGJlY2F1c2UgbXkgdGVzdGNhc2Ugd2FzIGFsc28g YnJva2VuLiBVbmZvcnR1bmF0ZWx5IHRoaXMKPiA+ID4gbWVhbnMgd2UgbmVlZCB0byBvcGVuIGNv ZGUgcGFydCBvZiB0aGUgd2FpdGluZy4KPiA+ID4gCj4gPiA+IENjOiBDaHJpcyBXaWxzb24gPGNo cmlzQGNocmlzLXdpbHNvbi5jby51az4KPiA+ID4gU2lnbmVkLW9mZi1ieTogRGFuaWVsIFZldHRl ciA8ZGFuaWVsLnZldHRlckBpbnRlbC5jb20+Cj4gPiA+IC0tLQo+ID4gPiAgbGliL2lndF9jb3Jl LmMgfCAzOSArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0KPiA+ID4gIDEg ZmlsZSBjaGFuZ2VkLCAzNCBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQo+ID4gPiAKPiA+ ID4gZGlmZiAtLWdpdCBhL2xpYi9pZ3RfY29yZS5jIGIvbGliL2lndF9jb3JlLmMKPiA+ID4gaW5k ZXggY2JiZTc5Zjg4MDcwLi4zMDUzNjk3ZGE1OGMgMTAwNjQ0Cj4gPiA+IC0tLSBhL2xpYi9pZ3Rf Y29yZS5jCj4gPiA+ICsrKyBiL2xpYi9pZ3RfY29yZS5jCj4gPiA+IEBAIC0xNTI1LDYgKzE1MjUs NyBAQCB2b2lkIGlndF9leGl0KHZvaWQpCj4gPiA+ICAKPiA+ID4gICAgICAgICBmb3IgKGludCBj ID0gMDsgYyA8IG51bV90ZXN0X2NoaWxkcmVuOyBjKyspCj4gPiA+ICAgICAgICAgICAgICAgICBr aWxsKHRlc3RfY2hpbGRyZW5bY10sIFNJR0tJTEwpOwo+ID4gPiArICAgICAgIGFzc2VydCghbnVt X3Rlc3RfY2hpbGRyZW4pOwo+ID4gPiAgCj4gPiA+ICAgICAgICAgaWYgKCF0ZXN0X3dpdGhfc3Vi dGVzdHMpIHsKPiA+ID4gICAgICAgICAgICAgICAgIHN0cnVjdCB0aW1lc3BlYyBub3c7Cj4gPiA+ IEBAIC0xODMyLDIwICsxODMzLDQ4IEBAIHZvaWQgaWd0X3dhaXRjaGlsZHJlbih2b2lkKQo+ID4g PiAgICAgICAgICAgICAgICAgaWd0X2ZhaWwoZXJyKTsKPiA+ID4gIH0KPiA+ID4gIAo+ID4gPiAr c3RhdGljIGJvb2wgaWd0X2tpbGxjaGlkcmVuX3RpbWVkX291dDsKPiA+ID4gKwo+ID4gPiArc3Rh dGljIHZvaWQgaWd0X2FsYXJtX2tpbGxjaGlsZHJlbihpbnQgc2lnbmFsKQo+ID4gPiArewo+ID4g PiArICAgICAgIGlndF9pbmZvKCJUaW1lZCBvdXQgd2FpdGluZyBmb3IgY2hpbGRyZW5cbiIpOwo+ ID4gCj4gPiBXZSB1c2VkIHRvIHByaW50IHRoZSBjYWxsZXIgc3VwcGxpZWQgcmVhc29uLiBBbHRo b3VnaCB0aGF0IGFwcGVhcnMgdG8KPiA+IGhhdmUgbmV2ZXIgYmVlbiB1c2VkLCBzbyBtaWdodCBh cyB3ZWxsIGRyb3AgaXQgZnJvbSB0aGUgQVBJLgo+ID4gCj4gPiA+ICsKPiA+ID4gKyAgICAgICBp Z3Rfa2lsbGNoaWRyZW5fdGltZWRfb3V0ID0gdHJ1ZTsKPiA+ID4gKwo+ID4gPiArICAgICAgIGZv ciAoaW50IGMgPSAwOyBjIDwgbnVtX3Rlc3RfY2hpbGRyZW47IGMrKykKPiA+ID4gKyAgICAgICAg ICAgICAgIGtpbGwodGVzdF9jaGlsZHJlbltjXSwgU0lHS0lMTCk7Cj4gPiAKPiA+IE9rLCBraWxs KCkgaXMgc2lnbmFsLXNhZmUuCj4gPiAKPiA+ID4gK30KPiA+ID4gKwo+ID4gPiAgLyoqCj4gPiA+ ICAgKiBpZ3Rfd2FpdGNoaWxkcmVuX3RpbWVvdXQ6Cj4gPiA+ICAgKiBAc2Vjb25kczogdGltZW91 dCBpbiBzZWNvbmRzIHRvIHdhaXQKPiA+ID4gICAqIEByZWFzb246IGRlYnVnIHN0cmluZyBleHBs YWluaW5nIHdoYXQgdGltZWRvdXQKPiA+ID4gICAqCj4gPiA+IC0gKiBXYWl0IGZvciBhbGwgY2hp bGRyZW4gZm9ya2VkIHdpdGggaWd0X2ZvcmssIGZvciBhIG1heGltdW0gb2YgQHNlY29uZHMuCj4g PiA+IC0gKgo+ID4gPiAtICogV3JhcHMgaWd0X3dhaXRjaGlsZHJlbigpIGFuZCBpZ3Rfc2V0X3Rp bWVvdXQoKQo+ID4gPiArICogV2FpdCBmb3IgYWxsIGNoaWxkcmVuIGZvcmtlZCB3aXRoIGlndF9m b3JrLCBmb3IgYSBtYXhpbXVtIG9mIEBzZWNvbmRzLiBJZiB0aGUKPiA+ID4gKyAqIHRpbWVvdXQg ZXhwaXJlcywga2lsbHMgYWxsIGNoaWxkcmVuIGFuZCBjbGVhbnMgdGhlbSB1cC4KPiA+ID4gICAq Lwo+ID4gPiAgdm9pZCBpZ3Rfd2FpdGNoaWxkcmVuX3RpbWVvdXQoaW50IHNlY29uZHMsIGNvbnN0 IGNoYXIgKnJlYXNvbikKPiA+ID4gIHsKPiA+ID4gLSAgICAgICBpZ3Rfc2V0X3RpbWVvdXQoc2Vj b25kcywgcmVhc29uKTsKPiA+ID4gLSAgICAgICBpZ3Rfd2FpdGNoaWxkcmVuKCk7Cj4gPiA+ICsg ICAgICAgc3RydWN0IHNpZ2FjdGlvbiBzYTsKPiA+ID4gKyAgICAgICBpbnQgcmV0Owo+ID4gPiAr Cj4gPiA+ICsgICAgICAgc2Euc2FfaGFuZGxlciA9IGlndF9hbGFybV9raWxsY2hpbGRyZW47Cj4g PiA+ICsgICAgICAgc2lnZW1wdHlzZXQoJnNhLnNhX21hc2spOwo+ID4gPiArICAgICAgIHNhLnNh X2ZsYWdzID0gMDsKPiA+ID4gKwo+ID4gPiArICAgICAgIGlndF9raWxsY2hpZHJlbl90aW1lZF9v dXQgPSBmYWxzZTsKPiA+ID4gKwo+ID4gPiArICAgICAgIHNpZ2FjdGlvbihTSUdBTFJNLCAmc2Es IE5VTEwpOwo+ID4gPiArCj4gPiA+ICsgICAgICAgYWxhcm0oc2Vjb25kcyk7Cj4gPiA+ICsKPiA+ ID4gKyAgICAgICByZXQgPSBfX2lndF93YWl0Y2hpbGRyZW4oKTsKPiA+ID4gKyAgICAgICBpZiAo IWlndF9raWxsY2hpZHJlbl90aW1lZF9vdXQgJiYgcmV0KQo+ID4gPiArICAgICAgICAgICAgICAg aWd0X2ZhaWwocmV0KTsKPiA+ID4gICAgICAgICBpZ3RfcmVzZXRfdGltZW91dCgpOwo+ID4gPiAr ICAgICAgIF9faWd0X3dhaXRjaGlsZHJlbigpOwo+ID4gPiArICAgICAgIGlmIChpZ3Rfa2lsbGNo aWRyZW5fdGltZWRfb3V0KQo+ID4gPiArICAgICAgICAgICAgICAgaWd0X2ZhaWwoSUdUX0VYSVRf RkFJTFVSRSk7Cj4gPiAKPiA+IERvdWJsZSBfX2lndF93YWl0Y2hpbGRyZW4oKT8gTXkgcmVhZGlu ZyBvZiBfX2lndF93YWl0Y2hpbGRyZW4oKSBpcyB0aGF0Cj4gPiBpdCB3aWxsIGNvbnRpbnVlIG9u IGFmdGVyIHRoZSBhbGFybSgpIHdha2VzIHdhaXQoKSB1cCB3aXRoIFNJR0lOVCBhbmQKPiA+IHJl cGVhdCB0aGUgd2FpdCgpIHVudGlsIGFsbCBjaGlsZHJlbiBkaWUuIEFuZCBub3cgdGhvc2UgY2hp bGRyZW4gd2lsbAo+ID4gZGllLCByYXRoZXIgdGhhbiB0aGUgcGFyZW50IGFzIGJlZm9yZS4KPiAK PiBpZ3Rfd2FpdGNoaWxkcmVuX3RpbWVvdXQgYmVmb3JlIHRoaXMgcGF0Y2ggd291bGRuJ3Qgd29y ayBpZiBpdCBkaWQgdGhhdC4KCkJlZm9yZSB0aGlzIHBhdGNoLCB0aGUgYWxhcm0gaGFuZGxlciBk aWQgaWd0X2ZhaWwgLT4gZXhpdCgxKSBpbiB0aGUKcGFyZW50LgoKPiBUaGUgcGlkID09IHdhaXQo KTsgaWYgKHBpZCA9PSAtMSkgY29udGludWU7IGJhaWxzIG91dCB0byB0aGUgbmV4dCBjaGlsZCBp bgo+IGNhc2Ugb2YgaW50ZXJydXB0cy4gSGVuY2UgdGhlIHdhaXQ7IGtpbGw7IHdhaXQgc2VxdWVu Y2UgaGVyZS4gSSBkaXNjb3ZlcmVkCj4gdGhpcyB0aHJvdWdoIHRlc3RjYXNlcyA6LSkKCk5vdyBh bGFybSAtPiB3YWl0KCkgcmV0dXJuaW5nIC0xICsgZXJybm89RUlOVFIsIHJpZ2h0PyBUaGVuIHRo ZQpzaWdoYW5kbGVyIGRvZXMga2lsbGFsbCAtOSwgc28gb24gdGhlIG5leHQgd2FpdCBpdCBzZWVz IHRoYXQgYWxsIHRoZQpjaGlsZHJlbiBhcmUgZGVhZC4KCl9faWd0X3dhaXRjaGlsZHJlbigpIGV2 ZW4gc2V0cyBudW1fdGVzdF9jaGlsZHJlbiA9IDAgb24gcmV0dXJuLCBzbyB0aGUKc2Vjb25kIF9f aWd0X3dhaXRjaGlsZHJlbigpIG11c3QgZG8gbm90aGluZy4gT3IgSSBhbSB2ZXJ5IGNvbmZ1c2Vk LgotQ2hyaXMKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K aWd0LWRldiBtYWlsaW5nIGxpc3QKaWd0LWRldkBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pZ3QtZGV2