From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CD75C282C4 for ; Tue, 12 Feb 2019 15:53:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CED6621773 for ; Tue, 12 Feb 2019 15:53:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="UIUJZDpY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730715AbfBLPxE (ORCPT ); Tue, 12 Feb 2019 10:53:04 -0500 Received: from m12-17.163.com ([220.181.12.17]:43182 "EHLO m12-17.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728347AbfBLPxE (ORCPT ); Tue, 12 Feb 2019 10:53:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=TcOv4WS7Uos60WBiKf ZTW4ox5fCXQFR8hYLnmHufscA=; b=UIUJZDpYlhsCIS+b/BEExuCJmb8KRIXv41 wDOIJpOkmRR7EhA+jnn4Sbrm44fzB79+eWvsqEnNFL26F0FzUxOdK7roKhE6kaak sIPCviEnru/B1k2ctnDHp6tbpVxq/aC3JhUvzwwUShhfjMl61mmuDQ/B+wUF/WVK D3JTzHvc4= Received: from yangwei-T440.lan (unknown [125.69.43.124]) by smtp13 (Coremail) with SMTP id EcCowAC3pM3X62Jc5bZ4FQ--.29851S3; Tue, 12 Feb 2019 23:52:56 +0800 (CST) From: Yang Wei To: netdev@vger.kernel.org Cc: davem@davemloft.net, yang.wei9@zte.com.cn, albin_yang@163.com Subject: [PATCH net] net: apple: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles Date: Tue, 12 Feb 2019 23:52:53 +0800 Message-Id: <1549986773-4974-1-git-send-email-albin_yang@163.com> X-Mailer: git-send-email 2.7.4 X-CM-TRANSID: EcCowAC3pM3X62Jc5bZ4FQ--.29851S3 X-Coremail-Antispam: 1Uf129KBjvdXoWrtrWDKF48tw48tw47Kw1rZwb_yoWfJFc_uw 129wn3Gw4UWF1jqw1jkF4rZryS9r1DXan5Za409rWavasFyr98Kw4kZF97u3s3WrWfGF9r tF9FgrW5Z343tjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUjsmR5UUUUU== X-Originating-IP: [125.69.43.124] X-CM-SenderInfo: pdoex0xb1d0wi6rwjhhfrp/1tbiHRNZolSIdHcFnwAAsw Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Yang Wei dev_consume_skb_irq() should be called in mace_interrupt() when skb xmit done. It makes drop profiles(dropwatch, perf) more friendly. Signed-off-by: Yang Wei --- drivers/net/ethernet/apple/mace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/apple/mace.c b/drivers/net/ethernet/apple/mace.c index 68b9ee4..4d9819d 100644 --- a/drivers/net/ethernet/apple/mace.c +++ b/drivers/net/ethernet/apple/mace.c @@ -764,7 +764,7 @@ static irqreturn_t mace_interrupt(int irq, void *dev_id) dev->stats.tx_bytes += mp->tx_bufs[i]->len; ++dev->stats.tx_packets; } - dev_kfree_skb_irq(mp->tx_bufs[i]); + dev_consume_skb_irq(mp->tx_bufs[i]); --mp->tx_active; if (++i >= N_TX_RING) i = 0; -- 2.7.4