From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <igt-dev-bounces@lists.freedesktop.org>
Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192])
 by gabe.freedesktop.org (Postfix) with ESMTPS id D72EA6E5E2
 for <igt-dev@lists.freedesktop.org>; Tue, 12 Feb 2019 16:09:23 +0000 (UTC)
MIME-Version: 1.0
From: Chris Wilson <chris@chris-wilson.co.uk>
In-Reply-To: <20190212160212.10015-1-daniel.vetter@ffwll.ch>
References: <20190212120429.20625-1-daniel.vetter@ffwll.ch>
 <20190212160212.10015-1-daniel.vetter@ffwll.ch>
Message-ID: <154998773467.11832.6635323623359769279@skylake-alporthouse-com>
Date: Tue, 12 Feb 2019 16:08:59 +0000
Subject: Re: [igt-dev] [PATCH i-g-t] lib: Don't leak children in
 igt_waitchildren_timeout
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/igt-dev>
List-Post: <mailto:igt-dev@lists.freedesktop.org>
List-Help: <mailto:igt-dev-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=subscribe>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Errors-To: igt-dev-bounces@lists.freedesktop.org
Sender: "igt-dev" <igt-dev-bounces@lists.freedesktop.org>
To: Daniel Vetter <daniel.vetter@ffwll.ch>, IGT development <igt-dev@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@intel.com>
List-ID: <igt-dev@lists.freedesktop.org>

UXVvdGluZyBEYW5pZWwgVmV0dGVyICgyMDE5LTAyLTEyIDE2OjAyOjEyKQo+IEluc3RlYWQgb2Yg
Y2xlYW5pbmcgdXAgdGhlIG1lc3MgaW4gaWd0X2V4aXQgbWFrZSBzdXJlIHdlIGRvbid0IGV2ZW4K
PiBsZXQgaXQgb3V0IG9mIHRoZSBjb250YWluZXIuIFNlZSBhbHNvCj4gCj4gY29tbWl0IDc1NDg3
NjM3OGQ2YzliMjc3NWU4YzA3YjRkMTZmOTg3OGM1NTk0OWYKPiBBdXRob3I6IENocmlzIFdpbHNv
biA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IERhdGU6ICAgRnJpIEZlYiAyNiAyMjoxMTox
MCAyMDE2ICswMDAwCj4gCj4gICAgIGlndC9nZW1fc3luYzogRW5mb3JjZSBhIHRpbWVvdXQgb2Yg
MjBzCj4gCj4gd2hpY2ggYWRkZWQgdGhpcyBoZWxwZXIuCj4gCj4gVG8gbWFrZSBzdXJlIHRoYXQg
ZXZlcnlvbmUgZm9sbG93cyB0aGUgcnVsZXMsIGFkZCBhbiBhc3NlcnQuCj4gCj4gV2UncmUga2Vl
cGluZyB0aGUgY2xlYW51cCBjb2RlIGFzIGEgZmFpbHNhZmUsIGFuZCBiZWNhdXNlIGl0IHNwZWVk
cwo+IHVwIHRoZSB0ZXN0Y2FzZSBJJ20gZm9sbG93aW5nIHVwIHdpdGguCj4gCj4gdjI6IENocmlz
IHBvaW50ZWQgb3V0IHRoYXQgbXkgb3JpZ2luYWwgcGF0Y2ggZGlkIG5vdGhpbmcuIFdoaWNoIEkK
PiBkaWRuJ3QgY2F0Y2ggYmVjYXVzZSBteSB0ZXN0Y2FzZSB3YXMgYWxzbyBicm9rZW4uIFVuZm9y
dHVuYXRlbHkgdGhpcwo+IG1lYW5zIHdlIG5lZWQgdG8gb3BlbiBjb2RlIHBhcnQgb2YgdGhlIHdh
aXRpbmcuCj4gCj4gdjM6IFRoZSAybmQgX19pZ3Rfd2FpdGNoaWxkcmVuKCkgaXNuJ3QgbmVjZXNz
YXJ5LCBfX2lndF93YWl0Y2hpbGRyZW4KPiByZWNvdmVycyBmcm9tIEVJTlRSIGFscmVhZHkgYW5k
IGtlZXBzIHdhaXRpbmcgKENocmlzIFdpbHNvbikuCj4gCj4gdjQ6IENoYW5nZSB0aGUgdGltZW91
dCBzaWduYWwgdnMgd2FpdGNoaWxkcmVuIGxvZ2ljIHRvIGJlIHJhY2UtZnJlZQo+IChDaHJpcyku
ICBUaGlzIGNoYW5nZXMgdGhlIGV4aXQgY29kZSBmb3IgYSB0aW1lb3V0IGZyb20KPiBJR1RfRVhJ
VF9GQUlMVVJFIHRvIFNJR0tJTEwgKyAxMjguCj4gCj4gQ2M6IENocmlzIFdpbHNvbiA8Y2hyaXNA
Y2hyaXMtd2lsc29uLmNvLnVrPgo+IFNpZ25lZC1vZmYtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmll
bC52ZXR0ZXJAaW50ZWwuY29tPgo+IC0tLQo+ICBsaWIvaWd0X2NvcmUuYyB8IDMwICsrKysrKysr
KysrKysrKysrKysrKysrKystLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMjUgaW5zZXJ0aW9ucygr
KSwgNSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvbGliL2lndF9jb3JlLmMgYi9saWIv
aWd0X2NvcmUuYwo+IGluZGV4IGNiYmU3OWY4ODA3MC4uNTdmNzU3NDIxMzA5IDEwMDY0NAo+IC0t
LSBhL2xpYi9pZ3RfY29yZS5jCj4gKysrIGIvbGliL2lndF9jb3JlLmMKPiBAQCAtMTUyNSw2ICsx
NTI1LDcgQEAgdm9pZCBpZ3RfZXhpdCh2b2lkKQo+ICAKPiAgICAgICAgIGZvciAoaW50IGMgPSAw
OyBjIDwgbnVtX3Rlc3RfY2hpbGRyZW47IGMrKykKPiAgICAgICAgICAgICAgICAga2lsbCh0ZXN0
X2NoaWxkcmVuW2NdLCBTSUdLSUxMKTsKPiArICAgICAgIGFzc2VydCghbnVtX3Rlc3RfY2hpbGRy
ZW4pOwo+ICAKPiAgICAgICAgIGlmICghdGVzdF93aXRoX3N1YnRlc3RzKSB7Cj4gICAgICAgICAg
ICAgICAgIHN0cnVjdCB0aW1lc3BlYyBub3c7Cj4gQEAgLTE4MzIsMjAgKzE4MzMsMzkgQEAgdm9p
ZCBpZ3Rfd2FpdGNoaWxkcmVuKHZvaWQpCj4gICAgICAgICAgICAgICAgIGlndF9mYWlsKGVycik7
Cj4gIH0KPiAgCj4gK3N0YXRpYyB2b2lkIGlndF9hbGFybV9raWxsY2hpbGRyZW4oaW50IHNpZ25h
bCkKPiArewo+ICsgICAgICAgaWd0X2luZm8oIlRpbWVkIG91dCB3YWl0aW5nIGZvciBjaGlsZHJl
blxuIik7Cj4gKwo+ICsgICAgICAgZm9yIChpbnQgYyA9IDA7IGMgPCBudW1fdGVzdF9jaGlsZHJl
bjsgYysrKQo+ICsgICAgICAgICAgICAgICBraWxsKHRlc3RfY2hpbGRyZW5bY10sIFNJR0tJTEwp
Owo+ICt9Cj4gKwo+ICAvKioKPiAgICogaWd0X3dhaXRjaGlsZHJlbl90aW1lb3V0Ogo+ICAgKiBA
c2Vjb25kczogdGltZW91dCBpbiBzZWNvbmRzIHRvIHdhaXQKPiAgICogQHJlYXNvbjogZGVidWcg
c3RyaW5nIGV4cGxhaW5pbmcgd2hhdCB0aW1lZG91dAo+ICAgKgo+IC0gKiBXYWl0IGZvciBhbGwg
Y2hpbGRyZW4gZm9ya2VkIHdpdGggaWd0X2ZvcmssIGZvciBhIG1heGltdW0gb2YgQHNlY29uZHMu
Cj4gLSAqCj4gLSAqIFdyYXBzIGlndF93YWl0Y2hpbGRyZW4oKSBhbmQgaWd0X3NldF90aW1lb3V0
KCkKPiArICogV2FpdCBmb3IgYWxsIGNoaWxkcmVuIGZvcmtlZCB3aXRoIGlndF9mb3JrLCBmb3Ig
YSBtYXhpbXVtIG9mIEBzZWNvbmRzLiBJZiB0aGUKPiArICogdGltZW91dCBleHBpcmVzLCBraWxs
cyBhbGwgY2hpbGRyZW4gYW5kIGNsZWFucyB0aGVtIHVwLgoKLi4uYmVmb3JlIHJlcG9ydGluZyB0
aGUgZmFpbCB3aXRoIGlndF9mYWlsCgpPciB3aGF0ZXZlciBpcyB0aGUgY29tbW9uIGxhbmd1YWdl
IGZvciBoaXR0aW5nIGlndF9mYWlsKCkuIEFzIGl0IHN0YW5kcywKaXQgc291bmRzIGxpa2UgaXQg
c2hvdWxkIGdyYWNlZnVsbHkgY2xlYW4gdXAgYW5kIHJldHVybiBjb250cm9sIG9uCnRpbWVvdXQu
Cgo+ICAgKi8KPiAgdm9pZCBpZ3Rfd2FpdGNoaWxkcmVuX3RpbWVvdXQoaW50IHNlY29uZHMsIGNv
bnN0IGNoYXIgKnJlYXNvbikKPiAgewo+IC0gICAgICAgaWd0X3NldF90aW1lb3V0KHNlY29uZHMs
IHJlYXNvbik7Cj4gLSAgICAgICBpZ3Rfd2FpdGNoaWxkcmVuKCk7Cj4gKyAgICAgICBzdHJ1Y3Qg
c2lnYWN0aW9uIHNhOwo+ICsgICAgICAgaW50IHJldDsKPiArCj4gKyAgICAgICBzYS5zYV9oYW5k
bGVyID0gaWd0X2FsYXJtX2tpbGxjaGlsZHJlbjsKPiArICAgICAgIHNpZ2VtcHR5c2V0KCZzYS5z
YV9tYXNrKTsKPiArICAgICAgIHNhLnNhX2ZsYWdzID0gMDsKCglzdHJ1Y3Qgc2lnYWN0aW9uIHNh
ID0geyAuc2FfaGFuZGxlciA9IGlndF9hbGFybV9raWxsY2hpbGRyZW4gfTsKPwoKPiArCj4gKyAg
ICAgICBzaWdhY3Rpb24oU0lHQUxSTSwgJnNhLCBOVUxMKTsKPiArCj4gKyAgICAgICBhbGFybShz
ZWNvbmRzKTsKPiArCj4gKyAgICAgICByZXQgPSBfX2lndF93YWl0Y2hpbGRyZW4oKTsKPiAgICAg
ICAgIGlndF9yZXNldF90aW1lb3V0KCk7Cj4gKyAgICAgICBpZiAocmV0KQo+ICsgICAgICAgICAg
ICAgICBpZ3RfZmFpbChyZXQpOwoKTGd0bSwKUmV2aWV3ZWQtYnk6IENocmlzIFdpbHNvbiA8Y2hy
aXNAY2hyaXMtd2lsc29uLmNvLnVrPgotQ2hyaXMKX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX18KaWd0LWRldiBtYWlsaW5nIGxpc3QKaWd0LWRldkBsaXN0cy5m
cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0
aW5mby9pZ3QtZGV2