All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <jejb@linux.ibm.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] scsi: lpfc: Remove set but not used variable 'phys_id'
Date: Thu, 14 Feb 2019 19:39:01 +0000	[thread overview]
Message-ID: <1550173141.4558.19.camel@linux.ibm.com> (raw)
In-Reply-To: <1536804299-64730-1-git-send-email-yuehaibing@huawei.com>

On Thu, 2019-02-14 at 10:52 -0800, James Smart wrote:
> 
> On 2/13/2019 5:51 PM, YueHaibing wrote:
> > Fixes gcc '-Wunused-but-set-variable' warning:
> > 
> > drivers/scsi/lpfc/lpfc_init.c: In function
> > 'lpfc_cpu_affinity_check':
> > drivers/scsi/lpfc/lpfc_init.c:10599:19: warning:
> >   variable 'phys_id' set but not used [-Wunused-but-set-variable]
> > 
> > It never used since introduction in commit 6a828b0f6192 ("scsi:
> > lpfc: Support
> > non-uniform allocation of MSIX vectors to hardware queues")
> > 
> > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> > ---
> >   drivers/scsi/lpfc/lpfc_init.c | 3 +--
> >   1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > 
> 
> Looks fine. Thanks
> 
> Signed-off-by:   James Smart  <james.smart@broadcom.com>

Under the DCO this can't be a Signed-off-by tag: signoffs track the
patch transmission path under the DCO, so unless you send it you can't
add your signoff.

If you just want Martin to apply it now, and you don't want to gather
and resend it with your other lpfc patches, I think the tag you want is
Acked-by.

James

  parent reply	other threads:[~2019-02-14 19:39 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-13  1:58 [PATCH -next] scsi: lpfc: Remove set but not used variable 'sgl_size' YueHaibing
2018-09-14 10:41 ` [PATCH -next] scsi: lpfc: Remove set but not used variables 'fc_hdr' and 'hw_page_size' YueHaibing
2018-09-17  7:02 ` [PATCH -next] scsi: lpfc: Remove set but not used variable 'sgl_size' Martin K. Petersen
2018-09-29 13:53 ` [PATCH -next] scsi: lpfc: Remove set but not used variable 'psli' YueHaibing
2018-10-04 10:51 ` [PATCH -next] scsi: lpfc: Remove set but not used variables 'tgtp' YueHaibing
2018-10-17  1:47 ` [PATCH -next] scsi: lpfc: Remove set but not used variable 'psli' Martin K. Petersen
2018-10-17  1:58 ` [PATCH -next] scsi: lpfc: Remove set but not used variables 'tgtp' Martin K. Petersen
2018-12-11  8:21 ` [PATCH -next] scsi: lpfc: Remove set but not used variable 'maxch' YueHaibing
2019-02-14 18:52 ` [PATCH -next] scsi: lpfc: Remove set but not used variable 'phys_id' James Smart
2019-02-14 19:39 ` James Bottomley [this message]
2019-02-14 19:46 ` Martin K. Petersen
2019-02-14 21:19 ` James Smart
2019-02-14 21:24 ` James Bottomley
2019-02-15  7:44 ` Dan Carpenter
2019-02-14  1:51 YueHaibing

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1550173141.4558.19.camel@linux.ibm.com \
    --to=jejb@linux.ibm.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.