From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=DATE_IN_PAST_06_12, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE8A9C43381 for ; Thu, 21 Feb 2019 13:42:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8DCFF207E0 for ; Thu, 21 Feb 2019 13:42:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="h0jR5NLq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728117AbfBUNmd (ORCPT ); Thu, 21 Feb 2019 08:42:33 -0500 Received: from mail-pf1-f196.google.com ([209.85.210.196]:34811 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725991AbfBUNmc (ORCPT ); Thu, 21 Feb 2019 08:42:32 -0500 Received: by mail-pf1-f196.google.com with SMTP id u9so6597399pfn.1 for ; Thu, 21 Feb 2019 05:42:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=LHhcxyZm99CEc5bGI4rzwEkPF4ohcSuLu0FF3f07+kU=; b=h0jR5NLqHp9d6j5ZaE3uMBWANbkowU3/S3PcDqlLiRHKaFKwr3brrMnc9xUmg1XURK wUPCoRmMqiPR3VL1h7mUSz+7qAW3uAz9y78uIivyaJm5AGUxpuSdZf4y4LZsZJ1esmEs U5QcDiGQWsc4XZlcsBWxWDMNRxI6ajMATQRKVJtgtJXfySwMGEv+pFP7kyxI/e9D8vFF 6aE4+lPKGHQ2ozERiU2BoEifZ7RRUrBn3luDforqcbihbBKlNMH+KxTG9hdffbgyOvj0 +QeBqJvCQii9d4BckWDaKD2zy6iznxRzZTZNSq4EJ690gvG0TtuuBM1sucOoH9Ar6aBo h4LA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=LHhcxyZm99CEc5bGI4rzwEkPF4ohcSuLu0FF3f07+kU=; b=QLkTS/mUp+mQ1upHpXkWNqh4jqMl/uYSY1HJMRnIXglU+fWn2diMqqWKruRAiO7pjo muOwvQd+eJbZF0gP92AuaTu3OL3vv1jZKtBK2+brajF+ttCChJV1eEPOoguaJcAFKDt0 ikjkJdvLntqDPMDWxFSaU4RYbuIryperRbASxNpaBV4RzIHXW0mt6qZim8vBeqG1uorl PlQN/giu1R6BHbv+2bUeZqCPfdTZq3UU+zrmzjU6aXv7a3hbVc3lzQY77S+D/z7V5A5N XxGMApzG+BogYZAWM8NNe6VS1794cllXxiXxcd+O697MsNRx7Euj5vkzCxaSuYRtNhh1 BaAw== X-Gm-Message-State: AHQUAuYyCDouikZYR8cq1QUI7uBz9K3XTpAuFIvn4rxubqaUU2/pvD2N SbP2cFlhTsJ+UsvPWLR0rPI= X-Google-Smtp-Source: AHgI3IbfOrBnyX/KrMh/PXaJyW6C6T9aO1c+ED6F16079I7KF3NabU6778x4AsWzPBXohDBeibaOqQ== X-Received: by 2002:a62:1ace:: with SMTP id a197mr296475pfa.78.1550756551438; Thu, 21 Feb 2019 05:42:31 -0800 (PST) Received: from local.opencloud.tech.localdomain ([203.100.54.194]) by smtp.gmail.com with ESMTPSA id n4sm5265970pfh.8.2019.02.21.05.42.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Feb 2019 05:42:30 -0800 (PST) From: xiangxia.m.yue@gmail.com To: saeedm@mellanox.com, gerlitz.or@gmail.com Cc: netdev@vger.kernel.org, Tonghao Zhang Subject: [PATCH net-next 2/5] net/mlx5e: Make the log friendly when decapsulation offload not supported Date: Wed, 20 Feb 2019 18:14:40 -0800 Message-Id: <1550715283-23579-2-git-send-email-xiangxia.m.yue@gmail.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1550715283-23579-1-git-send-email-xiangxia.m.yue@gmail.com> References: <1550715283-23579-1-git-send-email-xiangxia.m.yue@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Tonghao Zhang If we try to offload decapsulation actions to VFs hw, we get the log [1]. It's not friendly, because the kind of net device is null, and we don't know what '0' means. [1] "mlx5_core 0000:05:01.2 vf_0: decapsulation offload is not supported for net device (0)" Signed-off-by: Tonghao Zhang --- drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c b/drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c index bdcc5e7..6911e0a 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c @@ -620,8 +620,10 @@ int mlx5e_tc_tun_parse(struct net_device *filter_dev, headers_c, headers_v); } else { netdev_warn(priv->netdev, - "decapsulation offload is not supported for %s net device (%d)\n", - mlx5e_netdev_kind(filter_dev), tunnel_type); + "decapsulation offload is not supported for %s (kind: \"%s\")\n", + netdev_name(filter_dev), + mlx5e_netdev_kind(filter_dev)); + return -EOPNOTSUPP; } return err; -- 1.8.3.1