* [PATCH] externalsrc: Remove task dependencies to deleted tasks
@ 2021-01-25 21:01 Tomasz Dziendzielski
2021-01-25 23:04 ` [OE-core] " Richard Purdie
0 siblings, 1 reply; 3+ messages in thread
From: Tomasz Dziendzielski @ 2021-01-25 21:01 UTC (permalink / raw)
To: openembedded-core; +Cc: Tomasz Dziendzielski
The python3 recipe sets `do_create_manifest[depends] += "${PN}:do_patch"`
but do_patch is removed in externalsrc and fails with:
| ERROR: Task do_create_manifest in <PATH>/python3_3.8.2.bb depends upon
| non-existent task do_patch in <PATH>/python3_3.8.2.bb
It is safe to simply remove these dependencies since they should be
already covered.
[YOCTO #14151]
Signed-off-by: Tomasz Dziendzielski <tomasz.dziendzielski@gmail.com>
---
meta/classes/externalsrc.bbclass | 3 +++
1 file changed, 3 insertions(+)
diff --git a/meta/classes/externalsrc.bbclass b/meta/classes/externalsrc.bbclass
index 7a7d31e311..8e164707e6 100644
--- a/meta/classes/externalsrc.bbclass
+++ b/meta/classes/externalsrc.bbclass
@@ -107,6 +107,9 @@ python () {
for task in d.getVar("SRCTREECOVEREDTASKS").split():
if local_srcuri and task in fetch_tasks:
continue
+ for bbtask in (d.getVar('__BBTASKS', False) or []):
+ if 'depends' in (d.getVarFlags(bbtask, False) or []) and ('${PN}:%s' % task) in d.getVarFlags(bbtask, False)['depends']:
+ d.setVarFlag(bbtask, 'depends', d.getVarFlags(bbtask, False)['depends'].replace(('${PN}:%s' % task), ''))
bb.build.deltask(task, d)
d.prependVarFlag('do_compile', 'prefuncs', "externalsrc_compile_prefunc ")
--
2.30.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [OE-core] [PATCH] externalsrc: Remove task dependencies to deleted tasks
2021-01-25 21:01 [PATCH] externalsrc: Remove task dependencies to deleted tasks Tomasz Dziendzielski
@ 2021-01-25 23:04 ` Richard Purdie
2021-01-25 23:34 ` Tomasz Dziendzielski
0 siblings, 1 reply; 3+ messages in thread
From: Richard Purdie @ 2021-01-25 23:04 UTC (permalink / raw)
To: Tomasz Dziendzielski, openembedded-core
On Mon, 2021-01-25 at 22:01 +0100, Tomasz Dziendzielski wrote:
> The python3 recipe sets `do_create_manifest[depends] += "${PN}:do_patch"`
> but do_patch is removed in externalsrc and fails with:
> > ERROR: Task do_create_manifest in <PATH>/python3_3.8.2.bb depends upon
> > non-existent task do_patch in <PATH>/python3_3.8.2.bb
>
> It is safe to simply remove these dependencies since they should be
> already covered.
>
> [YOCTO #14151]
>
> Signed-off-by: Tomasz Dziendzielski <tomasz.dziendzielski@gmail.com>
> ---
> meta/classes/externalsrc.bbclass | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/meta/classes/externalsrc.bbclass b/meta/classes/externalsrc.bbclass
> index 7a7d31e311..8e164707e6 100644
> --- a/meta/classes/externalsrc.bbclass
> +++ b/meta/classes/externalsrc.bbclass
> @@ -107,6 +107,9 @@ python () {
> for task in d.getVar("SRCTREECOVEREDTASKS").split():
> if local_srcuri and task in fetch_tasks:
> continue
> + for bbtask in (d.getVar('__BBTASKS', False) or []):
> + if 'depends' in (d.getVarFlags(bbtask, False) or []) and ('${PN}:%s' % task) in d.getVarFlags(bbtask, False)['depends']:
> + d.setVarFlag(bbtask, 'depends', d.getVarFlags(bbtask, False)['depends'].replace(('${PN}:%s' % task), ''))
> bb.build.deltask(task, d)
would it help to change the python recipe to do:
addtask do_create_manifest after do_patch do_prepare_recipe_sysroot
?
Cheers,
Richard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-25 23:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-25 21:01 [PATCH] externalsrc: Remove task dependencies to deleted tasks Tomasz Dziendzielski
2021-01-25 23:04 ` [OE-core] " Richard Purdie
2021-01-25 23:34 ` Tomasz Dziendzielski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.