From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1259289E1D for ; Tue, 5 Mar 2019 13:25:17 +0000 (UTC) MIME-Version: 1.0 From: Chris Wilson In-Reply-To: <20190305131611.2367-3-andi.shyti@intel.com> References: <20190305131611.2367-1-andi.shyti@intel.com> <20190305131611.2367-3-andi.shyti@intel.com> Message-ID: <155179227054.27405.15504576818701053262@skylake-alporthouse-com> Date: Tue, 05 Mar 2019 13:24:35 +0000 Subject: Re: [igt-dev] [RFC PATCH v10 2/6] lib/i915: add gem_engine_topology library List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Andi Shyti , IGT dev Cc: Andi Shyti List-ID: UXVvdGluZyBBbmRpIFNoeXRpICgyMDE5LTAzLTA1IDEzOjE2OjA3KQo+IFRoZSBnZW1fZW5naW5l X3RvcG9sb2d5IGxpYnJhcnkgaXMgYSBzZXQgb2YgZnVuY3Rpb25zIHRoYXQKPiBpbnRlcmZhY2Ug d2l0aCB0aGUgcXVlcnkgYW5kIGdldHBhcmFtL3NldHBhcmFtIGlvY3Rscy4KPiAKPiBUaGUgbGli cmFyeSdzIHRocmVlIG1haW4gYWNjZXNzIHBvaW50cyBhcmU6Cj4gCj4gIC0gZ2V0X2FjdGl2ZV9l bmdpbmVzKCkKPiAgLSBnZW1fc2V0X2NvbnRleHRfZ2V0X2VuZ2luZXMoKQo+ICAtIGlndF9yZXF1 aXJlX2dlbV9lbmdpbmVfbGlzdCgpCj4gCj4gVGhlIGZpcnN0IHR3byBmdW5jdGlvbnMgYXJlIHNp bWlsYXIsIHdpdGggdGhlIGRpZmZlcmVuY2UgdGhhdCB0aGUKPiAnZ2VtX3NldF9jb250ZXh0X2dl dF9lbmdpbmVzKCknIHNldHMgdGhlIGVuZ2luZSBiZWZvcmUgcmV0dXJuaW5nCj4gdGhlIGVuZ2lu ZSBsaXN0IGluIGEgJ2ludGVsX2V4ZWN1dGlvbl9lbmdpbmUyJyB0eXBlIGFycmF5Lgo+IEFub3Ro ZXIgaW1wcm90YW50IGRpZmZlcmVuY2UgaXMgdGhhdCB0aGUgZmlyc3QgZnVuY3Rpb24gd29ya3MK PiBvbmx5IHdpdGggdGhlIGdldHBhcmFtL3NldHBhcmFtIGFuZCBxdWVyeSBpb2N0bHMgYXJlIGlt cGxlbWVudGVkCj4gYW5kIGl0IHJldHVybiAnTlVMTCcgaW4gdGhlIG90aGVyIGNhc2UuCj4gCj4g J2dlbV9zZXRfY29udGV4dF9nZXRfZW5naW5lcygpJyBmdW5jdGlvbiwgYXQgdGhlIGZpcnN0IGNh bGwKPiBnZW5lcmF0ZXMgdGhlIGFycmF5IG9mIGFjdGl2ZSBlbmdpbmVzIChlaXRoZXIgcGh5c2lj YWwgb3IKPiB2aXJ0dWFsKSBjYWxsZWQgJ2ludGVsX2FjdGl2ZV9lbmdpbmVzMicuCj4gSWYgdGhl IGRyaXZlciBjYW5ub3QgYmUgcXVlcmllZCwgdGhlICdpbnRlbF9hY3RpdmVfZW5naW5lczInCj4g YXJyYXkgcG9pbnRzIHRvIHRoZSBleGlzaXRpbmcgJ2ludGVsX2V4ZWN1dGlvbl9lbmdpbmVzMicg d2hpY2gKPiBoYXMgYmVlbiBwcmV2aW91c2x5IGRlZmluZWQuCj4gCj4gVGhlIHZhbHVlIG9mIHRo ZSAnaW50ZWxfYWN0aXZlX2VuZ2luZXMyJyB3aWxsIGJlIHVzZWQgaW4gZnVydGhlcgo+IGNhbGxz IHRvIGNoZWNrIHdoZXRoZXIgdGhlIGFib3ZlIG1lbnRpb25lZCBpb2N0bHMgYXJlIGltcGxlbWVu dGVkCj4gd2l0aG91dCB0aGUgbmVlZCB0byBjYWxsIGdldHBhcmFtKCkuCj4gCj4gVGhlICdpZ3Rf cmVxdWlyZV9nZW1fZW5naW5lX2xpc3QoKScgY2F1c2VzIHRoZSB0ZXN0IHRvIGZhaWwgaW4KPiBj YXNlIHRoZSByZXF1aXJlZCBpb2N0bHMgYXJlIG5vdCBpbXBsZW1lbnRlZC4KPiAKPiBTaWduZWQt b2ZmLWJ5OiBBbmRpIFNoeXRpIDxhbmRpLnNoeXRpQGludGVsLmNvbT4KPiAtLS0KPiAgbGliL01h a2VmaWxlLnNvdXJjZXMgICAgICAgICAgIHwgICAyICsKPiAgbGliL2k5MTUvZ2VtX2VuZ2luZV90 b3BvbG9neS5jIHwgMTk5ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwo+ICBsaWIv aTkxNS9nZW1fZW5naW5lX3RvcG9sb2d5LmggfCAgMzkgKysrKysrKwo+ICBsaWIvaWd0X2d0LmMg ICAgICAgICAgICAgICAgICAgfCAgIDIgKy0KPiAgbGliL2lndF9ndC5oICAgICAgICAgICAgICAg ICAgIHwgICAyICstCj4gIGxpYi9tZXNvbi5idWlsZCAgICAgICAgICAgICAgICB8ICAgMSArCj4g IDYgZmlsZXMgY2hhbmdlZCwgMjQzIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4gIGNy ZWF0ZSBtb2RlIDEwMDY0NCBsaWIvaTkxNS9nZW1fZW5naW5lX3RvcG9sb2d5LmMKPiAgY3JlYXRl IG1vZGUgMTAwNjQ0IGxpYi9pOTE1L2dlbV9lbmdpbmVfdG9wb2xvZ3kuaAo+IAo+IGRpZmYgLS1n aXQgYS9saWIvTWFrZWZpbGUuc291cmNlcyBiL2xpYi9NYWtlZmlsZS5zb3VyY2VzCj4gaW5kZXgg Y2YyNzIwOTgxNzA3Li43NTdiZDdhMTdlYmUgMTAwNjQ0Cj4gLS0tIGEvbGliL01ha2VmaWxlLnNv dXJjZXMKPiArKysgYi9saWIvTWFrZWZpbGUuc291cmNlcwo+IEBAIC0xMyw2ICsxMyw4IEBAIGxp Yl9zb3VyY2VfbGlzdCA9ICAgICAgICAgICAgIFwKPiAgICAgICAgIGk5MTUvZ2VtX3JpbmcuYyBc Cj4gICAgICAgICBpOTE1L2dlbV9tbWFuLmMgXAo+ICAgICAgICAgaTkxNS9nZW1fbW1hbi5oIFwK PiArICAgICAgIGk5MTUvZ2VtX2VuZ2luZV90b3BvbG9neS5jICAgICAgXAo+ICsgICAgICAgaTkx NS9nZW1fZW5naW5lX3RvcG9sb2d5LmggICAgICBcCj4gICAgICAgICBpOTE1XzNkLmggICAgICAg ICAgICAgICBcCj4gICAgICAgICBpOTE1X3JlZy5oICAgICAgICAgICAgICBcCj4gICAgICAgICBp OTE1X3BjaWlkcy5oICAgICAgICAgICBcCj4gZGlmZiAtLWdpdCBhL2xpYi9pOTE1L2dlbV9lbmdp bmVfdG9wb2xvZ3kuYyBiL2xpYi9pOTE1L2dlbV9lbmdpbmVfdG9wb2xvZ3kuYwo+IG5ldyBmaWxl IG1vZGUgMTAwNjQ0Cj4gaW5kZXggMDAwMDAwMDAwMDAwLi45Mzc2YjQ3OTI0NDEKPiAtLS0gL2Rl di9udWxsCj4gKysrIGIvbGliL2k5MTUvZ2VtX2VuZ2luZV90b3BvbG9neS5jCj4gQEAgLTAsMCAr MSwxOTkgQEAKPiArLyoKPiArICogQ29weXJpZ2h0IMKpIDIwMTkgSW50ZWwgQ29ycG9yYXRpb24K PiArICoKPiArICogUGVybWlzc2lvbiBpcyBoZXJlYnkgZ3JhbnRlZCwgZnJlZSBvZiBjaGFyZ2Us IHRvIGFueSBwZXJzb24gb2J0YWluaW5nIGEKPiArICogY29weSBvZiB0aGlzIHNvZnR3YXJlIGFu ZCBhc3NvY2lhdGVkIGRvY3VtZW50YXRpb24gZmlsZXMgKHRoZSAiU29mdHdhcmUiKSwKPiArICog dG8gZGVhbCBpbiB0aGUgU29mdHdhcmUgd2l0aG91dCByZXN0cmljdGlvbiwgaW5jbHVkaW5nIHdp dGhvdXQgbGltaXRhdGlvbgo+ICsgKiB0aGUgcmlnaHRzIHRvIHVzZSwgY29weSwgbW9kaWZ5LCBt ZXJnZSwgcHVibGlzaCwgZGlzdHJpYnV0ZSwgc3VibGljZW5zZSwKPiArICogYW5kL29yIHNlbGwg Y29waWVzIG9mIHRoZSBTb2Z0d2FyZSwgYW5kIHRvIHBlcm1pdCBwZXJzb25zIHRvIHdob20gdGhl Cj4gKyAqIFNvZnR3YXJlIGlzIGZ1cm5pc2hlZCB0byBkbyBzbywgc3ViamVjdCB0byB0aGUgZm9s bG93aW5nIGNvbmRpdGlvbnM6Cj4gKyAqCj4gKyAqIFRoZSBhYm92ZSBjb3B5cmlnaHQgbm90aWNl IGFuZCB0aGlzIHBlcm1pc3Npb24gbm90aWNlIChpbmNsdWRpbmcgdGhlIG5leHQKPiArICogcGFy YWdyYXBoKSBzaGFsbCBiZSBpbmNsdWRlZCBpbiBhbGwgY29waWVzIG9yIHN1YnN0YW50aWFsIHBv cnRpb25zIG9mIHRoZQo+ICsgKiBTb2Z0d2FyZS4KPiArICoKPiArICogVEhFIFNPRlRXQVJFIElT IFBST1ZJREVEICJBUyBJUyIsIFdJVEhPVVQgV0FSUkFOVFkgT0YgQU5ZIEtJTkQsIEVYUFJFU1Mg T1IKPiArICogSU1QTElFRCwgSU5DTFVESU5HIEJVVCBOT1QgTElNSVRFRCBUTyBUSEUgV0FSUkFO VElFUyBPRiBNRVJDSEFOVEFCSUxJVFksCj4gKyAqIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQ VVJQT1NFIEFORCBOT05JTkZSSU5HRU1FTlQuICBJTiBOTyBFVkVOVCBTSEFMTAo+ICsgKiBUSEUg QVVUSE9SUyBPUiBDT1BZUklHSFQgSE9MREVSUyBCRSBMSUFCTEUgRk9SIEFOWSBDTEFJTSwgREFN QUdFUyBPUiBPVEhFUgo+ICsgKiBMSUFCSUxJVFksIFdIRVRIRVIgSU4gQU4gQUNUSU9OIE9GIENP TlRSQUNULCBUT1JUIE9SIE9USEVSV0lTRSwgQVJJU0lORwo+ICsgKiBGUk9NLCBPVVQgT0YgT1Ig SU4gQ09OTkVDVElPTiBXSVRIIFRIRSBTT0ZUV0FSRSBPUiBUSEUgVVNFIE9SIE9USEVSIERFQUxJ TkdTCj4gKyAqIElOIFRIRSBTT0ZUV0FSRS4KPiArICovCj4gKwo+ICsjaW5jbHVkZSAiZHJtdGVz dC5oIgo+ICsjaW5jbHVkZSAiaWd0X2d0LmgiCj4gKyNpbmNsdWRlICJpb2N0bF93cmFwcGVycy5o Igo+ICsKPiArI2luY2x1ZGUgImk5MTUvZ2VtX2VuZ2luZV90b3BvbG9neS5oIgo+ICsKPiArI2Rl ZmluZSBTSVpFT0ZfQ1RYX1BBUkFNICAgICAgIG9mZnNldG9mKHN0cnVjdCBpOTE1X2NvbnRleHRf cGFyYW1fZW5naW5lcywgXAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBjbGFzc19pbnN0YW5jZVtJOTE1X0VYRUNfUklOR19NQVNLICsgMV0pCj4gKyNkZWZpbmUgU0la RU9GX1FVRVJZICAgICAgICAgICBvZmZzZXRvZihzdHJ1Y3QgZHJtX2k5MTVfcXVlcnlfZW5naW5l X2luZm8sIFwKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZW5naW5l c1tJOTE1X0VYRUNfUklOR19NQVNLICsgMV0pCj4gKwo+ICtzdGF0aWMgc3RydWN0IGludGVsX2V4 ZWN1dGlvbl9lbmdpbmUyICppbnRlbF9hY3RpdmVfZW5naW5lczI7Cj4gKwo+ICtpbnQgX19nZW1f cXVlcnkoaW50IGZkLCBzdHJ1Y3QgZHJtX2k5MTVfcXVlcnkgKnEpCj4gK3sKPiArICAgICAgIGlu dCBlcnIgPSAwOwo+ICsKPiArICAgICAgIGlmIChpZ3RfaW9jdGwoZmQsIERSTV9JT0NUTF9JOTE1 X1FVRVJZLCBxKSkKPiArICAgICAgICAgICAgICAgZXJyID0gLWVycm5vOwo+ICsKPiArICAgICAg IGVycm5vID0gMDsKPiArICAgICAgIHJldHVybiBlcnI7Cj4gK30KPiArCj4gK3ZvaWQgZ2VtX3F1 ZXJ5KGludCBmZCwgc3RydWN0IGRybV9pOTE1X3F1ZXJ5ICpxKQo+ICt7Cj4gKyAgICAgICBpZ3Rf YXNzZXJ0X2VxKF9fZ2VtX3F1ZXJ5KGZkLCBxKSwgMCk7Cj4gK30KPiArCj4gK3N0YXRpYyB2b2lk IHF1ZXJ5X2VuZ2luZXMoaW50IGZkLAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgc3RydWN0 IGRybV9pOTE1X3F1ZXJ5X2VuZ2luZV9pbmZvICpxdWVyeV9lbmdpbmVzKQo+ICt7Cj4gKyAgICAg ICBzdHJ1Y3QgZHJtX2k5MTVfcXVlcnlfaXRlbSBpdGVtID0geyB9Owo+ICsgICAgICAgc3RydWN0 IGRybV9pOTE1X3F1ZXJ5IHF1ZXJ5ID0geyB9Owo+ICsKPiArICAgICAgIGl0ZW0ucXVlcnlfaWQg PSBEUk1fSTkxNV9RVUVSWV9FTkdJTkVfSU5GTzsKPiArICAgICAgIHF1ZXJ5Lml0ZW1zX3B0ciA9 IHRvX3VzZXJfcG9pbnRlcigmaXRlbSk7Cj4gKyAgICAgICBxdWVyeS5udW1faXRlbXMgPSAxOwo+ ICsgICAgICAgaXRlbS5sZW5ndGggPSBTSVpFT0ZfUVVFUlk7Cj4gKwo+ICsgICAgICAgaXRlbS5k YXRhX3B0ciA9IHRvX3VzZXJfcG9pbnRlcihxdWVyeV9lbmdpbmVzKTsKPiArCj4gKyAgICAgICBn ZW1fcXVlcnkoZmQsICZxdWVyeSk7Cj4gK30KPiArCj4gK2Jvb2wgZ2VtX2hhc19lbmdpbmVfdG9w b2xvZ3kodm9pZCkKPiArewo+ICsgICAgICAgcmV0dXJuIGludGVsX2FjdGl2ZV9lbmdpbmVzMiAh PSBpbnRlbF9leGVjdXRpb25fZW5naW5lczI7Cj4gK30KPiArCj4gK3N0YXRpYyB2b2lkIHNldF9j dHhfcGFyYW1fZW5naW5lcyhpbnQgZmQsIHVpbnQzMl90IGN0eF9pZCkKPiArewo+ICsgICAgICAg c3RydWN0IGk5MTVfY29udGV4dF9wYXJhbV9lbmdpbmVzICpjdHhfZW5naW5lOwo+ICsgICAgICAg c3RydWN0IGRybV9pOTE1X2dlbV9jb250ZXh0X3BhcmFtIGN0eF9wYXJhbTsKPiArICAgICAgIGNv bnN0IHN0cnVjdCBpbnRlbF9leGVjdXRpb25fZW5naW5lMiAqZTI7Cj4gKyAgICAgICB1aW50OF90 IGJ1ZmZbU0laRU9GX0NUWF9QQVJBTV0gPSB7IH07Cj4gKyAgICAgICBpbnQgaTsKPiArCj4gKyAg ICAgICBpZiAoIWdlbV9oYXNfZW5naW5lX3RvcG9sb2d5KCkpCj4gKyAgICAgICAgICAgICAgIHJl dHVybjsKCldoeSB3b3VsZCBkaWZmZXJlbnQgZmQgaGF2ZSB0aGUgc2FtZSB0b3BvbG9neT8KLUNo cmlzCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmlndC1k ZXYgbWFpbGluZyBsaXN0CmlndC1kZXZAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaWd0LWRldg==