From: Chris Wilson <chris@chris-wilson.co.uk>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Populate pipe_offsets[] & co. accurately
Date: Wed, 06 Mar 2019 14:55:58 +0000 [thread overview]
Message-ID: <155188415795.27405.9852420736019446971@skylake-alporthouse-com> (raw)
In-Reply-To: <20190306145211.GE3888@intel.com>
Quoting Ville Syrjälä (2019-03-06 14:52:11)
> On Wed, Mar 06, 2019 at 09:31:48AM +0000, Chris Wilson wrote:
> > Quoting Ville Syrjala (2019-03-05 19:29:05)
> > > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > >
> > > At some point people have started to assume that
> > > pipe_offsets[] & co. are only populated for pipes and whatnot
> > > that actually exist. That is in fact not currently true, but
> > > we can easily make it so.
> >
> > Any benefits of knock on effect?
>
> What kind of knock on effect we're thinking?
Just wondering why people are eager to make the assumption that
non-existent pipes are not set. I presume its to make code neater.
i.e. why cater to their whims at all?
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-03-06 14:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-05 19:29 [PATCH] drm/i915: Populate pipe_offsets[] & co. accurately Ville Syrjala
2019-03-05 21:16 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-03-06 1:42 ` ✓ Fi.CI.IGT: " Patchwork
2019-03-06 9:31 ` [PATCH] " Chris Wilson
2019-03-06 14:52 ` Ville Syrjälä
2019-03-06 14:55 ` Chris Wilson [this message]
2019-03-06 15:13 ` Ville Syrjälä
2019-03-06 17:42 ` Lucas De Marchi
2019-03-06 17:55 ` Ville Syrjälä
2019-03-06 17:58 ` Ville Syrjälä
2019-03-06 18:01 ` Ville Syrjälä
2019-03-06 18:58 ` Lucas De Marchi
2019-03-06 18:55 ` Lucas De Marchi
2019-03-06 19:00 ` Ville Syrjälä
2019-03-06 20:25 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=155188415795.27405.9852420736019446971@skylake-alporthouse-com \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.