From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] i40evf: fix mac deletion when stop dev Date: Sun, 06 Dec 2015 22:34:01 +0100 Message-ID: <1552305.QY8GdKH3cv@xps13> References: <1448855649-24658-1-git-send-email-jingjing.wu@intel.com> <20151130083300.75ba06bc@xeon-e3> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Stephen Hemminger Return-path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id C5F5D936A for ; Sun, 6 Dec 2015 22:35:12 +0100 (CET) Received: by wmww144 with SMTP id w144so127387950wmw.0 for ; Sun, 06 Dec 2015 13:35:12 -0800 (PST) In-Reply-To: <20151130083300.75ba06bc@xeon-e3> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-11-30 08:33, Stephen Hemminger: > On Mon, 30 Nov 2015 11:54:09 +0800 > Jingjing Wu wrote: > > > + (void)rte_memcpy(mac_addr.addr_bytes, hw->mac.addr, > > + sizeof(mac_addr.addr_bytes)) > > Please don't add useless (void) cast. > I haven't seen that since lint on Unix. It is the style in i40e driver. It may deserve a general cleanup.