All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <swboyd@chromium.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Anton Vasilyev <vasilyev@ispras.ru>
Subject: Re: [PATCH] firmware: vpd: Drop __iomem usage for memremap() memory
Date: Mon, 18 Mar 2019 12:38:49 -0700	[thread overview]
Message-ID: <155293792998.20095.17902613055366994243@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20190318183636.GA31345@roeck-us.net>

Quoting Guenter Roeck (2019-03-18 11:36:36)
> On Mon, Mar 18, 2019 at 08:54:57AM -0700, Stephen Boyd wrote:
> > memremap() doesn't return an iomem pointer, so we can just use memcpy()
> > and drop the __iomem annotation here. This silences a sparse warning.
> > 
> > Cc: Guenter Roeck <linux@roeck-us.net>
> > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > Cc: Anton Vasilyev <vasilyev@ispras.ru>
> > Smgned-off-by: Stephen Boyd <swboyd@chromium.org>
> 
> Smgned ?

Hm, something went wrong!

> 
> Other than that,
> 
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>

Thanks. I'll resend with everything fixed.


      reply	other threads:[~2019-03-18 19:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-18 15:54 [PATCH] firmware: vpd: Drop __iomem usage for memremap() memory Stephen Boyd
2019-03-18 18:36 ` Guenter Roeck
2019-03-18 19:38   ` Stephen Boyd [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=155293792998.20095.17902613055366994243@swboyd.mtv.corp.google.com \
    --to=swboyd@chromium.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=vasilyev@ispras.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.