From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCA2CC10F00 for ; Mon, 18 Mar 2019 20:21:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A05A620850 for ; Mon, 18 Mar 2019 20:21:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1552940492; bh=NQLOYggsPXkWqj3UsTopKS4lKB8iUyd7s/a8ypYs0wM=; h=In-Reply-To:References:From:Subject:Cc:To:Date:List-ID:From; b=HzJAplwvd8AG2l9lEdnrD8HubgSTLT+2tkWK62J+FdtsDPWmHsqe0F9SO31n4qrc1 cEbQJafiKwnmfPT/SIIJa4Wcs3bkDuXbcLvSgfq/AroFS32Ii761Taz//hspfcugXE LNPgtzhCDV4nweCrDw1QQaSpuGmdYHs0XQE+1McM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727568AbfCRUVb (ORCPT ); Mon, 18 Mar 2019 16:21:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:48878 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726959AbfCRUVb (ORCPT ); Mon, 18 Mar 2019 16:21:31 -0400 Received: from localhost (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5BC7B20828; Mon, 18 Mar 2019 20:21:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1552940490; bh=NQLOYggsPXkWqj3UsTopKS4lKB8iUyd7s/a8ypYs0wM=; h=In-Reply-To:References:From:Subject:Cc:To:Date:From; b=SufvF/IsUztt/+hqtcuryfnMKdupBNtR+FL5keTM3ma19HgKkeQnf1wN6t7loLZOU 8PrLmrj7DkX1IS0fD7xnUcxzU2BYv3cPDIdovqQmLuobtYzCAmv1BcWCuzmVw8yYQA wkM1Ud6/2OeIj592Z6QDFVl+Ak94QU20ZhtN9DYg= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <1552937931-23050-7-git-send-email-peter.griffin@linaro.org> References: <1552937931-23050-1-git-send-email-peter.griffin@linaro.org> <1552937931-23050-7-git-send-email-peter.griffin@linaro.org> From: Stephen Boyd Subject: Re: [PATCH v1 6/6] clk: hi6220: use CLK_OF_DECLARE_DRIVER Cc: john.stultz@linaro.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, yuq825@gmail.com To: Peter Griffin , airlied@linux.ie, daniel@ffwll.ch, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, mark.rutland@arm.com, mturquette@baylibre.com, p.zabel@pengutronix.de, robh+dt@kernel.org, xuwei5@hisilicon.com Message-ID: <155294048956.20095.14072308972262767231@swboyd.mtv.corp.google.com> User-Agent: alot/0.8 Date: Mon, 18 Mar 2019 13:21:29 -0700 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Peter Griffin (2019-03-18 12:38:51) > As now we also need to probe in the reset driver as well. >=20 > Signed-off-by: Peter Griffin > --- > drivers/clk/hisilicon/clk-hi6220.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Doesn't this need to be squashed with the reset driver bits so we don't have a bisection hole? >=20 > diff --git a/drivers/clk/hisilicon/clk-hi6220.c b/drivers/clk/hisilicon/c= lk-hi6220.c > index a87809d..952ffe2 100644 > --- a/drivers/clk/hisilicon/clk-hi6220.c > +++ b/drivers/clk/hisilicon/clk-hi6220.c > @@ -89,7 +89,7 @@ static void __init hi6220_clk_ao_init(struct device_nod= e *np) > hisi_clk_register_gate_sep(hi6220_separated_gate_clks_ao, > ARRAY_SIZE(hi6220_separated_gate_clks_ao)= , clk_data_ao); > } > -CLK_OF_DECLARE(hi6220_clk_ao, "hisilicon,hi6220-aoctrl", hi6220_clk_ao_i= nit); > +CLK_OF_DECLARE_DRIVER(hi6220_clk_ao, "hisilicon,hi6220-aoctrl", hi6220_c= lk_ao_init); Can you also add a comment indicating why/what is the other driver that is probing the same device node? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73960C43381 for ; Mon, 18 Mar 2019 20:21:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4014520850 for ; Mon, 18 Mar 2019 20:21:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ESzXNHM2"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="SufvF/Is" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4014520850 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Date:Message-ID:To:Subject:From: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=h9RJW4V+si8AmIEP6n4oGS7QZQ9ACBGmvcrY4nJ0EKk=; b=ESzXNHM2XqLVj8 zl9+8+j3YzEk99wwz1DwLKWfGp75XWHklH3wMdLo0+/Vio8Keb2K3OkEc68G7QROYc3M8J/Rl40NC DUCa+nHUD6eBRUIGK+EXqrnVZMmvb4l6wKfJ/ACZ6huIex3tm5RNd6cGTaFcm9UsuemKX8qYD86SG ESNT0zxoi+8BRw3Moj94GWspxcweCTiIoKzB4aIMmSeJEpxMYwOKY+Gt2lSSAnouWQ2OP1r4CUXd/ m6yPEWNeYTzjqjR5cY6VzO1hetwSENs+M5hSMyLDQ2sGYSFf90qzYWnAePnRksh8kef7NH1OTOwZ1 7H+90KpJwbtLijoc4CNw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h5ylK-0007h2-PM; Mon, 18 Mar 2019 20:21:34 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h5ylH-0007gd-4H for linux-arm-kernel@lists.infradead.org; Mon, 18 Mar 2019 20:21:32 +0000 Received: from localhost (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5BC7B20828; Mon, 18 Mar 2019 20:21:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1552940490; bh=NQLOYggsPXkWqj3UsTopKS4lKB8iUyd7s/a8ypYs0wM=; h=In-Reply-To:References:From:Subject:Cc:To:Date:From; b=SufvF/IsUztt/+hqtcuryfnMKdupBNtR+FL5keTM3ma19HgKkeQnf1wN6t7loLZOU 8PrLmrj7DkX1IS0fD7xnUcxzU2BYv3cPDIdovqQmLuobtYzCAmv1BcWCuzmVw8yYQA wkM1Ud6/2OeIj592Z6QDFVl+Ak94QU20ZhtN9DYg= MIME-Version: 1.0 In-Reply-To: <1552937931-23050-7-git-send-email-peter.griffin@linaro.org> References: <1552937931-23050-1-git-send-email-peter.griffin@linaro.org> <1552937931-23050-7-git-send-email-peter.griffin@linaro.org> From: Stephen Boyd Subject: Re: [PATCH v1 6/6] clk: hi6220: use CLK_OF_DECLARE_DRIVER To: Peter Griffin , airlied@linux.ie, daniel@ffwll.ch, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, mark.rutland@arm.com, mturquette@baylibre.com, p.zabel@pengutronix.de, robh+dt@kernel.org, xuwei5@hisilicon.com Message-ID: <155294048956.20095.14072308972262767231@swboyd.mtv.corp.google.com> User-Agent: alot/0.8 Date: Mon, 18 Mar 2019 13:21:29 -0700 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190318_132131_200271_B80A4AEF X-CRM114-Status: GOOD ( 13.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, john.stultz@linaro.org, linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org, yuq825@gmail.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Peter Griffin (2019-03-18 12:38:51) > As now we also need to probe in the reset driver as well. > > Signed-off-by: Peter Griffin > --- > drivers/clk/hisilicon/clk-hi6220.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Doesn't this need to be squashed with the reset driver bits so we don't have a bisection hole? > > diff --git a/drivers/clk/hisilicon/clk-hi6220.c b/drivers/clk/hisilicon/clk-hi6220.c > index a87809d..952ffe2 100644 > --- a/drivers/clk/hisilicon/clk-hi6220.c > +++ b/drivers/clk/hisilicon/clk-hi6220.c > @@ -89,7 +89,7 @@ static void __init hi6220_clk_ao_init(struct device_node *np) > hisi_clk_register_gate_sep(hi6220_separated_gate_clks_ao, > ARRAY_SIZE(hi6220_separated_gate_clks_ao), clk_data_ao); > } > -CLK_OF_DECLARE(hi6220_clk_ao, "hisilicon,hi6220-aoctrl", hi6220_clk_ao_init); > +CLK_OF_DECLARE_DRIVER(hi6220_clk_ao, "hisilicon,hi6220-aoctrl", hi6220_clk_ao_init); Can you also add a comment indicating why/what is the other driver that is probing the same device node? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel