From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9558FC43381 for ; Tue, 19 Mar 2019 11:46:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6A7A1213F2 for ; Tue, 19 Mar 2019 11:46:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727668AbfCSLqP (ORCPT ); Tue, 19 Mar 2019 07:46:15 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:42063 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726349AbfCSLqO (ORCPT ); Tue, 19 Mar 2019 07:46:14 -0400 Received: from kresse.hi.pengutronix.de ([2001:67c:670:100:1d::2a]) by metis.ext.pengutronix.de with esmtp (Exim 4.89) (envelope-from ) id 1h6DBz-0006Zr-Bv; Tue, 19 Mar 2019 12:46:03 +0100 Message-ID: <1552995960.4806.5.camel@pengutronix.de> Subject: Re: [PATCH v2] arm64: dts: fsl: imx8mq: enable the multi sensor TMU From: Lucas Stach To: "Angus Ainslie (Purism)" , andrew.smirnov@gmail.com Cc: Rob Herring , Mark Rutland , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Carlo Caione , Abel Vesa , Baruch Siach , Guido =?ISO-8859-1?Q?G=FCnther?= , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Tue, 19 Mar 2019 12:46:00 +0100 In-Reply-To: <20190318184643.24025-1-angus@akkea.ca> References: <20190311213124.29325-1-angus@akkea.ca> <20190318184643.24025-1-angus@akkea.ca> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::2a X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Angus, Am Montag, den 18.03.2019, 11:46 -0700 schrieb Angus Ainslie (Purism): > Add the imx8mq TMU (Thermal mannagement unit) nodes for CPU, > GPU, and VPU. > > Changes since v1: > > Removed references to multi sensor patch. > > Signed-off-by: Angus Ainslie (Purism) > --- >  arch/arm64/boot/dts/freescale/imx8mq.dtsi | 118 ++++++++++++++++++++++ >  1 file changed, 118 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > index 9155bd4784eb..885395e74452 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi [...] > + thermal-zones { > + cpu-thermal { > + polling-delay-passive = <250>; > + polling-delay = <2000>; > + thermal-sensors = <&tmu 0>; > + > + trips { > + cpu_alert: cpu-alert { > + temperature = <85000>; > + hysteresis = <2000>; > + type = "passive"; > + }; > + > + cpu_crit { > + temperature = <95000>; All the critical trip points seem to be too high. The consumer parts have a maximum junction temperature of 95°C, so the common DT configuration used by all boards should have a crit trip point at least a few degrees below this value. Boards that only use the industrial parts can always overwrite the trip points if the designer wishes to do so. > + hysteresis = <2000>; > + type = "critical"; > + }; > + }; > + > + cooling-maps { > + map0 { > + trip = <&cpu_alert>; > + cooling-device = > + <&A53_0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&A53_1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&A53_2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > + <&A53_3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > + }; > + }; > + }; > + > + gpu-thermal { > + polling-delay-passive = <250>; > + polling-delay = <2000>; > + thermal-sensors = <&tmu 1>; > + > + trips { > + cpu-crit { Should be gpu-crit. > + temperature = <95000>; > + hysteresis = <2000>; > + type = "critical"; > + }; > + }; > + }; > + > + vpu-thermal { > + polling-delay-passive = <250>; > + polling-delay = <2000>; > + thermal-sensors = <&tmu 2>; > + > + trips { > + cpu-crit { Should be vpu-crit. Regards, Lucas From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA803C43381 for ; Tue, 19 Mar 2019 11:46:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 986D320857 for ; Tue, 19 Mar 2019 11:46:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="C7lAtnsf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 986D320857 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QeZjhOWdTHUv02T6h8E7DMieE/s7tIjjObMiCUkUWA4=; b=C7lAtnsfa2evVP k7hFLHiVfBbdgdpGL3mtMXAj0k7pJchj3Voz5eB7wzcTOI0WK+on9WtziR3hgJRtxyUOK+UX5NwaK Me1kb/UBQAoQhsS98G/P9B/+R6xwucokGOOFi/SZAfuoclZMgZcoxLlfW/I6+aY3ahRsdT1PoaONG 0TulskiTSy3c/NtSwy9w05slrSOQ3TG2VxQS+WnwPi3ktPw3UquwTDglvDArXgQnygo7tmqeXKLHp HxycPzej/koiTWauCIfTda0T/1GEzld/d9cC7FUfY+2B08QZ4wWDL4GRKEJIlTPluxWT1VXU8phU0 WxWYhFfSyCmpmKVWFtwg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h6DCJ-00040A-V2; Tue, 19 Mar 2019 11:46:23 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h6DCA-0003he-V4 for linux-arm-kernel@lists.infradead.org; Tue, 19 Mar 2019 11:46:17 +0000 Received: from kresse.hi.pengutronix.de ([2001:67c:670:100:1d::2a]) by metis.ext.pengutronix.de with esmtp (Exim 4.89) (envelope-from ) id 1h6DBz-0006Zr-Bv; Tue, 19 Mar 2019 12:46:03 +0100 Message-ID: <1552995960.4806.5.camel@pengutronix.de> Subject: Re: [PATCH v2] arm64: dts: fsl: imx8mq: enable the multi sensor TMU From: Lucas Stach To: "Angus Ainslie (Purism)" , andrew.smirnov@gmail.com Date: Tue, 19 Mar 2019 12:46:00 +0100 In-Reply-To: <20190318184643.24025-1-angus@akkea.ca> References: <20190311213124.29325-1-angus@akkea.ca> <20190318184643.24025-1-angus@akkea.ca> X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::2a X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190319_044615_220675_A8ECACE9 X-CRM114-Status: GOOD ( 14.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Baruch Siach , Abel Vesa , Carlo Caione , Shawn Guo , Sascha Hauer , linux-kernel@vger.kernel.org, Rob Herring , NXP Linux Team , Pengutronix Kernel Team , Fabio Estevam , Guido =?ISO-8859-1?Q?G=FCnther?= , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgQW5ndXMsCgpBbSBNb250YWcsIGRlbiAxOC4wMy4yMDE5LCAxMTo0NiAtMDcwMCBzY2hyaWVi IEFuZ3VzIEFpbnNsaWUgKFB1cmlzbSk6Cj4gQWRkIHRoZSBpbXg4bXEgVE1VIChUaGVybWFsIG1h bm5hZ2VtZW50IHVuaXQpIG5vZGVzIGZvciBDUFUsCj4gR1BVLCBhbmQgVlBVLgo+IAo+IENoYW5n ZXMgc2luY2UgdjE6Cj4gCj4gUmVtb3ZlZCByZWZlcmVuY2VzIHRvIG11bHRpIHNlbnNvciBwYXRj aC4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBBbmd1cyBBaW5zbGllIChQdXJpc20pIDxhbmd1c0Bha2tl YS5jYT4KPiAtLS0KPiDCoGFyY2gvYXJtNjQvYm9vdC9kdHMvZnJlZXNjYWxlL2lteDhtcS5kdHNp IHwgMTE4ICsrKysrKysrKysrKysrKysrKysrKysKPiDCoDEgZmlsZSBjaGFuZ2VkLCAxMTggaW5z ZXJ0aW9ucygrKQo+IAo+IGRpZmYgLS1naXQgYS9hcmNoL2FybTY0L2Jvb3QvZHRzL2ZyZWVzY2Fs ZS9pbXg4bXEuZHRzaSBiL2FyY2gvYXJtNjQvYm9vdC9kdHMvZnJlZXNjYWxlL2lteDhtcS5kdHNp Cj4gaW5kZXggOTE1NWJkNDc4NGViLi44ODUzOTVlNzQ0NTIgMTAwNjQ0Cj4gLS0tIGEvYXJjaC9h cm02NC9ib290L2R0cy9mcmVlc2NhbGUvaW14OG1xLmR0c2kKPiArKysgYi9hcmNoL2FybTY0L2Jv b3QvZHRzL2ZyZWVzY2FsZS9pbXg4bXEuZHRzaQoKWy4uLl0KCj4gKwkJCXRoZXJtYWwtem9uZXMg ewo+ICsJCQkJY3B1LXRoZXJtYWwgewo+ICsJCQkJCXBvbGxpbmctZGVsYXktcGFzc2l2ZSA9IDwy NTA+Owo+ICsJCQkJCXBvbGxpbmctZGVsYXkgPSA8MjAwMD47Cj4gKwkJCQkJdGhlcm1hbC1zZW5z b3JzID0gPCZ0bXUgMD47Cj4gKwo+ICsJCQkJCXRyaXBzIHsKPiArCQkJCQkJY3B1X2FsZXJ0OiBj cHUtYWxlcnQgewo+ICsJCQkJCQkJdGVtcGVyYXR1cmUgPSA8ODUwMDA+Owo+ICsJCQkJCQkJaHlz dGVyZXNpcyA9IDwyMDAwPjsKPiArCQkJCQkJCXR5cGUgPSAicGFzc2l2ZSI7Cj4gKwkJCQkJCX07 Cj4gKwo+ICsJCQkJCQljcHVfY3JpdCB7Cj4gKwkJCQkJCQl0ZW1wZXJhdHVyZSA9IDw5NTAwMD47 CgpBbGwgdGhlIGNyaXRpY2FsIHRyaXAgcG9pbnRzIHNlZW0gdG8gYmUgdG9vIGhpZ2guIFRoZSBj b25zdW1lciBwYXJ0cwpoYXZlIGEgbWF4aW11bSBqdW5jdGlvbiB0ZW1wZXJhdHVyZSBvZiA5NcKw Qywgc28gdGhlIGNvbW1vbiBEVApjb25maWd1cmF0aW9uIHVzZWQgYnkgYWxsIGJvYXJkcyBzaG91 bGQgaGF2ZSBhIGNyaXQgdHJpcCBwb2ludCBhdCBsZWFzdAphIGZldyBkZWdyZWVzIGJlbG93IHRo aXMgdmFsdWUuIEJvYXJkcyB0aGF0IG9ubHkgdXNlIHRoZSBpbmR1c3RyaWFsCnBhcnRzIGNhbiBh bHdheXMgb3ZlcndyaXRlIHRoZSB0cmlwIHBvaW50cyBpZiB0aGUgZGVzaWduZXIgd2lzaGVzIHRv IGRvCnNvLgoKPiArCQkJCQkJCWh5c3RlcmVzaXMgPSA8MjAwMD47Cj4gKwkJCQkJCQl0eXBlID0g ImNyaXRpY2FsIjsKPiArCQkJCQkJfTsKPiArCQkJCQl9Owo+ICsKPiArCQkJCQljb29saW5nLW1h cHMgewo+ICsJCQkJCQltYXAwIHsKPiArCQkJCQkJCXRyaXAgPSA8JmNwdV9hbGVydD47Cj4gKwkJ CQkJCQljb29saW5nLWRldmljZSA9Cj4gKwkJCQkJCQkJPCZBNTNfMCBUSEVSTUFMX05PX0xJTUlU IFRIRVJNQUxfTk9fTElNSVQ+LAo+ICsJCQkJCQkJCTwmQTUzXzEgVEhFUk1BTF9OT19MSU1JVCBU SEVSTUFMX05PX0xJTUlUPiwKPiArCQkJCQkJCQk8JkE1M18yIFRIRVJNQUxfTk9fTElNSVQgVEhF Uk1BTF9OT19MSU1JVD4sCj4gKwkJCQkJCQkJPCZBNTNfMyBUSEVSTUFMX05PX0xJTUlUIFRIRVJN QUxfTk9fTElNSVQ+Owo+ICsJCQkJCQl9Owo+ICsJCQkJCX07Cj4gKwkJCQl9Owo+ICsKPiArCQkJ CWdwdS10aGVybWFsIHsKPiArCQkJCQlwb2xsaW5nLWRlbGF5LXBhc3NpdmUgPSA8MjUwPjsKPiAr CQkJCQlwb2xsaW5nLWRlbGF5ID0gPDIwMDA+Owo+ICsJCQkJCXRoZXJtYWwtc2Vuc29ycyA9IDwm dG11IDE+Owo+ICsKPiArCQkJCQl0cmlwcyB7Cj4gKwkJCQkJCWNwdS1jcml0IHsKClNob3VsZCBi ZSBncHUtY3JpdC4KCj4gKwkJCQkJCQl0ZW1wZXJhdHVyZSA9IDw5NTAwMD47Cj4gKwkJCQkJCQlo eXN0ZXJlc2lzID0gPDIwMDA+Owo+ICsJCQkJCQkJdHlwZSA9ICJjcml0aWNhbCI7Cj4gKwkJCQkJ CX07Cj4gKwkJCQkJfTsKPiArCQkJCX07Cj4gKwo+ICsJCQkJdnB1LXRoZXJtYWwgewo+ICsJCQkJ CXBvbGxpbmctZGVsYXktcGFzc2l2ZSA9IDwyNTA+Owo+ICsJCQkJCXBvbGxpbmctZGVsYXkgPSA8 MjAwMD47Cj4gKwkJCQkJdGhlcm1hbC1zZW5zb3JzID0gPCZ0bXUgMj47Cj4gKwo+ICsJCQkJCXRy aXBzIHsKPiArCQkJCQkJY3B1LWNyaXQgewoKU2hvdWxkIGJlIHZwdS1jcml0LgoKUmVnYXJkcywK THVjYXMKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxp bnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFk ZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4 LWFybS1rZXJuZWwK