From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2507CC43381 for ; Wed, 20 Mar 2019 06:48:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ED6262184D for ; Wed, 20 Mar 2019 06:48:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727362AbfCTGsP (ORCPT ); Wed, 20 Mar 2019 02:48:15 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:24802 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726169AbfCTGsP (ORCPT ); Wed, 20 Mar 2019 02:48:15 -0400 X-UUID: 7e1cab0520674881afbe688c90c5af3b-20190320 X-UUID: 7e1cab0520674881afbe688c90c5af3b-20190320 Received: from mtkcas06.mediatek.inc [(172.21.101.30)] by mailgw02.mediatek.com (envelope-from ) (mhqrelay.mediatek.com ESMTP with TLS) with ESMTP id 909345915; Wed, 20 Mar 2019 14:47:59 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs05n1.mediatek.inc (172.21.101.15) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 20 Mar 2019 14:47:57 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Wed, 20 Mar 2019 14:47:57 +0800 Message-ID: <1553064478.28297.3.camel@mtksdaap41> Subject: Re: [PATCH] gpu/drm: mediatek: call mtk_dsi_stop() after mtk_drm_crtc_atomic_disable() From: CK Hu To: Hsin-Yi Wang CC: , Philipp Zabel , David Airlie , Daniel Vetter , Matthias Brugger , , , Date: Wed, 20 Mar 2019 14:47:58 +0800 In-Reply-To: References: <20190318040915.101218-1-hsinyi@chromium.org> <1553051356.20221.23.camel@mtksdaap41> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Hsin-yi: On Wed, 2019-03-20 at 13:39 +0800, Hsin-Yi Wang wrote: > On Wed, Mar 20, 2019 at 11:09 AM CK Hu wrote: > > > > Hi, Hsin-yi: > > > > On Mon, 2019-03-18 at 12:09 +0800, Hsin-Yi Wang wrote: > > > mtk_dsi_stop() should be called after mtk_drm_crtc_atomic_disable(), which needs > > > ovl irq for drm_crtc_wait_one_vblank(), since after mtk_dsi_stop() is called, > > > ovl irq will be disabled. If drm_crtc_wait_one_vblank() is called after last > > > irq, it will timeout with this message: "vblank wait timed out on crtc 0". This > > > happens sometimes when turning off the screen. > > > > > > In drm_atomic_helper.c#disable_outputs(), > > > the calling sequence when turning off the screen is: > > > > > > 1. mtk_dsi_encoder_disable() > > > --> mtk_output_dsi_disable() > > > --> mtk_dsi_stop(); // sometimes make vblank timeout in atomic_disable > > > --> mtk_dsi_poweroff(); > > > 2. mtk_drm_crtc_atomic_disable() > > > --> drm_crtc_wait_one_vblank(); > > > ... > > > --> mtk_dsi_ddp_stop() > > > --> mtk_dsi_poweroff(); > > > > > > > Thanks for your inference, but I wonder this patch meet all > > consideration. In MT8173 with a bridge chip, the timing to disable dsi > > signal output would influence bridge chip output garbage or not. It's > > better that you could test this on MT8173, or let this patch go for > > weeks and wait for someone to test. If no one care about MT8173, I could > > accept this patch. > We care about MT8173, but it's not easy to test since we have to bring > the whole kernel to >= 4.19 to be able to test latest dsi driver. > The patch (0707632b5bac) that added mtk_dsi_stop() was after MT8173 > (on 3.18), for panel without bridge, so I think without mtk_dsi_stop() > was also working fine for MT8173. OK, I find that in the first version of this driver, there is no mtk_dsi_stop() before mtk_dsi_poweroff(), so I think MT8173 does not do mtk_dsi_stop(). So maybe this works fine for MT8173. Regards, CK > > > > > > Change to make mtk_dsi_stop() called in mtk_dsi_ddp_stop() instead of > > > mtk_output_dsi_disable(). > > > > mtk_dsi_poweroff() has reference count, why not just move mtk_dsi_stop() > > into mtk_dsi_poweroff()? > Yes, we can also call mtk_dsi_stop() in mtk_dsi_poweroff() when > refcount is 0. I can send v2 if you think this way is better. > > Thanks > > > > Regards, > > CK > > > > > > > > Fixes: 0707632b5bac ("drm/mediatek: update DSI sub driver flow for sending commands to panel") > > > Signed-off-by: Hsin-Yi Wang > > > --- > > > drivers/gpu/drm/mediatek/mtk_dsi.c | 4 +++- > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c > > > index b00eb2d2e086..cdd9637dd517 100644 > > > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c > > > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c > > > @@ -696,7 +696,6 @@ static void mtk_output_dsi_disable(struct mtk_dsi *dsi) > > > } > > > } > > > > > > - mtk_dsi_stop(dsi); > > > mtk_dsi_poweroff(dsi); > > > > > > dsi->enabled = false; > > > @@ -857,6 +856,7 @@ static void mtk_dsi_ddp_stop(struct mtk_ddp_comp *comp) > > > { > > > struct mtk_dsi *dsi = container_of(comp, struct mtk_dsi, ddp_comp); > > > > > > + mtk_dsi_stop(dsi); > > > mtk_dsi_poweroff(dsi); > > > } > > > > > > @@ -1178,6 +1178,8 @@ static int mtk_dsi_remove(struct platform_device *pdev) > > > struct mtk_dsi *dsi = platform_get_drvdata(pdev); > > > > > > mtk_output_dsi_disable(dsi); > > > + mtk_dsi_stop(dsi); > > > + mtk_dsi_poweroff(dsi); > > > component_del(&pdev->dev, &mtk_dsi_component_ops); > > > > > > return 0; > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: CK Hu Subject: Re: [PATCH] gpu/drm: mediatek: call mtk_dsi_stop() after mtk_drm_crtc_atomic_disable() Date: Wed, 20 Mar 2019 14:47:58 +0800 Message-ID: <1553064478.28297.3.camel@mtksdaap41> References: <20190318040915.101218-1-hsinyi@chromium.org> <1553051356.20221.23.camel@mtksdaap41> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Hsin-Yi Wang Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org List-Id: linux-mediatek@lists.infradead.org SGksIEhzaW4teWk6CgpPbiBXZWQsIDIwMTktMDMtMjAgYXQgMTM6MzkgKzA4MDAsIEhzaW4tWWkg V2FuZyB3cm90ZToKPiBPbiBXZWQsIE1hciAyMCwgMjAxOSBhdCAxMTowOSBBTSBDSyBIdSA8Y2su aHVAbWVkaWF0ZWsuY29tPiB3cm90ZToKPiA+Cj4gPiBIaSwgSHNpbi15aToKPiA+Cj4gPiBPbiBN b24sIDIwMTktMDMtMTggYXQgMTI6MDkgKzA4MDAsIEhzaW4tWWkgV2FuZyB3cm90ZToKPiA+ID4g bXRrX2RzaV9zdG9wKCkgc2hvdWxkIGJlIGNhbGxlZCBhZnRlciBtdGtfZHJtX2NydGNfYXRvbWlj X2Rpc2FibGUoKSwgd2hpY2ggbmVlZHMKPiA+ID4gb3ZsIGlycSBmb3IgZHJtX2NydGNfd2FpdF9v bmVfdmJsYW5rKCksIHNpbmNlIGFmdGVyIG10a19kc2lfc3RvcCgpIGlzIGNhbGxlZCwKPiA+ID4g b3ZsIGlycSB3aWxsIGJlIGRpc2FibGVkLiBJZiBkcm1fY3J0Y193YWl0X29uZV92YmxhbmsoKSBp cyBjYWxsZWQgYWZ0ZXIgbGFzdAo+ID4gPiBpcnEsIGl0IHdpbGwgdGltZW91dCB3aXRoIHRoaXMg bWVzc2FnZTogInZibGFuayB3YWl0IHRpbWVkIG91dCBvbiBjcnRjIDAiLiBUaGlzCj4gPiA+IGhh cHBlbnMgc29tZXRpbWVzIHdoZW4gdHVybmluZyBvZmYgdGhlIHNjcmVlbi4KPiA+ID4KPiA+ID4g SW4gZHJtX2F0b21pY19oZWxwZXIuYyNkaXNhYmxlX291dHB1dHMoKSwKPiA+ID4gdGhlIGNhbGxp bmcgc2VxdWVuY2Ugd2hlbiB0dXJuaW5nIG9mZiB0aGUgc2NyZWVuIGlzOgo+ID4gPgo+ID4gPiAx LiBtdGtfZHNpX2VuY29kZXJfZGlzYWJsZSgpCj4gPiA+ICAgICAgLS0+IG10a19vdXRwdXRfZHNp X2Rpc2FibGUoKQo+ID4gPiAgICAgICAgLS0+IG10a19kc2lfc3RvcCgpOyAgLy8gc29tZXRpbWVz IG1ha2UgdmJsYW5rIHRpbWVvdXQgaW4gYXRvbWljX2Rpc2FibGUKPiA+ID4gICAgICAgICAgLS0+ IG10a19kc2lfcG93ZXJvZmYoKTsKPiA+ID4gMi4gbXRrX2RybV9jcnRjX2F0b21pY19kaXNhYmxl KCkKPiA+ID4gICAgICAtLT4gZHJtX2NydGNfd2FpdF9vbmVfdmJsYW5rKCk7Cj4gPiA+ICAgICAg Li4uCj4gPiA+ICAgICAgICAtLT4gbXRrX2RzaV9kZHBfc3RvcCgpCj4gPiA+ICAgICAgICAgIC0t PiBtdGtfZHNpX3Bvd2Vyb2ZmKCk7Cj4gPiA+Cj4gPgo+ID4gVGhhbmtzIGZvciB5b3VyIGluZmVy ZW5jZSwgYnV0IEkgd29uZGVyIHRoaXMgcGF0Y2ggbWVldCBhbGwKPiA+IGNvbnNpZGVyYXRpb24u IEluIE1UODE3MyB3aXRoIGEgYnJpZGdlIGNoaXAsIHRoZSB0aW1pbmcgdG8gZGlzYWJsZSBkc2kK PiA+IHNpZ25hbCBvdXRwdXQgd291bGQgaW5mbHVlbmNlIGJyaWRnZSBjaGlwIG91dHB1dCBnYXJi YWdlIG9yIG5vdC4gSXQncwo+ID4gYmV0dGVyIHRoYXQgeW91IGNvdWxkIHRlc3QgdGhpcyBvbiBN VDgxNzMsIG9yIGxldCB0aGlzIHBhdGNoIGdvIGZvcgo+ID4gd2Vla3MgYW5kIHdhaXQgZm9yIHNv bWVvbmUgdG8gdGVzdC4gSWYgbm8gb25lIGNhcmUgYWJvdXQgTVQ4MTczLCBJIGNvdWxkCj4gPiBh Y2NlcHQgdGhpcyBwYXRjaC4KPiBXZSBjYXJlIGFib3V0IE1UODE3MywgYnV0IGl0J3Mgbm90IGVh c3kgdG8gdGVzdCBzaW5jZSB3ZSBoYXZlIHRvIGJyaW5nCj4gdGhlIHdob2xlIGtlcm5lbCB0byA+ PSA0LjE5IHRvIGJlIGFibGUgdG8gdGVzdCBsYXRlc3QgZHNpIGRyaXZlci4KPiBUaGUgcGF0Y2gg KDA3MDc2MzJiNWJhYykgdGhhdCBhZGRlZCBtdGtfZHNpX3N0b3AoKSB3YXMgYWZ0ZXIgTVQ4MTcz Cj4gKG9uIDMuMTgpLCBmb3IgcGFuZWwgd2l0aG91dCBicmlkZ2UsIHNvIEkgdGhpbmsgd2l0aG91 dCBtdGtfZHNpX3N0b3AoKQo+IHdhcyBhbHNvIHdvcmtpbmcgZmluZSBmb3IgTVQ4MTczLgoKT0ss IEkgZmluZCB0aGF0IGluIHRoZSBmaXJzdCB2ZXJzaW9uIG9mIHRoaXMgZHJpdmVyLCB0aGVyZSBp cyBubwptdGtfZHNpX3N0b3AoKSBiZWZvcmUgbXRrX2RzaV9wb3dlcm9mZigpLCBzbyBJIHRoaW5r IE1UODE3MyBkb2VzIG5vdCBkbwptdGtfZHNpX3N0b3AoKS4gU28gbWF5YmUgdGhpcyB3b3JrcyBm aW5lIGZvciBNVDgxNzMuCgpSZWdhcmRzLApDSwoKPiAKPiA+Cj4gPiA+IENoYW5nZSB0byBtYWtl IG10a19kc2lfc3RvcCgpIGNhbGxlZCBpbiBtdGtfZHNpX2RkcF9zdG9wKCkgaW5zdGVhZCBvZgo+ ID4gPiBtdGtfb3V0cHV0X2RzaV9kaXNhYmxlKCkuCj4gPgo+ID4gbXRrX2RzaV9wb3dlcm9mZigp IGhhcyByZWZlcmVuY2UgY291bnQsIHdoeSBub3QganVzdCBtb3ZlIG10a19kc2lfc3RvcCgpCj4g PiBpbnRvIG10a19kc2lfcG93ZXJvZmYoKT8KPiBZZXMsIHdlIGNhbiBhbHNvIGNhbGwgbXRrX2Rz aV9zdG9wKCkgaW4gbXRrX2RzaV9wb3dlcm9mZigpIHdoZW4KPiByZWZjb3VudCBpcyAwLiBJIGNh biBzZW5kIHYyIGlmIHlvdSB0aGluayB0aGlzIHdheSBpcyBiZXR0ZXIuCj4gCj4gVGhhbmtzCj4g Pgo+ID4gUmVnYXJkcywKPiA+IENLCj4gPgo+ID4gPgo+ID4gPiBGaXhlczogMDcwNzYzMmI1YmFj ICgiZHJtL21lZGlhdGVrOiB1cGRhdGUgRFNJIHN1YiBkcml2ZXIgZmxvdyBmb3Igc2VuZGluZyBj b21tYW5kcyB0byBwYW5lbCIpCj4gPiA+IFNpZ25lZC1vZmYtYnk6IEhzaW4tWWkgV2FuZyA8aHNp bnlpQGNocm9taXVtLm9yZz4KPiA+ID4gLS0tCj4gPiA+ICBkcml2ZXJzL2dwdS9kcm0vbWVkaWF0 ZWsvbXRrX2RzaS5jIHwgNCArKystCj4gPiA+ICAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25z KCspLCAxIGRlbGV0aW9uKC0pCj4gPiA+Cj4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vbWVkaWF0ZWsvbXRrX2RzaS5jIGIvZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kc2ku Ywo+ID4gPiBpbmRleCBiMDBlYjJkMmUwODYuLmNkZDk2MzdkZDUxNyAxMDA2NDQKPiA+ID4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kc2kuYwo+ID4gPiArKysgYi9kcml2ZXJz L2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RzaS5jCj4gPiA+IEBAIC02OTYsNyArNjk2LDYgQEAgc3Rh dGljIHZvaWQgbXRrX291dHB1dF9kc2lfZGlzYWJsZShzdHJ1Y3QgbXRrX2RzaSAqZHNpKQo+ID4g PiAgICAgICAgICAgICAgIH0KPiA+ID4gICAgICAgfQo+ID4gPgo+ID4gPiAtICAgICBtdGtfZHNp X3N0b3AoZHNpKTsKPiA+ID4gICAgICAgbXRrX2RzaV9wb3dlcm9mZihkc2kpOwo+ID4gPgo+ID4g PiAgICAgICBkc2ktPmVuYWJsZWQgPSBmYWxzZTsKPiA+ID4gQEAgLTg1Nyw2ICs4NTYsNyBAQCBz dGF0aWMgdm9pZCBtdGtfZHNpX2RkcF9zdG9wKHN0cnVjdCBtdGtfZGRwX2NvbXAgKmNvbXApCj4g PiA+ICB7Cj4gPiA+ICAgICAgIHN0cnVjdCBtdGtfZHNpICpkc2kgPSBjb250YWluZXJfb2YoY29t cCwgc3RydWN0IG10a19kc2ksIGRkcF9jb21wKTsKPiA+ID4KPiA+ID4gKyAgICAgbXRrX2RzaV9z dG9wKGRzaSk7Cj4gPiA+ICAgICAgIG10a19kc2lfcG93ZXJvZmYoZHNpKTsKPiA+ID4gIH0KPiA+ ID4KPiA+ID4gQEAgLTExNzgsNiArMTE3OCw4IEBAIHN0YXRpYyBpbnQgbXRrX2RzaV9yZW1vdmUo c3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPiA+ID4gICAgICAgc3RydWN0IG10a19kc2kg KmRzaSA9IHBsYXRmb3JtX2dldF9kcnZkYXRhKHBkZXYpOwo+ID4gPgo+ID4gPiAgICAgICBtdGtf b3V0cHV0X2RzaV9kaXNhYmxlKGRzaSk7Cj4gPiA+ICsgICAgIG10a19kc2lfc3RvcChkc2kpOwo+ ID4gPiArICAgICBtdGtfZHNpX3Bvd2Vyb2ZmKGRzaSk7Cj4gPiA+ICAgICAgIGNvbXBvbmVudF9k ZWwoJnBkZXYtPmRldiwgJm10a19kc2lfY29tcG9uZW50X29wcyk7Cj4gPiA+Cj4gPiA+ICAgICAg IHJldHVybiAwOwo+ID4KPiA+CgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v ZHJpLWRldmVs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3093C43381 for ; Wed, 20 Mar 2019 06:48:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 90AC921850 for ; Wed, 20 Mar 2019 06:48:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="uVwkmHLX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 90AC921850 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Z5q+OpaQuqGUnb6//tfI/raRdUmqVHM6JmbG3jFBflc=; b=uVwkmHLXqG13AP 1kZ0WJq2CahGoQczEIC891BsVqw8gk9C7UfJjT1Zeg6vv20mdX1R8nhrGaO/i/gzfrvRm5SrO3/s0 85Dco/+xMvgs+WNGTJRtWPHU3N06I7HdqMAH34qKu0FfEchHjC0R5JguHFVGzy7/ZrzEMJbGapSpB uc5F4t0N+Fl1/6m+01YkcM5F0TeMVkknRlDqoBZOoLcNFvVsaMm9cbmsyFZas9mGZOBhva2IBQf/n 0GIVnS0fl4Xaefx3m+MeGRf2C+gSLzuX3b0icq7gZupTbBODQJSWar9b608gWs5wPo+l08lqkaUtC 4hN3Ex/jFvC9lO1vUbxA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h6V1X-0005Nw-Kh; Wed, 20 Mar 2019 06:48:27 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h6V1T-0005N5-H4; Wed, 20 Mar 2019 06:48:25 +0000 X-UUID: 057140b099dd492188b858eb32d45663-20190319 X-UUID: 057140b099dd492188b858eb32d45663-20190319 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1408434697; Tue, 19 Mar 2019 22:48:01 -0800 Received: from mtkmbs05n1.mediatek.inc (172.21.101.15) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 19 Mar 2019 23:47:59 -0700 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs05n1.mediatek.inc (172.21.101.15) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 20 Mar 2019 14:47:57 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Wed, 20 Mar 2019 14:47:57 +0800 Message-ID: <1553064478.28297.3.camel@mtksdaap41> Subject: Re: [PATCH] gpu/drm: mediatek: call mtk_dsi_stop() after mtk_drm_crtc_atomic_disable() From: CK Hu To: Hsin-Yi Wang Date: Wed, 20 Mar 2019 14:47:58 +0800 In-Reply-To: References: <20190318040915.101218-1-hsinyi@chromium.org> <1553051356.20221.23.camel@mtksdaap41> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190319_234823_568813_A88EBDC2 X-CRM114-Status: GOOD ( 26.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Philipp Zabel , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, Daniel Vetter , Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Hsin-yi: On Wed, 2019-03-20 at 13:39 +0800, Hsin-Yi Wang wrote: > On Wed, Mar 20, 2019 at 11:09 AM CK Hu wrote: > > > > Hi, Hsin-yi: > > > > On Mon, 2019-03-18 at 12:09 +0800, Hsin-Yi Wang wrote: > > > mtk_dsi_stop() should be called after mtk_drm_crtc_atomic_disable(), which needs > > > ovl irq for drm_crtc_wait_one_vblank(), since after mtk_dsi_stop() is called, > > > ovl irq will be disabled. If drm_crtc_wait_one_vblank() is called after last > > > irq, it will timeout with this message: "vblank wait timed out on crtc 0". This > > > happens sometimes when turning off the screen. > > > > > > In drm_atomic_helper.c#disable_outputs(), > > > the calling sequence when turning off the screen is: > > > > > > 1. mtk_dsi_encoder_disable() > > > --> mtk_output_dsi_disable() > > > --> mtk_dsi_stop(); // sometimes make vblank timeout in atomic_disable > > > --> mtk_dsi_poweroff(); > > > 2. mtk_drm_crtc_atomic_disable() > > > --> drm_crtc_wait_one_vblank(); > > > ... > > > --> mtk_dsi_ddp_stop() > > > --> mtk_dsi_poweroff(); > > > > > > > Thanks for your inference, but I wonder this patch meet all > > consideration. In MT8173 with a bridge chip, the timing to disable dsi > > signal output would influence bridge chip output garbage or not. It's > > better that you could test this on MT8173, or let this patch go for > > weeks and wait for someone to test. If no one care about MT8173, I could > > accept this patch. > We care about MT8173, but it's not easy to test since we have to bring > the whole kernel to >= 4.19 to be able to test latest dsi driver. > The patch (0707632b5bac) that added mtk_dsi_stop() was after MT8173 > (on 3.18), for panel without bridge, so I think without mtk_dsi_stop() > was also working fine for MT8173. OK, I find that in the first version of this driver, there is no mtk_dsi_stop() before mtk_dsi_poweroff(), so I think MT8173 does not do mtk_dsi_stop(). So maybe this works fine for MT8173. Regards, CK > > > > > > Change to make mtk_dsi_stop() called in mtk_dsi_ddp_stop() instead of > > > mtk_output_dsi_disable(). > > > > mtk_dsi_poweroff() has reference count, why not just move mtk_dsi_stop() > > into mtk_dsi_poweroff()? > Yes, we can also call mtk_dsi_stop() in mtk_dsi_poweroff() when > refcount is 0. I can send v2 if you think this way is better. > > Thanks > > > > Regards, > > CK > > > > > > > > Fixes: 0707632b5bac ("drm/mediatek: update DSI sub driver flow for sending commands to panel") > > > Signed-off-by: Hsin-Yi Wang > > > --- > > > drivers/gpu/drm/mediatek/mtk_dsi.c | 4 +++- > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c > > > index b00eb2d2e086..cdd9637dd517 100644 > > > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c > > > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c > > > @@ -696,7 +696,6 @@ static void mtk_output_dsi_disable(struct mtk_dsi *dsi) > > > } > > > } > > > > > > - mtk_dsi_stop(dsi); > > > mtk_dsi_poweroff(dsi); > > > > > > dsi->enabled = false; > > > @@ -857,6 +856,7 @@ static void mtk_dsi_ddp_stop(struct mtk_ddp_comp *comp) > > > { > > > struct mtk_dsi *dsi = container_of(comp, struct mtk_dsi, ddp_comp); > > > > > > + mtk_dsi_stop(dsi); > > > mtk_dsi_poweroff(dsi); > > > } > > > > > > @@ -1178,6 +1178,8 @@ static int mtk_dsi_remove(struct platform_device *pdev) > > > struct mtk_dsi *dsi = platform_get_drvdata(pdev); > > > > > > mtk_output_dsi_disable(dsi); > > > + mtk_dsi_stop(dsi); > > > + mtk_dsi_poweroff(dsi); > > > component_del(&pdev->dev, &mtk_dsi_component_ops); > > > > > > return 0; > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel