From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEE8FC43381 for ; Wed, 20 Mar 2019 23:17:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7BA5B2183E for ; Wed, 20 Mar 2019 23:17:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727614AbfCTXRi (ORCPT ); Wed, 20 Mar 2019 19:17:38 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:16175 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1727437AbfCTXRi (ORCPT ); Wed, 20 Mar 2019 19:17:38 -0400 X-UUID: 5fb7af52b1744e8aa5a04922cbaa7dfc-20190321 X-UUID: 5fb7af52b1744e8aa5a04922cbaa7dfc-20190321 Received: from mtkcas09.mediatek.inc [(172.21.101.178)] by mailgw02.mediatek.com (envelope-from ) (mhqrelay.mediatek.com ESMTP with TLS) with ESMTP id 1965427408; Thu, 21 Mar 2019 07:17:32 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs02n1.mediatek.inc (172.21.101.77) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 21 Mar 2019 07:17:31 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 21 Mar 2019 07:17:31 +0800 Message-ID: <1553123851.30977.76.camel@mtkswgap22> Subject: Re: [PATCH -next] scsi: ufs-mediatek: Make some symbols static From: Stanley Chu To: Yue Haibing CC: Yue Haibing , , , , , , , , , , , "Mukesh Ojha" Date: Thu, 21 Mar 2019 07:17:31 +0800 In-Reply-To: References: <20190320142458.20052-1-yuehaibing@huawei.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Thu, 2019-03-21 at 01:00 +0530, Mukesh Ojha wrote: > On 3/20/2019 7:54 PM, Yue Haibing wrote: > > From: YueHaibing > > > > Fix sparse warnings: > > > > drivers/scsi/ufs/ufs-mediatek.c:19:6: warning: symbol 'ufs_mtk_cfg_unipro_cg' was not declared. Should it be static? > > drivers/scsi/ufs/ufs-mediatek.c:55:5: warning: symbol 'ufs_mtk_bind_mphy' was not declared. Should it be static? > > drivers/scsi/ufs/ufs-mediatek.c:342:27: warning: symbol 'ufs_mtk_of_match' was not declared. Should it be static? > > > > Signed-off-by: YueHaibing > > --- > > drivers/scsi/ufs/ufs-mediatek.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c > > index c3b78fc..2fbb450 100644 > > --- a/drivers/scsi/ufs/ufs-mediatek.c > > +++ b/drivers/scsi/ufs/ufs-mediatek.c > > @@ -16,7 +16,7 @@ > > #include "unipro.h" > > #include "ufs-mediatek.h" > > > > -void ufs_mtk_cfg_unipro_cg(struct ufs_hba *hba, bool enable) > > +static void ufs_mtk_cfg_unipro_cg(struct ufs_hba *hba, bool enable) > > { > > u32 tmp; > > > > @@ -52,7 +52,7 @@ void ufs_mtk_cfg_unipro_cg(struct ufs_hba *hba, bool enable) > > } > > } > > > > -int ufs_mtk_bind_mphy(struct ufs_hba *hba) > > +static int ufs_mtk_bind_mphy(struct ufs_hba *hba) > > { > > struct ufs_mtk_host *host = ufshcd_get_variant(hba); > > struct device *dev = hba->dev; > > @@ -339,7 +339,7 @@ static int ufs_mtk_remove(struct platform_device *pdev) > > return 0; > > } > > > > -const struct of_device_id ufs_mtk_of_match[] = { > > +static const struct of_device_id ufs_mtk_of_match[] = { > > { .compatible = "mediatek,mt8183-ufshci"}, > > {}, > > }; > > > Reviewed-by: Mukesh Ojha > > > Cheers, > Mukesh > Reviewed-by: Stanley Chu Thanks, Stanley From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stanley Chu Subject: Re: [PATCH -next] scsi: ufs-mediatek: Make some symbols static Date: Thu, 21 Mar 2019 07:17:31 +0800 Message-ID: <1553123851.30977.76.camel@mtkswgap22> References: <20190320142458.20052-1-yuehaibing@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Cc: Yue Haibing , alim.akhtar@samsung.com, avri.altman@wdc.com, pedrom.sousa@synopsys.com, jejb@linux.ibm.com, martin.petersen@oracle.com, matthias.bgg@gmail.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-scsi@vger.kernel.org, Mukesh Ojha List-Id: linux-scsi@vger.kernel.org Hi, On Thu, 2019-03-21 at 01:00 +0530, Mukesh Ojha wrote: > On 3/20/2019 7:54 PM, Yue Haibing wrote: > > From: YueHaibing > > > > Fix sparse warnings: > > > > drivers/scsi/ufs/ufs-mediatek.c:19:6: warning: symbol 'ufs_mtk_cfg_unipro_cg' was not declared. Should it be static? > > drivers/scsi/ufs/ufs-mediatek.c:55:5: warning: symbol 'ufs_mtk_bind_mphy' was not declared. Should it be static? > > drivers/scsi/ufs/ufs-mediatek.c:342:27: warning: symbol 'ufs_mtk_of_match' was not declared. Should it be static? > > > > Signed-off-by: YueHaibing > > --- > > drivers/scsi/ufs/ufs-mediatek.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c > > index c3b78fc..2fbb450 100644 > > --- a/drivers/scsi/ufs/ufs-mediatek.c > > +++ b/drivers/scsi/ufs/ufs-mediatek.c > > @@ -16,7 +16,7 @@ > > #include "unipro.h" > > #include "ufs-mediatek.h" > > > > -void ufs_mtk_cfg_unipro_cg(struct ufs_hba *hba, bool enable) > > +static void ufs_mtk_cfg_unipro_cg(struct ufs_hba *hba, bool enable) > > { > > u32 tmp; > > > > @@ -52,7 +52,7 @@ void ufs_mtk_cfg_unipro_cg(struct ufs_hba *hba, bool enable) > > } > > } > > > > -int ufs_mtk_bind_mphy(struct ufs_hba *hba) > > +static int ufs_mtk_bind_mphy(struct ufs_hba *hba) > > { > > struct ufs_mtk_host *host = ufshcd_get_variant(hba); > > struct device *dev = hba->dev; > > @@ -339,7 +339,7 @@ static int ufs_mtk_remove(struct platform_device *pdev) > > return 0; > > } > > > > -const struct of_device_id ufs_mtk_of_match[] = { > > +static const struct of_device_id ufs_mtk_of_match[] = { > > { .compatible = "mediatek,mt8183-ufshci"}, > > {}, > > }; > > > Reviewed-by: Mukesh Ojha > > > Cheers, > Mukesh > Reviewed-by: Stanley Chu Thanks, Stanley From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 336B1C43381 for ; Wed, 20 Mar 2019 23:18:01 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D60622183E for ; Wed, 20 Mar 2019 23:18:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jf7lRPqQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D60622183E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2Kgo6hERLXSgZRzSkP/VlyolWbsZ0wY66TOupo2+2N0=; b=jf7lRPqQnKcWwd audVZqTEbeNDfcPKgS3fFjJ8hJdQGlh3DK7R0MIK6CPXDhPFVoy6+DmkmyZ3c5hGCpSj7kkyj8Gmp FmwDzcgr0bbNpgIEpDUVS64jqKAv/85dirNWAxN89tmuAlTUUQBCKSi+TJNq1PJIpJLFunF+7a/04 AMwGI3U2DZG1hOgGA/rheNGPmUiZIkw2RiHLo6Hn9aswE2cwI7Y0ntZzezVbq+C6671AEfv++SUyR ohqrrDsbu01i3D6mBMwfIINMTwulVriHdAp/5RLaj1HFNp2qvJCP4VDEXRUpacNHOcB3IQLbTUbPm 3O80Fbfc4mzWA24xpDAg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h6kT4-0000FK-At; Wed, 20 Mar 2019 23:17:54 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h6kT0-0000Ep-Ux; Wed, 20 Mar 2019 23:17:52 +0000 X-UUID: cb020fa09d8b4d2db0f1d818c5301ed2-20190320 X-UUID: cb020fa09d8b4d2db0f1d818c5301ed2-20190320 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1161719860; Wed, 20 Mar 2019 15:17:47 -0800 Received: from MTKMBS02N1.mediatek.inc (172.21.101.77) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 20 Mar 2019 16:17:44 -0700 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs02n1.mediatek.inc (172.21.101.77) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 21 Mar 2019 07:17:31 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 21 Mar 2019 07:17:31 +0800 Message-ID: <1553123851.30977.76.camel@mtkswgap22> Subject: Re: [PATCH -next] scsi: ufs-mediatek: Make some symbols static From: Stanley Chu To: Yue Haibing Date: Thu, 21 Mar 2019 07:17:31 +0800 In-Reply-To: References: <20190320142458.20052-1-yuehaibing@huawei.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190320_161751_002600_7F9173CC X-CRM114-Status: GOOD ( 12.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-scsi@vger.kernel.org, martin.petersen@oracle.com, jejb@linux.ibm.com, Yue Haibing , linux-kernel@vger.kernel.org, avri.altman@wdc.com, linux-mediatek@lists.infradead.org, alim.akhtar@samsung.com, matthias.bgg@gmail.com, pedrom.sousa@synopsys.com, Mukesh Ojha , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Thu, 2019-03-21 at 01:00 +0530, Mukesh Ojha wrote: > On 3/20/2019 7:54 PM, Yue Haibing wrote: > > From: YueHaibing > > > > Fix sparse warnings: > > > > drivers/scsi/ufs/ufs-mediatek.c:19:6: warning: symbol 'ufs_mtk_cfg_unipro_cg' was not declared. Should it be static? > > drivers/scsi/ufs/ufs-mediatek.c:55:5: warning: symbol 'ufs_mtk_bind_mphy' was not declared. Should it be static? > > drivers/scsi/ufs/ufs-mediatek.c:342:27: warning: symbol 'ufs_mtk_of_match' was not declared. Should it be static? > > > > Signed-off-by: YueHaibing > > --- > > drivers/scsi/ufs/ufs-mediatek.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c > > index c3b78fc..2fbb450 100644 > > --- a/drivers/scsi/ufs/ufs-mediatek.c > > +++ b/drivers/scsi/ufs/ufs-mediatek.c > > @@ -16,7 +16,7 @@ > > #include "unipro.h" > > #include "ufs-mediatek.h" > > > > -void ufs_mtk_cfg_unipro_cg(struct ufs_hba *hba, bool enable) > > +static void ufs_mtk_cfg_unipro_cg(struct ufs_hba *hba, bool enable) > > { > > u32 tmp; > > > > @@ -52,7 +52,7 @@ void ufs_mtk_cfg_unipro_cg(struct ufs_hba *hba, bool enable) > > } > > } > > > > -int ufs_mtk_bind_mphy(struct ufs_hba *hba) > > +static int ufs_mtk_bind_mphy(struct ufs_hba *hba) > > { > > struct ufs_mtk_host *host = ufshcd_get_variant(hba); > > struct device *dev = hba->dev; > > @@ -339,7 +339,7 @@ static int ufs_mtk_remove(struct platform_device *pdev) > > return 0; > > } > > > > -const struct of_device_id ufs_mtk_of_match[] = { > > +static const struct of_device_id ufs_mtk_of_match[] = { > > { .compatible = "mediatek,mt8183-ufshci"}, > > {}, > > }; > > > Reviewed-by: Mukesh Ojha > > > Cheers, > Mukesh > Reviewed-by: Stanley Chu Thanks, Stanley _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel