From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Date: Thu, 21 Mar 2019 13:31:12 +0000 Subject: Re: [PATCH v2] drm/i915/selftests: fix NULL vs IS_ERR() check in mock_context_barrier() Message-Id: <155317507276.26447.12218949016591033751@skylake-alporthouse-com> List-Id: References: <20190321092451.GK2202@kadam> <87va0czguu.fsf@gaia.fi.intel.com> In-Reply-To: <87va0czguu.fsf@gaia.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter , Jani Nikula , Mika Kuoppala Cc: David Airlie , intel-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org, Matthew Auld Quoting Mika Kuoppala (2019-03-21 10:01:13) > Dan Carpenter writes: > > > The mock_context() function returns NULL on error, it doesn't return > > error pointers. > > > > Fixes: 85fddf0b0027 ("drm/i915: Introduce a context barrier callback") > > Signed-off-by: Dan Carpenter > > Reviewed-by: Mika Kuoppala And pushed, thanks for the fix! -Chris From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH v2] drm/i915/selftests: fix NULL vs IS_ERR() check in mock_context_barrier() Date: Thu, 21 Mar 2019 13:31:12 +0000 Message-ID: <155317507276.26447.12218949016591033751@skylake-alporthouse-com> References: <20190321092451.GK2202@kadam> <87va0czguu.fsf@gaia.fi.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192]) by gabe.freedesktop.org (Postfix) with ESMTPS id DCD7A8934B for ; Thu, 21 Mar 2019 13:31:25 +0000 (UTC) In-Reply-To: <87va0czguu.fsf@gaia.fi.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dan Carpenter , Jani Nikula , Mika Kuoppala Cc: David Airlie , intel-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org, Matthew Auld List-Id: intel-gfx@lists.freedesktop.org UXVvdGluZyBNaWthIEt1b3BwYWxhICgyMDE5LTAzLTIxIDEwOjAxOjEzKQo+IERhbiBDYXJwZW50 ZXIgPGRhbi5jYXJwZW50ZXJAb3JhY2xlLmNvbT4gd3JpdGVzOgo+IAo+ID4gVGhlIG1vY2tfY29u dGV4dCgpIGZ1bmN0aW9uIHJldHVybnMgTlVMTCBvbiBlcnJvciwgaXQgZG9lc24ndCByZXR1cm4K PiA+IGVycm9yIHBvaW50ZXJzLgo+ID4KPiA+IEZpeGVzOiA4NWZkZGYwYjAwMjcgKCJkcm0vaTkx NTogSW50cm9kdWNlIGEgY29udGV4dCBiYXJyaWVyIGNhbGxiYWNrIikKPiA+IFNpZ25lZC1vZmYt Ynk6IERhbiBDYXJwZW50ZXIgPGRhbi5jYXJwZW50ZXJAb3JhY2xlLmNvbT4KPiAKPiBSZXZpZXdl ZC1ieTogTWlrYSBLdW9wcGFsYSA8bWlrYS5rdW9wcGFsYUBsaW51eC5pbnRlbC5jb20+CgpBbmQg cHVzaGVkLCB0aGFua3MgZm9yIHRoZSBmaXghCi1DaHJpcwpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdm eEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9pbnRlbC1nZng=