From: Chris Wilson <chris@chris-wilson.co.uk>
To: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>,
intel-gfx@lists.freedesktop.org
Cc: Eric Betancourt <eric.s.betancourt@intel.com>
Subject: Re: [PATCH] drm/i915: set vdbox/vebox enable masks on all gens
Date: Thu, 21 Mar 2019 22:14:38 +0000 [thread overview]
Message-ID: <155320647792.18968.8596773348493331308@skylake-alporthouse-com> (raw)
In-Reply-To: <20190321220206.612-1-daniele.ceraolospurio@intel.com>
Quoting Daniele Ceraolo Spurio (2019-03-21 22:02:06)
> The upcoming unified GuC FW will require us to send video engine enable
> masks to GuC for its initialization.
>
> For consistency, just set the runtime_info enable masks for all gens.
> We'll then be able to directly use those in the GuC setup
>
> Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: John Spotswood <john.a.spotswood@intel.com>
> Cc: Eric Betancourt <eric.s.betancourt@intel.com>
> Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> ---
> drivers/gpu/drm/i915/intel_device_info.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_device_info.c b/drivers/gpu/drm/i915/intel_device_info.c
> index eddf83807957..836184d6538e 100644
> --- a/drivers/gpu/drm/i915/intel_device_info.c
> +++ b/drivers/gpu/drm/i915/intel_device_info.c
> @@ -872,8 +872,14 @@ void intel_device_info_init_mmio(struct drm_i915_private *dev_priv)
> unsigned int i;
> u32 media_fuse;
>
> - if (INTEL_GEN(dev_priv) < 11)
> + if (INTEL_GEN(dev_priv) < 11) {
> + RUNTIME_INFO(dev_priv)->vdbox_enable =
> + (info->engine_mask & GENMASK(VCS0 + I915_MAX_VCS, VCS0)) >> VCS0;
> +
> + RUNTIME_INFO(dev_priv)->vebox_enable =
> + (info->engine_mask & GENMASK(VECS0 + I915_MAX_VECS, VECS0)) >> VECS0;
Should we do this unconditionally as it seems reasonably
self-desciptive, with a follow to say that on gen11+ we can query the hw
fuses to see what is actually available?
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-03-21 22:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 22:02 [PATCH] drm/i915: set vdbox/vebox enable masks on all gens Daniele Ceraolo Spurio
2019-03-21 22:11 ` Chris Wilson
2019-03-21 22:14 ` Daniele Ceraolo Spurio
2019-03-21 22:39 ` Chris Wilson
2019-03-21 22:43 ` Daniele Ceraolo Spurio
2019-03-21 22:14 ` Chris Wilson [this message]
2019-03-22 1:33 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-03-22 18:28 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=155320647792.18968.8596773348493331308@skylake-alporthouse-com \
--to=chris@chris-wilson.co.uk \
--cc=daniele.ceraolospurio@intel.com \
--cc=eric.s.betancourt@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.