From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [PATCH 1/2] drm/i915: Disable C3 when enabling
 vblank interrupts on i945gm
Date: Fri, 22 Mar 2019 21:08:35 +0000
Message-ID: <155328891458.15930.7846778955426270611@skylake-alporthouse-com>
References: <20190322180804.3300-1-ville.syrjala@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192])
 by gabe.freedesktop.org (Postfix) with ESMTPS id CA0146E3C7
 for <intel-gfx@lists.freedesktop.org>; Fri, 22 Mar 2019 21:08:40 +0000 (UTC)
In-Reply-To: <20190322180804.3300-1-ville.syrjala@linux.intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Ville Syrjala <ville.syrjala@linux.intel.com>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

UXVvdGluZyBWaWxsZSBTeXJqYWxhICgyMDE5LTAzLTIyIDE4OjA4OjAzKQo+IEZyb206IFZpbGxl
IFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gCj4gVGhlIEFHUEJV
U1kgdGhpbmcgZG9lc24ndCB3b3JrIG9uIGk5NDVnbSBhbnltb3JlLiBUaGlzIG1lYW5zCj4gdGhl
IGdtY2ggaXMgaW5jYXBhYmxlIG9mIHdha2luZyB0aGUgQ1BVIGZyb20gQzMgd2hlbiBhbiBpbnRl
cnJ1cHQKPiBpcyBnZW5lcmF0ZWQuIFRoZSBpbnRlcnJ1cHRzIGp1c3QgZ2V0IHBvc3Rwb25lZCBp
bmRlZmluaXRlbHkgdW50aWwKPiBzb21ldGhpbmcgd2FrZXMgdXAgdGhlIENQVS4gVGhpcyBpcyBy
YXRoZXIgYW5ub3lpbmcgZm9yIHZibGFuawo+IGludGVycnVwdHMgYXMgd2UgYXJlIHVuYWJsZSB0
byBtYWludGFpbiBhIHN0ZWFkeSBmcmFtZXJhdGUKPiB1bmxlc3MgdGhlIG1hY2hpbmUgaXMgc3Vm
ZmljaWVudGx5IGxvYWRlZCB0byBzdGF5IG91dCBvZiBDMy4KPiAKPiBUbyBjb21iYXQgdGhpcyBs
ZXQncyB1c2UgcG1fcW9zIHRvIHByZXZlbnQgQzMgd2hlbmV2ZXIgdmJsYW5rCj4gaW50ZXJydXB0
cyBhcmUgZW5hYmxlZC4gVG8gbWFpbnRhaW4gcmVhc29uYWJsZSBhbW91bnQgb2YgcG93ZXJzYXZp
bmcKPiB3ZSB3aWxsIGF0dGVtcHQgdG8gbGltaXQgdGhpcyB0byBDMyBvbmx5IHdoaWxlIGxlYXZp
bmcgQzEgYW5kIEMyCj4gZW5hYmxlZC4KCkludGVyZXN0aW5nIGNvbXByb21pc2UuIEZyYW5rbHks
IEkgaGFkIGNvbnNpZGVyZWQgcG1fcW9zIGluIGFuCmFsbC1vci1ub3RoaW5nIGFwcHJvYWNoLCBw
YXJ0bHkgYmVjYXVzZSBmaW5kaW5nIHRoZSBDIHRyYW5zaXRpb25zIGlzIGEKYml0IG9wYXF1ZS4K
IAo+IEJ1Z3ppbGxhOiBodHRwczovL2J1Z3MuZnJlZWRlc2t0b3Aub3JnL3Nob3dfYnVnLmNnaT9p
ZD0zMDM2NAo+IFNpZ25lZC1vZmYtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBs
aW51eC5pbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2Lmgg
fCAgOCArKysKPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEuYyB8IDg4ICsrKysrKysr
KysrKysrKysrKysrKysrKysrKysrKysrKwo+ICAyIGZpbGVzIGNoYW5nZWQsIDk2IGluc2VydGlv
bnMoKykKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaCBi
L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiBpbmRleCBmNzIzYjE1NTI3ZjguLjBj
NzM2ZjhjYTFiMiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5o
Cj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+IEBAIC0yMDQyLDYgKzIw
NDIsMTQgQEAgc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgewo+ICAgICAgICAgICAgICAgICBzdHJ1
Y3QgaTkxNV92bWEgKnNjcmF0Y2g7Cj4gICAgICAgICB9IGd0Owo+ICAKPiArICAgICAgIC8qIEZv
ciBpOTQ1Z20gdmJsYW5rIGlycSB2cy4gQzMgd29ya2Fyb3VuZCAqLwo+ICsgICAgICAgc3RydWN0
IHsKPiArICAgICAgICAgICAgICAgc3RydWN0IHdvcmtfc3RydWN0IHdvcms7Cj4gKyAgICAgICAg
ICAgICAgIHN0cnVjdCBwbV9xb3NfcmVxdWVzdCBwbV9xb3M7Cj4gKyAgICAgICAgICAgICAgIHU4
IGMzX2Rpc2FibGVfbGF0ZW5jeTsKCk9rLCBsb29rcyBhIGJpdCB0aWdodCwgYnV0IGNoZWNrcyBv
dXQuCgo+ICsgICAgICAgICAgICAgICB1OCBlbmFibGVkOwo+ICsgICAgICAgfSBpOTQ1Z21fdmJs
YW5rOwo+ICsKPiAgICAgICAgIC8qIHBlcmZvcm0gUEhZIHN0YXRlIHNhbml0eSBjaGVja3M/ICov
Cj4gICAgICAgICBib29sIGNodl9waHlfYXNzZXJ0WzJdOwo+ICAKPiBkaWZmIC0tZ2l0IGEvZHJp
dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf
aXJxLmMKPiBpbmRleCAyZjc4ODI5MWNmZTAuLjMzMzg2ZjBhY2FiMyAxMDA2NDQKPiAtLS0gYS9k
cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5
MTUvaTkxNV9pcnEuYwo+IEBAIC0zMCw2ICszMCw3IEBACj4gIAo+ICAjaW5jbHVkZSA8bGludXgv
c3lzcnEuaD4KPiAgI2luY2x1ZGUgPGxpbnV4L3NsYWIuaD4KPiArI2luY2x1ZGUgPGxpbnV4L2Nw
dWlkbGUuaD4KPiAgI2luY2x1ZGUgPGxpbnV4L2NpcmNfYnVmLmg+Cj4gICNpbmNsdWRlIDxkcm0v
ZHJtX2lycS5oPgo+ICAjaW5jbHVkZSA8ZHJtL2RybV9kcnYuaD4KPiBAQCAtMzEzMSw2ICszMTMy
LDE2IEBAIHN0YXRpYyBpbnQgaTh4eF9lbmFibGVfdmJsYW5rKHN0cnVjdCBkcm1fZGV2aWNlICpk
ZXYsIHVuc2lnbmVkIGludCBwaXBlKQo+ICAgICAgICAgcmV0dXJuIDA7Cj4gIH0KPiAgCj4gK3N0
YXRpYyBpbnQgaTk0NWdtX2VuYWJsZV92Ymxhbmsoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgdW5z
aWduZWQgaW50IHBpcGUpCj4gK3sKPiArICAgICAgIHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpk
ZXZfcHJpdiA9IHRvX2k5MTUoZGV2KTsKPiArCj4gKyAgICAgICBpZiAoZGV2X3ByaXYtPmk5NDVn
bV92YmxhbmsuZW5hYmxlZCsrID09IDApCj4gKyAgICAgICAgICAgICAgIHNjaGVkdWxlX3dvcmso
JmRldl9wcml2LT5pOTQ1Z21fdmJsYW5rLndvcmspOwoKSSB3YXMgdGhpbmtpbmcgdTgsIGlzbid0
IHRoYXQgYSBiaXQgZGFuZ2Vyb3VzLiBCdXQgdGhlIG1heCBjb3VudGVyIGhlcmUKc2hvdWxkIGJl
IG51bV9waXBlcy4gSG1tLCBpcyB0aGUgdmJsYW5rIHNwaW5sb2NrIGxvY2FsIHRvIGEgcGlwZT8g
Tm9wZSwKZGV2LT52YmxfbG9jay4KCj4gKwo+ICsgICAgICAgcmV0dXJuIGk4eHhfZW5hYmxlX3Zi
bGFuayhkZXYsIHBpcGUpOwo+ICt9Cj4gKwo+ICBzdGF0aWMgaW50IGk5NjVfZW5hYmxlX3ZibGFu
ayhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB1bnNpZ25lZCBpbnQgcGlwZSkKPiAgewo+ICAgICAg
ICAgc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShkZXYpOwo+IEBA
IC0zMTk1LDYgKzMyMDYsMTYgQEAgc3RhdGljIHZvaWQgaTh4eF9kaXNhYmxlX3ZibGFuayhzdHJ1
Y3QgZHJtX2RldmljZSAqZGV2LCB1bnNpZ25lZCBpbnQgcGlwZSkKPiAgICAgICAgIHNwaW5fdW5s
b2NrX2lycXJlc3RvcmUoJmRldl9wcml2LT5pcnFfbG9jaywgaXJxZmxhZ3MpOwo+ICB9Cj4gIAo+
ICtzdGF0aWMgdm9pZCBpOTQ1Z21fZGlzYWJsZV92Ymxhbmsoc3RydWN0IGRybV9kZXZpY2UgKmRl
diwgdW5zaWduZWQgaW50IHBpcGUpCj4gK3sKPiArICAgICAgIHN0cnVjdCBkcm1faTkxNV9wcml2
YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoZGV2KTsKPiArCj4gKyAgICAgICBpOHh4X2Rpc2FibGVf
dmJsYW5rKGRldiwgcGlwZSk7Cj4gKwo+ICsgICAgICAgaWYgKC0tZGV2X3ByaXYtPmk5NDVnbV92
YmxhbmsuZW5hYmxlZCA9PSAwKQo+ICsgICAgICAgICAgICAgICBzY2hlZHVsZV93b3JrKCZkZXZf
cHJpdi0+aTk0NWdtX3ZibGFuay53b3JrKTsKPiArfQo+ICsKPiAgc3RhdGljIHZvaWQgaTk2NV9k
aXNhYmxlX3ZibGFuayhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB1bnNpZ25lZCBpbnQgcGlwZSkK
PiAgewo+ICAgICAgICAgc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkx
NShkZXYpOwo+IEBAIC0zMjI4LDYgKzMyNDksNjAgQEAgc3RhdGljIHZvaWQgZ2VuOF9kaXNhYmxl
X3ZibGFuayhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB1bnNpZ25lZCBpbnQgcGlwZSkKPiAgICAg
ICAgIHNwaW5fdW5sb2NrX2lycXJlc3RvcmUoJmRldl9wcml2LT5pcnFfbG9jaywgaXJxZmxhZ3Mp
Owo+ICB9Cj4gIAo+ICtzdGF0aWMgdm9pZCBpOTQ1Z21fdmJsYW5rX3dvcmtfZnVuYyhzdHJ1Y3Qg
d29ya19zdHJ1Y3QgKndvcmspCj4gK3sKPiArICAgICAgIHN0cnVjdCBkcm1faTkxNV9wcml2YXRl
ICpkZXZfcHJpdiA9Cj4gKyAgICAgICAgICAgICAgIGNvbnRhaW5lcl9vZih3b3JrLCBzdHJ1Y3Qg
ZHJtX2k5MTVfcHJpdmF0ZSwgaTk0NWdtX3ZibGFuay53b3JrKTsKPiArCj4gKyAgICAgICAvKgo+
ICsgICAgICAgICogVmJsYW5rIGludGVycnVwdHMgZmFpbCB0byB3YWtlIHVwIHRoZSBkZXZpY2Ug
ZnJvbSBDMywKPiArICAgICAgICAqIGhlbmNlIHdlIHdhbnQgdG8gcHJldmVudCBDMyB1c2FnZSB3
aGlsZSB2YmxhbmsgaW50ZXJydXB0cwo+ICsgICAgICAgICogYXJlIGVuYWJsZWQuCj4gKyAgICAg
ICAgKi8KPiArICAgICAgIHBtX3Fvc191cGRhdGVfcmVxdWVzdCgmZGV2X3ByaXYtPmk5NDVnbV92
YmxhbmsucG1fcW9zLAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGRldl9wcml2LT5p
OTQ1Z21fdmJsYW5rLmVuYWJsZWQgPwo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGRl
dl9wcml2LT5pOTQ1Z21fdmJsYW5rLmMzX2Rpc2FibGVfbGF0ZW5jeSA6Cj4gKyAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgUE1fUU9TX0RFRkFVTFRfVkFMVUUpOwoKV29ya2VyIGlzIHJlcXVp
cmVkIGFzIHRoZSB1cGRhdGUgbWF5IGJsb2NrLgoKSSdkIHByZWZlciB0aGF0IGFzIFJFQURfT05D
RShkZXZfcHJpdi0+aTk0NWdtX3ZibGFuay5lbmFibGVkKQoKPiArfQo+ICsKPiArc3RhdGljIGlu
dCBjc3RhdGVfZGlzYWJsZV9sYXRlbmN5KGNvbnN0IGNoYXIgKm5hbWUpCj4gK3sKPiArICAgICAg
IGNvbnN0IHN0cnVjdCBjcHVpZGxlX2RyaXZlciAqZHJ2Owo+ICsgICAgICAgaW50IGk7Cj4gKwo+
ICsgICAgICAgZHJ2ID0gY3B1aWRsZV9nZXRfZHJpdmVyKCk7Cj4gKyAgICAgICBpZiAoIWRydikK
PiArICAgICAgICAgICAgICAgcmV0dXJuIDA7Cj4gKwo+ICsgICAgICAgZm9yIChpID0gMDsgaSA8
IGRydi0+c3RhdGVfY291bnQ7IGkrKykgewo+ICsgICAgICAgICAgICAgICBjb25zdCBzdHJ1Y3Qg
Y3B1aWRsZV9zdGF0ZSAqc3RhdGUgPSAmZHJ2LT5zdGF0ZXNbaV07Cj4gKwo+ICsgICAgICAgICAg
ICAgICBpZiAoIXN0cmNtcChzdGF0ZS0+bmFtZSwgbmFtZSkpCj4gKyAgICAgICAgICAgICAgICAg
ICAgICAgcmV0dXJuIHN0YXRlLT5leGl0X2xhdGVuY3kgPwo+ICsgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgc3RhdGUtPmV4aXRfbGF0ZW5jeSAtIDEgOiAwOwo+ICsgICAgICAgfQoKTWlu
ZCBpZiBJIHNheSB5dWNrPwoKV2lsbCBvbmx5IHdvcmsgd2l0aCB0aGUgaW50ZWxfaWRsZSBkcml2
ZXIuIEFuZCBpZiBub3QgcHJlc2VudCwgd2UgZm9yY2UKdGhlIHN5c3RlbSB0byBub3Qgc2xlZXAg
d2hpbGUgdmJsYW5rcyBhcmUgdGlja2luZyBvdmVyLgoKQW5kIGl0IGlzIGV4aXRfbGF0ZW5jeSB0
aGF0IGlzIGNvbXBhcmVkIGFnYWluc3QgdGhlIHFvcyByZXF1ZXN0LgoKT2suIEl0IGRvZXMgd2hh
dCBpdCBzYXlzIG9uIHRoZSB0aW4uCgpPbmUgb2YgdGhlIHJlYXNvbnMgSSd2ZSBoZXNpdGF0ZWQg
aW4gdGhlIHBhc3Qgd2FzIHRoYXQgSSBjb25zaWRlcmVkCnZibGFua3MgYXMgYSBiYWNrZ3JvdW5k
IGhlYXJ0YmVhdCB3aGlsZSB0aGUgc3lzdGVtIGlzIGFjdGl2ZSBhbmQgcHJldHR5Cm11Y2ggY29u
c3RhbnRseSBvbiB3aGlsZSB0aGUgc2NyZWVuIGlzLiBIb3dldmVyLCBJIHN1cHBvc2UgdGhhdCBp
cyB0cnVlCihhbmQgaXMgZXZpZGVuY2VkIGJ5IHJlY2VudCBzeXN0ZW1zIHRoYXQgZG8gbm90IHNs
ZWVwIHdoaWxlIHRoZSBzY3JlZW5zCmFyZSBvbiwgYXQgbGVhc3Qgbm90IHdpdGggYW4gYWN0aXZl
IGxpbmspLgoKVGhlIHdvcnN0IHRoYXQgY2FuIGhhcHBlbiBpcyBzb21lb25lIGNvbXBsYWlucyBh
Ym91dCBhIGhvdCBsYXB0b3AsIGFuZAp0aGUgcmVtZWR5IGlzIHNpbXBsZSBpZiB3ZSBkb24ndCBz
dWNjZWVkIGluIGtpbGxpbmcgaXQgZmlyc3QsClJldmlld2VkLWJ5OiBDaHJpcyBXaWxzb24gPGNo
cmlzQGNocmlzLXdpbHNvbi5jby51az4KLUNocmlzCl9fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxp
c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu
L2xpc3RpbmZvL2ludGVsLWdmeA==