From: Chris Wilson <chris@chris-wilson.co.uk>
To: "Michał Winiarski" <michal.winiarski@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] Revert "drm/i915: Introduce private PAT management"
Date: Sun, 24 Mar 2019 13:47:08 +0000 [thread overview]
Message-ID: <155343522810.15930.2555608258163619905@skylake-alporthouse-com> (raw)
In-Reply-To: <20190322162037.10159-1-michal.winiarski@intel.com>
Quoting Michał Winiarski (2019-03-22 16:20:37)
> static int gen8_gmch_probe(struct i915_ggtt *ggtt)
> @@ -3517,14 +3327,6 @@ void i915_gem_restore_gtt_mappings(struct drm_i915_private *dev_priv)
> i915_ggtt_invalidate(dev_priv);
>
> mutex_unlock(&ggtt->vm.mutex);
> -
> - if (INTEL_GEN(dev_priv) >= 8) {
> - struct intel_ppat *ppat = &dev_priv->ppat;
> -
> - bitmap_set(ppat->dirty, 0, ppat->max_entries);
> - dev_priv->ppat.update_hw(dev_priv);
Missed on the first pass, do we need to keep the restore, i.e. call
setup_private_pat() again?
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-03-24 13:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-22 16:20 [PATCH] Revert "drm/i915: Introduce private PAT management" Michał Winiarski
2019-03-22 16:41 ` Chris Wilson
2019-03-22 16:49 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2019-03-22 16:50 ` ✗ Fi.CI.SPARSE: " Patchwork
2019-03-22 17:11 ` ✗ Fi.CI.BAT: failure " Patchwork
2019-03-24 13:11 ` ✗ Fi.CI.CHECKPATCH: warning for Revert "drm/i915: Introduce private PAT management" (rev2) Patchwork
2019-03-24 13:12 ` ✗ Fi.CI.SPARSE: " Patchwork
2019-03-24 13:39 ` ✗ Fi.CI.BAT: failure " Patchwork
2019-03-24 13:47 ` Chris Wilson [this message]
2019-03-25 11:49 ` [PATCH] Revert "drm/i915: Introduce private PAT management" Michał Winiarski
2019-03-25 11:49 ` [PATCH v2] " Michał Winiarski
2019-03-25 12:35 ` ✗ Fi.CI.CHECKPATCH: warning for Revert "drm/i915: Introduce private PAT management" (rev3) Patchwork
2019-03-25 12:36 ` ✗ Fi.CI.SPARSE: " Patchwork
2019-03-25 12:57 ` ✗ Fi.CI.BAT: failure " Patchwork
2019-03-25 14:30 ` ✗ Fi.CI.CHECKPATCH: warning for Revert "drm/i915: Introduce private PAT management" (rev4) Patchwork
2019-03-25 14:31 ` ✗ Fi.CI.SPARSE: " Patchwork
2019-03-25 14:59 ` ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=155343522810.15930.2555608258163619905@skylake-alporthouse-com \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=michal.winiarski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.