From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04D68C43381 for ; Mon, 25 Mar 2019 10:39:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D1BD0207DD for ; Mon, 25 Mar 2019 10:39:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730797AbfCYKjT (ORCPT ); Mon, 25 Mar 2019 06:39:19 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:41923 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730535AbfCYKjS (ORCPT ); Mon, 25 Mar 2019 06:39:18 -0400 Received: from kresse.hi.pengutronix.de ([2001:67c:670:100:1d::2a]) by metis.ext.pengutronix.de with esmtp (Exim 4.89) (envelope-from ) id 1h8N0Z-0000c1-6G; Mon, 25 Mar 2019 11:39:11 +0100 Message-ID: <1553510350.2561.3.camel@pengutronix.de> Subject: Re: [PATCH] ARM: dts: imx6qdl: Specify IMX6QDL_CLK_IPG as "ipg" clock for SDMA From: Lucas Stach To: Andrey Smirnov , Shawn Guo Cc: Angus Ainslie , Chris Healy , Fabio Estevam , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Mon, 25 Mar 2019 11:39:10 +0100 In-Reply-To: <20190325050100.29517-1-andrew.smirnov@gmail.com> References: <20190325050100.29517-1-andrew.smirnov@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::2a X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Sonntag, den 24.03.2019, 22:01 -0700 schrieb Andrey Smirnov: > Since 25aaa75df1e6 SDMA driver uses clock rates of "ipg" and "ahb" > clock to determine if it needs to configure the IP block as operating > at 1:1 or 1:2 clock ratio (ACR bit in SDMAARM_CONFIG). Specifying both > clocks as IMX6QDL_CLK_SDMA results in driver incorrectly thinking that > ratio is 1:1 which results in broken SDMA functionality(this at least > breaks RAVE SP serdev driver on RDU2). Fix the code to specify > IMX6QDL_CLK_IPG as "ipg" clock for SDMA, to the problem. As this is breaking DT backward compatibility, I think we need a blacklist in the driver for SOCs where the DT is known to be broken. But fixing the broken DT is still a good idea, so: Reviewed-by: Lucas Stach > Fixes: 25aaa75df1e6 ("dmaengine: imx-sdma: add clock ratio 1:1 check") > > Signed-off-by: Andrey Smirnov > > Cc: Angus Ainslie (Purism) > > Cc: Chris Healy > > Cc: Lucas Stach > > Cc: Fabio Estevam > > Cc: Shawn Guo > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > --- > > This probably has been fixed already, so please ignore this patch if > that is the case. > > Thanks, > Andrey Smirnov > >  arch/arm/boot/dts/imx6qdl.dtsi | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi > index 9f9aa6e7ed0e..354feba077b2 100644 > --- a/arch/arm/boot/dts/imx6qdl.dtsi > +++ b/arch/arm/boot/dts/imx6qdl.dtsi > @@ -949,7 +949,7 @@ > >   compatible = "fsl,imx6q-sdma", "fsl,imx35-sdma"; > >   reg = <0x020ec000 0x4000>; > >   interrupts = <0 2 IRQ_TYPE_LEVEL_HIGH>; > > - clocks = <&clks IMX6QDL_CLK_SDMA>, > > + clocks = <&clks IMX6QDL_CLK_IPG>, > >    <&clks IMX6QDL_CLK_SDMA>; > >   clock-names = "ipg", "ahb"; > >   #dma-cells = <3>; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADCA7C43381 for ; Mon, 25 Mar 2019 10:39:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7AAA2207DD for ; Mon, 25 Mar 2019 10:39:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="aCd0y15W" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7AAA2207DD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xbpJaiFjDeNe5Km1Rstm011+TY5rmlfaC6oHmvh271E=; b=aCd0y15WlZRDVj q87WSh/QPrtFQ8QyDnW935JW3TX/G1XgTSxHnsUOU8QTwJxX88tVCnASJ3EktX6OeJK91x45rcc7V aQ8LYOmqb4zmeCy+Q87Ws6rcjlyExeRMKLh+qFRy7TfpsjzM/vot0p5P9Dt28zPuItKr/+Y6y2thV Eupy/N6Bg17F6tSCRVYRaFLxj+aGauLLg5I/oUaQD0l0aBbHcyfthpQI6JRJJIXOFCLufGsuhocVg onYzqfo7NCrESOg8PCUnMsMwNoMi1+1txjJYlDiTPibVT4vHfATQdFYgOehl+h+Y4oOdJlrZN8qN2 p8YyiPEnft/7Bq6XtZPQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8N0o-0006BR-AI; Mon, 25 Mar 2019 10:39:26 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8N0h-0006AM-RI for linux-arm-kernel@lists.infradead.org; Mon, 25 Mar 2019 10:39:22 +0000 Received: from kresse.hi.pengutronix.de ([2001:67c:670:100:1d::2a]) by metis.ext.pengutronix.de with esmtp (Exim 4.89) (envelope-from ) id 1h8N0Z-0000c1-6G; Mon, 25 Mar 2019 11:39:11 +0100 Message-ID: <1553510350.2561.3.camel@pengutronix.de> Subject: Re: [PATCH] ARM: dts: imx6qdl: Specify IMX6QDL_CLK_IPG as "ipg" clock for SDMA From: Lucas Stach To: Andrey Smirnov , Shawn Guo Date: Mon, 25 Mar 2019 11:39:10 +0100 In-Reply-To: <20190325050100.29517-1-andrew.smirnov@gmail.com> References: <20190325050100.29517-1-andrew.smirnov@gmail.com> X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::2a X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190325_033920_040005_5A47129E X-CRM114-Status: GOOD ( 17.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fabio Estevam , Angus Ainslie , linux-arm-kernel@lists.infradead.org, Chris Healy , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org QW0gU29ubnRhZywgZGVuIDI0LjAzLjIwMTksIDIyOjAxIC0wNzAwIHNjaHJpZWIgQW5kcmV5IFNt aXJub3Y6Cj4gU2luY2UgMjVhYWE3NWRmMWU2IFNETUEgZHJpdmVyIHVzZXMgY2xvY2sgcmF0ZXMg b2YgImlwZyIgYW5kICJhaGIiCj4gY2xvY2sgdG8gZGV0ZXJtaW5lIGlmIGl0IG5lZWRzIHRvIGNv bmZpZ3VyZSB0aGUgSVAgYmxvY2sgYXMgb3BlcmF0aW5nCj4gYXQgMToxIG9yIDE6MiBjbG9jayBy YXRpbyAoQUNSIGJpdCBpbiBTRE1BQVJNX0NPTkZJRykuIFNwZWNpZnlpbmcgYm90aAo+IGNsb2Nr cyBhcyBJTVg2UURMX0NMS19TRE1BIHJlc3VsdHMgaW4gZHJpdmVyIGluY29ycmVjdGx5IHRoaW5r aW5nIHRoYXQKPiByYXRpbyBpcyAxOjEgd2hpY2ggcmVzdWx0cyBpbiBicm9rZW4gU0RNQSBmdW5j dGlvbmFsaXR5KHRoaXMgYXQgbGVhc3QKPiBicmVha3MgUkFWRSBTUCBzZXJkZXYgZHJpdmVyIG9u IFJEVTIpLiBGaXggdGhlIGNvZGUgdG8gc3BlY2lmeQo+IElNWDZRRExfQ0xLX0lQRyBhcyAiaXBn IiBjbG9jayBmb3IgU0RNQSwgdG8gdGhlIHByb2JsZW0uCgpBcyB0aGlzIGlzIGJyZWFraW5nIERU IGJhY2t3YXJkIGNvbXBhdGliaWxpdHksIEkgdGhpbmsgd2UgbmVlZCBhCmJsYWNrbGlzdCBpbiB0 aGUgZHJpdmVyIGZvciBTT0NzIHdoZXJlIHRoZSBEVCBpcyBrbm93biB0byBiZSBicm9rZW4uCgpC dXQgZml4aW5nIHRoZSBicm9rZW4gRFQgaXMgc3RpbGwgYSBnb29kIGlkZWEsIHNvOgoKUmV2aWV3 ZWQtYnk6IEx1Y2FzIFN0YWNoIDxsLnN0YWNoQHBlbmd1dHJvbml4LmRlPgoKPiBGaXhlczogMjVh YWE3NWRmMWU2ICgiZG1hZW5naW5lOiBpbXgtc2RtYTogYWRkIGNsb2NrIHJhdGlvIDE6MSBjaGVj ayIpCj4gPiBTaWduZWQtb2ZmLWJ5OiBBbmRyZXkgU21pcm5vdiA8YW5kcmV3LnNtaXJub3ZAZ21h aWwuY29tPgo+ID4gQ2M6IEFuZ3VzIEFpbnNsaWUgKFB1cmlzbSkgPGFuZ3VzQGFra2VhLmNhPgo+ ID4gQ2M6IENocmlzIEhlYWx5IDxjcGhlYWx5QGdtYWlsLmNvbT4KPiA+IENjOiBMdWNhcyBTdGFj aCA8bC5zdGFjaEBwZW5ndXRyb25peC5kZT4KPiA+IENjOiBGYWJpbyBFc3RldmFtIDxmYWJpby5l c3RldmFtQG54cC5jb20+Cj4gPiBDYzogU2hhd24gR3VvIDxzaGF3bmd1b0BrZXJuZWwub3JnPgo+ IENjOiBsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKPiBDYzogbGludXgta2Vy bmVsQHZnZXIua2VybmVsLm9yZwo+IC0tLQo+IAo+IFRoaXMgcHJvYmFibHkgaGFzIGJlZW4gZml4 ZWQgYWxyZWFkeSwgc28gcGxlYXNlIGlnbm9yZSB0aGlzIHBhdGNoIGlmCj4gdGhhdCBpcyB0aGUg Y2FzZS4KPiAKPiBUaGFua3MsCj4gQW5kcmV5IFNtaXJub3YKPiAKPiDCoGFyY2gvYXJtL2Jvb3Qv ZHRzL2lteDZxZGwuZHRzaSB8IDIgKy0KPiDCoDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigr KSwgMSBkZWxldGlvbigtKQo+IAo+IGRpZmYgLS1naXQgYS9hcmNoL2FybS9ib290L2R0cy9pbXg2 cWRsLmR0c2kgYi9hcmNoL2FybS9ib290L2R0cy9pbXg2cWRsLmR0c2kKPiBpbmRleCA5ZjlhYTZl N2VkMGUuLjM1NGZlYmEwNzdiMiAxMDA2NDQKPiAtLS0gYS9hcmNoL2FybS9ib290L2R0cy9pbXg2 cWRsLmR0c2kKPiArKysgYi9hcmNoL2FybS9ib290L2R0cy9pbXg2cWRsLmR0c2kKPiBAQCAtOTQ5 LDcgKzk0OSw3IEBACj4gPiDCoAkJCQljb21wYXRpYmxlID0gImZzbCxpbXg2cS1zZG1hIiwgImZz bCxpbXgzNS1zZG1hIjsKPiA+IMKgCQkJCXJlZyA9IDwweDAyMGVjMDAwIDB4NDAwMD47Cj4gPiDC oAkJCQlpbnRlcnJ1cHRzID0gPDAgMiBJUlFfVFlQRV9MRVZFTF9ISUdIPjsKPiA+IC0JCQkJY2xv Y2tzID0gPCZjbGtzIElNWDZRRExfQ0xLX1NETUE+LAo+ID4gKwkJCQljbG9ja3MgPSA8JmNsa3Mg SU1YNlFETF9DTEtfSVBHPiwKPiA+IMKgCQkJCQnCoDwmY2xrcyBJTVg2UURMX0NMS19TRE1BPjsK PiA+IMKgCQkJCWNsb2NrLW5hbWVzID0gImlwZyIsICJhaGIiOwo+ID4gwqAJCQkJI2RtYS1jZWxs cyA9IDwzPjsKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5m cmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xp bnV4LWFybS1rZXJuZWwK