From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2] dmaengine: stm32-mdma: Revert "Add a check on read_u32_array" From: Pierre Yves MORDRET Message-Id: <1553530915-1961-1-git-send-email-pierre-yves.mordret@st.com> Date: Mon, 25 Mar 2019 17:21:55 +0100 To: Dan Williams , Vinod Koul , Maxime Coquelin , Alexandre Torgue , dmaengine@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Pierre-Yves MORDRET List-ID: VGhpcyByZXZlcnRzIGNvbW1pdCA5MDZiNDBiMjQ2YjAgKCJBZGQgYSBjaGVjayBvbiByZWFkX3Uz Ml9hcnJheSIpCgpBcyBzdGF0ZWQgYnkgYmluZGluZ3MgInN0LGFoYi1hZGRyLW1hc2tzIiBpcyBv cHRpb25hbC4KVGhlIHN0YXRlbWVudCBpbnNlcnRlZCBieSB0aGlzIGNvbW1pdCBtYWtlcyB0aGlz IHByb3BlcnR5Cm1hbmRhdG9yeSBhbmQgcHJldmVudHMgTURNQSB0byBiZSBwcm9iZWQgaW4gY2Fz ZSBwcm9wZXJ0eSBub3QgcHJlc2VudC4KClNpZ25lZC1vZmYtYnk6IFBpZXJyZS1ZdmVzIE1PUkRS RVQgPHBpZXJyZS15dmVzLm1vcmRyZXRAc3QuY29tPgotLS0KICBWZXJzaW9uIGhpc3Rvcnk6CiAg ICB2MjoKICAgICAgICogcmV2aWV3IGNvbW1pdCBtZXNzYWdlCiAgICB2MToKICAgICAgICogSW5p dGlhbAotLS0KLS0tCiBkcml2ZXJzL2RtYS9zdG0zMi1tZG1hLmMgfCA0ICstLS0KIDEgZmlsZSBj aGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kcml2 ZXJzL2RtYS9zdG0zMi1tZG1hLmMgYi9kcml2ZXJzL2RtYS9zdG0zMi1tZG1hLmMKaW5kZXggNGUw ZWVkZS4uYWMwMzAxYiAxMDA2NDQKLS0tIGEvZHJpdmVycy9kbWEvc3RtMzItbWRtYS5jCisrKyBi L2RyaXZlcnMvZG1hL3N0bTMyLW1kbWEuYwpAQCAtMTU3OCwxMSArMTU3OCw5IEBAIHN0YXRpYyBp bnQgc3RtMzJfbWRtYV9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQogCiAJZG1h ZGV2LT5ucl9jaGFubmVscyA9IG5yX2NoYW5uZWxzOwogCWRtYWRldi0+bnJfcmVxdWVzdHMgPSBu cl9yZXF1ZXN0czsKLQlyZXQgPSBkZXZpY2VfcHJvcGVydHlfcmVhZF91MzJfYXJyYXkoJnBkZXYt PmRldiwgInN0LGFoYi1hZGRyLW1hc2tzIiwKKwlkZXZpY2VfcHJvcGVydHlfcmVhZF91MzJfYXJy YXkoJnBkZXYtPmRldiwgInN0LGFoYi1hZGRyLW1hc2tzIiwKIAkJCQkgICAgICAgZG1hZGV2LT5h aGJfYWRkcl9tYXNrcywKIAkJCQkgICAgICAgY291bnQpOwotCWlmIChyZXQpCi0JCXJldHVybiBy ZXQ7CiAJZG1hZGV2LT5ucl9haGJfYWRkcl9tYXNrcyA9IGNvdW50OwogCiAJcmVzID0gcGxhdGZv cm1fZ2V0X3Jlc291cmNlKHBkZXYsIElPUkVTT1VSQ0VfTUVNLCAwKTsK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8FC7C43381 for ; Mon, 25 Mar 2019 16:22:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AA94020828 for ; Mon, 25 Mar 2019 16:22:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729204AbfCYQWb (ORCPT ); Mon, 25 Mar 2019 12:22:31 -0400 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:29313 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726024AbfCYQWb (ORCPT ); Mon, 25 Mar 2019 12:22:31 -0400 Received: from pps.filterd (m0046668.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x2PGGANC011739; Mon, 25 Mar 2019 17:22:11 +0100 Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 2rddhbca47-1 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 25 Mar 2019 17:22:11 +0100 Received: from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id C480543; Mon, 25 Mar 2019 16:21:56 +0000 (GMT) Received: from Webmail-eu.st.com (sfhdag5node2.st.com [10.75.127.14]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id A5753EE0; Mon, 25 Mar 2019 16:21:56 +0000 (GMT) Received: from localhost (10.75.127.47) by SFHDAG5NODE2.st.com (10.75.127.14) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Mon, 25 Mar 2019 17:21:55 +0100 From: Pierre-Yves MORDRET To: Dan Williams , Vinod Koul , Maxime Coquelin , Alexandre Torgue , , , , CC: Pierre-Yves MORDRET Subject: [PATCH v2] dmaengine: stm32-mdma: Revert "Add a check on read_u32_array" Date: Mon, 25 Mar 2019 17:21:55 +0100 Message-ID: <1553530915-1961-1-git-send-email-pierre-yves.mordret@st.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.75.127.47] X-ClientProxiedBy: SFHDAG1NODE1.st.com (10.75.127.1) To SFHDAG5NODE2.st.com (10.75.127.14) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-03-25_09:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This reverts commit 906b40b246b0 ("Add a check on read_u32_array") As stated by bindings "st,ahb-addr-masks" is optional. The statement inserted by this commit makes this property mandatory and prevents MDMA to be probed in case property not present. Signed-off-by: Pierre-Yves MORDRET --- Version history: v2: * review commit message v1: * Initial --- --- drivers/dma/stm32-mdma.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/dma/stm32-mdma.c b/drivers/dma/stm32-mdma.c index 4e0eede..ac0301b 100644 --- a/drivers/dma/stm32-mdma.c +++ b/drivers/dma/stm32-mdma.c @@ -1578,11 +1578,9 @@ static int stm32_mdma_probe(struct platform_device *pdev) dmadev->nr_channels = nr_channels; dmadev->nr_requests = nr_requests; - ret = device_property_read_u32_array(&pdev->dev, "st,ahb-addr-masks", + device_property_read_u32_array(&pdev->dev, "st,ahb-addr-masks", dmadev->ahb_addr_masks, count); - if (ret) - return ret; dmadev->nr_ahb_addr_masks = count; res = platform_get_resource(pdev, IORESOURCE_MEM, 0); -- 2.7.4 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0DFDC43381 for ; Mon, 25 Mar 2019 16:22:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A122F20828 for ; Mon, 25 Mar 2019 16:22:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rhxnSbzz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A122F20828 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=st.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=7WAG8m1hsQnoANjLmqs8L1pZaFiljI1BDhFXegpRPYU=; b=rhxnSbzzWpChmK 8vdmEUGFK267I4aQfXePGwjIMfAOBxrf9G1DN9U5ULJTMDcOJrKvyg8o6hP9IlwBLapOtKa0ZS6BQ FySqnvcZ6xQVHos23yUeLQFo0m5Cu/qY9N+EFWtvfk0hQpFN2NI+i2XVARNA4t8p4Qoj/iydPp7F9 60KqLuEk+E7Ldp6la4bgLw1cWhE1VpMkQRbqy9FH++GJEXuazXfinCW11vSoekUV94up6uQAkhuue wgwBjvRb6L13eguOMUQtEdGHcXZ9Qp0LQRcehM8QqoHEV3FUKuNNsAi2AORS2CS+MSzewGRcjAduy rqE7Rbv+l2tMG/OERMTQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8SMo-0007jr-BA; Mon, 25 Mar 2019 16:22:30 +0000 Received: from mx07-00178001.pphosted.com ([62.209.51.94]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8SMg-0007dD-8Z for linux-arm-kernel@lists.infradead.org; Mon, 25 Mar 2019 16:22:28 +0000 Received: from pps.filterd (m0046668.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x2PGGANC011739; Mon, 25 Mar 2019 17:22:11 +0100 Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 2rddhbca47-1 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 25 Mar 2019 17:22:11 +0100 Received: from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id C480543; Mon, 25 Mar 2019 16:21:56 +0000 (GMT) Received: from Webmail-eu.st.com (sfhdag5node2.st.com [10.75.127.14]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id A5753EE0; Mon, 25 Mar 2019 16:21:56 +0000 (GMT) Received: from localhost (10.75.127.47) by SFHDAG5NODE2.st.com (10.75.127.14) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Mon, 25 Mar 2019 17:21:55 +0100 From: Pierre-Yves MORDRET To: Dan Williams , Vinod Koul , Maxime Coquelin , Alexandre Torgue , , , , Subject: [PATCH v2] dmaengine: stm32-mdma: Revert "Add a check on read_u32_array" Date: Mon, 25 Mar 2019 17:21:55 +0100 Message-ID: <1553530915-1961-1-git-send-email-pierre-yves.mordret@st.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-Originating-IP: [10.75.127.47] X-ClientProxiedBy: SFHDAG1NODE1.st.com (10.75.127.1) To SFHDAG5NODE2.st.com (10.75.127.14) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-03-25_09:, , signatures=0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190325_092222_978477_E0DBE1B4 X-CRM114-Status: GOOD ( 10.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Pierre-Yves MORDRET Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org This reverts commit 906b40b246b0 ("Add a check on read_u32_array") As stated by bindings "st,ahb-addr-masks" is optional. The statement inserted by this commit makes this property mandatory and prevents MDMA to be probed in case property not present. Signed-off-by: Pierre-Yves MORDRET --- Version history: v2: * review commit message v1: * Initial --- --- drivers/dma/stm32-mdma.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/dma/stm32-mdma.c b/drivers/dma/stm32-mdma.c index 4e0eede..ac0301b 100644 --- a/drivers/dma/stm32-mdma.c +++ b/drivers/dma/stm32-mdma.c @@ -1578,11 +1578,9 @@ static int stm32_mdma_probe(struct platform_device *pdev) dmadev->nr_channels = nr_channels; dmadev->nr_requests = nr_requests; - ret = device_property_read_u32_array(&pdev->dev, "st,ahb-addr-masks", + device_property_read_u32_array(&pdev->dev, "st,ahb-addr-masks", dmadev->ahb_addr_masks, count); - if (ret) - return ret; dmadev->nr_ahb_addr_masks = count; res = platform_get_resource(pdev, IORESOURCE_MEM, 0); -- 2.7.4 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel