From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BBEDC4360F for ; Tue, 2 Apr 2019 04:05:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F38C720882 for ; Tue, 2 Apr 2019 04:05:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nifty.com header.i=@nifty.com header.b="fGhsNWLk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726886AbfDBEEd (ORCPT ); Tue, 2 Apr 2019 00:04:33 -0400 Received: from conuserg-07.nifty.com ([210.131.2.74]:18494 "EHLO conuserg-07.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726511AbfDBEEc (ORCPT ); Tue, 2 Apr 2019 00:04:32 -0400 Received: from pug.e01.socionext.com (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-07.nifty.com with ESMTP id x3243HaZ021871; Tue, 2 Apr 2019 13:03:23 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-07.nifty.com x3243HaZ021871 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1554177804; bh=dTKU5woaZ+/VtCj4y62Lf6G8K4/FvWqomirsTxXN8f8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fGhsNWLkf9bQ52JgYGLYvF/50waWpHpGFxUAHW+l9uv1T2vdI6WLZmNHH/x2C1nov pVKVjHeUZOig3mam//M442LqP3WCsWla01BagPi072LzZe5/U73BeLZcAEQnQiYFJT pJQahn9G6WIiSrQ/+APrJ3/MKg4tGhZ4x9za25ul+L8bwHCdF3SvcKr/XzuDkWOXUB hOd1BDpzu3chPIh1hQeNUfzhhIQeMwUlYPzF9J0xVkMvHzV6tp5pQ65h0aZlzgnIYI WkOnGIF4QXT+ebwbGQ+GQHzmGMR2pGWMkL1rBNNdmylEBlbsRNkGkINC/4c9qYGxdh reycrB+VJVgVQ== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: linux-mtd@lists.infradead.org, Miquel Raynal Cc: Boris Brezillon , Masahiro Yamada , Brian Norris , linux-kernel@vger.kernel.org, Marek Vasut , Richard Weinberger , David Woodhouse Subject: [PATCH v5 6/9] mtd: rawnand: denali_pci: rename goto labels Date: Tue, 2 Apr 2019 13:03:06 +0900 Message-Id: <1554177789-15414-7-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1554177789-15414-1-git-send-email-yamada.masahiro@socionext.com> References: <1554177789-15414-1-git-send-email-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As Documentation/process/coding-style.rst says, choose label names which say what the goto does. The out_ label style is already used in denali_dt.c. Rename likewise for denali_pci.c Signed-off-by: Masahiro Yamada --- Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None drivers/mtd/nand/raw/denali_pci.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/nand/raw/denali_pci.c b/drivers/mtd/nand/raw/denali_pci.c index 48e9ac5..02eb599 100644 --- a/drivers/mtd/nand/raw/denali_pci.c +++ b/drivers/mtd/nand/raw/denali_pci.c @@ -84,20 +84,20 @@ static int denali_pci_probe(struct pci_dev *dev, const struct pci_device_id *id) if (!denali->host) { dev_err(&dev->dev, "Spectra: ioremap_nocache failed!"); ret = -ENOMEM; - goto failed_remap_reg; + goto out_unmap_reg; } ret = denali_init(denali); if (ret) - goto failed_remap_mem; + goto out_unmap_host; pci_set_drvdata(dev, denali); return 0; -failed_remap_mem: +out_unmap_host: iounmap(denali->host); -failed_remap_reg: +out_unmap_reg: iounmap(denali->reg); return ret; } -- 2.7.4 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5A7BC43381 for ; Tue, 2 Apr 2019 04:04:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B3ABE2070D for ; Tue, 2 Apr 2019 04:04:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JI+aMpJC"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=nifty.com header.i=@nifty.com header.b="fGhsNWLk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B3ABE2070D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=socionext.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=W8TLWvrLBsyxjczJ0E+m66g5/PlSU12vnrjz2amdpG4=; b=JI+aMpJC0OOhX0F2ySf9Md0Mxh +TxoKlnUL72/X2eAR1eoiOHp+xwKTT5HS3AJ1ykSWMT3iZzMlNBO7HZZchBGnU/gzH3EMHpXL8/Aj OrDc7ZYLrrjCNQ3XUJ4Ns2rmi3+agqetHeVRuhoIuriYEvlEm83nzN+5mFBQwcQj3l6yZff3UlC5E kMJcAlYGbIthznFFIoQSCeYx83ehcR13kYEpmSYat+kwuFS/pnVQu998Ko1cEuVYmXniMR5xOz7T2 znYnB3VDpuHp/HV2NmkkzXfAjoXpOGe2oVQWLgvtkVqgmph4yVujvmLPJ65LR8f18iqQdcoEftYtm pgR82DGg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hBAej-0000PX-VQ; Tue, 02 Apr 2019 04:04:13 +0000 Received: from conuserg-07.nifty.com ([210.131.2.74]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hBAeG-0008D0-1G for linux-mtd@lists.infradead.org; Tue, 02 Apr 2019 04:03:47 +0000 Received: from pug.e01.socionext.com (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-07.nifty.com with ESMTP id x3243HaZ021871; Tue, 2 Apr 2019 13:03:23 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-07.nifty.com x3243HaZ021871 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1554177804; bh=dTKU5woaZ+/VtCj4y62Lf6G8K4/FvWqomirsTxXN8f8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fGhsNWLkf9bQ52JgYGLYvF/50waWpHpGFxUAHW+l9uv1T2vdI6WLZmNHH/x2C1nov pVKVjHeUZOig3mam//M442LqP3WCsWla01BagPi072LzZe5/U73BeLZcAEQnQiYFJT pJQahn9G6WIiSrQ/+APrJ3/MKg4tGhZ4x9za25ul+L8bwHCdF3SvcKr/XzuDkWOXUB hOd1BDpzu3chPIh1hQeNUfzhhIQeMwUlYPzF9J0xVkMvHzV6tp5pQ65h0aZlzgnIYI WkOnGIF4QXT+ebwbGQ+GQHzmGMR2pGWMkL1rBNNdmylEBlbsRNkGkINC/4c9qYGxdh reycrB+VJVgVQ== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: linux-mtd@lists.infradead.org, Miquel Raynal Subject: [PATCH v5 6/9] mtd: rawnand: denali_pci: rename goto labels Date: Tue, 2 Apr 2019 13:03:06 +0900 Message-Id: <1554177789-15414-7-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1554177789-15414-1-git-send-email-yamada.masahiro@socionext.com> References: <1554177789-15414-1-git-send-email-yamada.masahiro@socionext.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190401_210344_382236_FACB898D X-CRM114-Status: GOOD ( 11.35 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Masahiro Yamada , Richard Weinberger , Boris Brezillon , linux-kernel@vger.kernel.org, Marek Vasut , Brian Norris , David Woodhouse MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org As Documentation/process/coding-style.rst says, choose label names which say what the goto does. The out_ label style is already used in denali_dt.c. Rename likewise for denali_pci.c Signed-off-by: Masahiro Yamada --- Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None drivers/mtd/nand/raw/denali_pci.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/nand/raw/denali_pci.c b/drivers/mtd/nand/raw/denali_pci.c index 48e9ac5..02eb599 100644 --- a/drivers/mtd/nand/raw/denali_pci.c +++ b/drivers/mtd/nand/raw/denali_pci.c @@ -84,20 +84,20 @@ static int denali_pci_probe(struct pci_dev *dev, const struct pci_device_id *id) if (!denali->host) { dev_err(&dev->dev, "Spectra: ioremap_nocache failed!"); ret = -ENOMEM; - goto failed_remap_reg; + goto out_unmap_reg; } ret = denali_init(denali); if (ret) - goto failed_remap_mem; + goto out_unmap_host; pci_set_drvdata(dev, denali); return 0; -failed_remap_mem: +out_unmap_host: iounmap(denali->host); -failed_remap_reg: +out_unmap_reg: iounmap(denali->reg); return ret; } -- 2.7.4 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/