From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5AD9C10F0B for ; Wed, 3 Apr 2019 02:10:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9FE0D2147C for ; Wed, 3 Apr 2019 02:10:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727431AbfDCCKP (ORCPT ); Tue, 2 Apr 2019 22:10:15 -0400 Received: from Mailgw01.mediatek.com ([1.203.163.78]:16124 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726845AbfDCCJ7 (ORCPT ); Tue, 2 Apr 2019 22:09:59 -0400 X-UUID: b78f3fae72fc42518ef56674a646ba25-20190403 X-UUID: b78f3fae72fc42518ef56674a646ba25-20190403 Received: from mtkcas34.mediatek.inc [(172.27.4.253)] by mailgw01.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLS) with ESMTP id 1738006627; Wed, 03 Apr 2019 10:09:48 +0800 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by MTKMBS31N1.mediatek.inc (172.27.4.69) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 3 Apr 2019 10:09:45 +0800 Received: from localhost.localdomain (10.17.3.153) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Wed, 3 Apr 2019 10:09:44 +0800 From: Chunfeng Yun To: Rob Herring , Greg Kroah-Hartman , Heikki Krogerus CC: Mark Rutland , Chunfeng Yun , Matthias Brugger , Adam Thomson , Li Jun , Badhri Jagan Sridharan , Hans de Goede , Andy Shevchenko , Min Guo , Alan Stern , , , , , Subject: [v3 PATCH 4/6] usb: roles: add API to get usb_role_switch by node Date: Wed, 3 Apr 2019 10:09:12 +0800 Message-ID: <1554257354-7440-5-git-send-email-chunfeng.yun@mediatek.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1554257354-7440-1-git-send-email-chunfeng.yun@mediatek.com> References: <1554257354-7440-1-git-send-email-chunfeng.yun@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add fwnode_usb_role_switch_get() to make easier to get usb_role_switch by fwnode which register it. It's useful when there is not device_connection registered between two drivers and only knows the fwnode which register usb_role_switch. Signed-off-by: Chunfeng Yun --- v3 changes: 1. use fwnodes instead of node suggested by Andy 2. rebuild the API suggested by Heikki v2 no changes --- drivers/usb/roles/class.c | 31 +++++++++++++++++++++++++++++++ include/linux/usb/role.h | 2 ++ 2 files changed, 33 insertions(+) diff --git a/drivers/usb/roles/class.c b/drivers/usb/roles/class.c index f45d8df5cfb8..5ecb57f8960b 100644 --- a/drivers/usb/roles/class.c +++ b/drivers/usb/roles/class.c @@ -12,6 +12,7 @@ #include #include #include +#include #include static struct class *role_class; @@ -135,6 +136,36 @@ struct usb_role_switch *usb_role_switch_get(struct device *dev) } EXPORT_SYMBOL_GPL(usb_role_switch_get); +static int __switch_match_fwnode(struct device *dev, const void *fwnode) +{ + return dev_fwnode(dev->parent) == (const struct fwnode_handle *)fwnode; +} + +/** + * fwnode_usb_role_switch_get - Find USB role switch by it's parent fwnode + * @fwnode: The fwnode that register USB role switch + * + * Finds and returns role switch registered by @fwnode. The reference count + * for the found switch is incremented. + */ +struct usb_role_switch * +fwnode_usb_role_switch_get(struct fwnode_handle *fwnode) +{ + struct usb_role_switch *sw; + struct device *dev; + + dev = class_find_device(role_class, NULL, fwnode, + __switch_match_fwnode); + if (!dev) + return ERR_PTR(-EPROBE_DEFER); + + sw = to_role_switch(dev); + WARN_ON(!try_module_get(sw->dev.parent->driver->owner)); + + return sw; +} +EXPORT_SYMBOL_GPL(fwnode_usb_role_switch_get); + /** * usb_role_switch_put - Release handle to a switch * @sw: USB Role Switch diff --git a/include/linux/usb/role.h b/include/linux/usb/role.h index c05ffa6abda9..d21cd55d9e45 100644 --- a/include/linux/usb/role.h +++ b/include/linux/usb/role.h @@ -46,6 +46,8 @@ int usb_role_switch_set_role(struct usb_role_switch *sw, enum usb_role role); enum usb_role usb_role_switch_get_role(struct usb_role_switch *sw); struct usb_role_switch *usb_role_switch_get(struct device *dev); void usb_role_switch_put(struct usb_role_switch *sw); +struct usb_role_switch * +fwnode_usb_role_switch_get(struct fwnode_handle *fwnode); struct usb_role_switch * usb_role_switch_register(struct device *parent, -- 2.20.1 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chunfeng Yun Subject: [v3 PATCH 4/6] usb: roles: add API to get usb_role_switch by node Date: Wed, 3 Apr 2019 10:09:12 +0800 Message-ID: <1554257354-7440-5-git-send-email-chunfeng.yun@mediatek.com> References: <1554257354-7440-1-git-send-email-chunfeng.yun@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <1554257354-7440-1-git-send-email-chunfeng.yun@mediatek.com> Sender: linux-kernel-owner@vger.kernel.org To: Rob Herring , Greg Kroah-Hartman , Heikki Krogerus Cc: Mark Rutland , Chunfeng Yun , Matthias Brugger , Adam Thomson , Li Jun , Badhri Jagan Sridharan , Hans de Goede , Andy Shevchenko , Min Guo , Alan Stern , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org List-Id: devicetree@vger.kernel.org Add fwnode_usb_role_switch_get() to make easier to get usb_role_switch by fwnode which register it. It's useful when there is not device_connection registered between two drivers and only knows the fwnode which register usb_role_switch. Signed-off-by: Chunfeng Yun --- v3 changes: 1. use fwnodes instead of node suggested by Andy 2. rebuild the API suggested by Heikki v2 no changes --- drivers/usb/roles/class.c | 31 +++++++++++++++++++++++++++++++ include/linux/usb/role.h | 2 ++ 2 files changed, 33 insertions(+) diff --git a/drivers/usb/roles/class.c b/drivers/usb/roles/class.c index f45d8df5cfb8..5ecb57f8960b 100644 --- a/drivers/usb/roles/class.c +++ b/drivers/usb/roles/class.c @@ -12,6 +12,7 @@ #include #include #include +#include #include static struct class *role_class; @@ -135,6 +136,36 @@ struct usb_role_switch *usb_role_switch_get(struct device *dev) } EXPORT_SYMBOL_GPL(usb_role_switch_get); +static int __switch_match_fwnode(struct device *dev, const void *fwnode) +{ + return dev_fwnode(dev->parent) == (const struct fwnode_handle *)fwnode; +} + +/** + * fwnode_usb_role_switch_get - Find USB role switch by it's parent fwnode + * @fwnode: The fwnode that register USB role switch + * + * Finds and returns role switch registered by @fwnode. The reference count + * for the found switch is incremented. + */ +struct usb_role_switch * +fwnode_usb_role_switch_get(struct fwnode_handle *fwnode) +{ + struct usb_role_switch *sw; + struct device *dev; + + dev = class_find_device(role_class, NULL, fwnode, + __switch_match_fwnode); + if (!dev) + return ERR_PTR(-EPROBE_DEFER); + + sw = to_role_switch(dev); + WARN_ON(!try_module_get(sw->dev.parent->driver->owner)); + + return sw; +} +EXPORT_SYMBOL_GPL(fwnode_usb_role_switch_get); + /** * usb_role_switch_put - Release handle to a switch * @sw: USB Role Switch diff --git a/include/linux/usb/role.h b/include/linux/usb/role.h index c05ffa6abda9..d21cd55d9e45 100644 --- a/include/linux/usb/role.h +++ b/include/linux/usb/role.h @@ -46,6 +46,8 @@ int usb_role_switch_set_role(struct usb_role_switch *sw, enum usb_role role); enum usb_role usb_role_switch_get_role(struct usb_role_switch *sw); struct usb_role_switch *usb_role_switch_get(struct device *dev); void usb_role_switch_put(struct usb_role_switch *sw); +struct usb_role_switch * +fwnode_usb_role_switch_get(struct fwnode_handle *fwnode); struct usb_role_switch * usb_role_switch_register(struct device *parent, -- 2.20.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v3,4/6] usb: roles: add API to get usb_role_switch by node From: Chunfeng Yun Message-Id: <1554257354-7440-5-git-send-email-chunfeng.yun@mediatek.com> Date: Wed, 3 Apr 2019 10:09:12 +0800 To: Rob Herring , Greg Kroah-Hartman , Heikki Krogerus Cc: Mark Rutland , Chunfeng Yun , Matthias Brugger , Adam Thomson , Li Jun , Badhri Jagan Sridharan , Hans de Goede , Andy Shevchenko , Min Guo , Alan Stern , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org List-ID: QWRkIGZ3bm9kZV91c2Jfcm9sZV9zd2l0Y2hfZ2V0KCkgdG8gbWFrZSBlYXNpZXIgdG8gZ2V0CnVz Yl9yb2xlX3N3aXRjaCBieSBmd25vZGUgd2hpY2ggcmVnaXN0ZXIgaXQuCkl0J3MgdXNlZnVsIHdo ZW4gdGhlcmUgaXMgbm90IGRldmljZV9jb25uZWN0aW9uIHJlZ2lzdGVyZWQKYmV0d2VlbiB0d28g ZHJpdmVycyBhbmQgb25seSBrbm93cyB0aGUgZndub2RlIHdoaWNoIHJlZ2lzdGVyCnVzYl9yb2xl X3N3aXRjaC4KClNpZ25lZC1vZmYtYnk6IENodW5mZW5nIFl1biA8Y2h1bmZlbmcueXVuQG1lZGlh dGVrLmNvbT4KLS0tCnYzIGNoYW5nZXM6CiAgMS4gdXNlIGZ3bm9kZXMgaW5zdGVhZCBvZiBub2Rl IHN1Z2dlc3RlZCBieSBBbmR5CiAgMi4gcmVidWlsZCB0aGUgQVBJIHN1Z2dlc3RlZCBieSBIZWlr a2kKCnYyIG5vIGNoYW5nZXMKLS0tCiBkcml2ZXJzL3VzYi9yb2xlcy9jbGFzcy5jIHwgMzEgKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKwogaW5jbHVkZS9saW51eC91c2Ivcm9sZS5oICB8 ICAyICsrCiAyIGZpbGVzIGNoYW5nZWQsIDMzIGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9k cml2ZXJzL3VzYi9yb2xlcy9jbGFzcy5jIGIvZHJpdmVycy91c2Ivcm9sZXMvY2xhc3MuYwppbmRl eCBmNDVkOGRmNWNmYjguLjVlY2I1N2Y4OTYwYiAxMDA2NDQKLS0tIGEvZHJpdmVycy91c2Ivcm9s ZXMvY2xhc3MuYworKysgYi9kcml2ZXJzL3VzYi9yb2xlcy9jbGFzcy5jCkBAIC0xMiw2ICsxMiw3 IEBACiAjaW5jbHVkZSA8bGludXgvZGV2aWNlLmg+CiAjaW5jbHVkZSA8bGludXgvbW9kdWxlLmg+ CiAjaW5jbHVkZSA8bGludXgvbXV0ZXguaD4KKyNpbmNsdWRlIDxsaW51eC9vZi5oPgogI2luY2x1 ZGUgPGxpbnV4L3NsYWIuaD4KIAogc3RhdGljIHN0cnVjdCBjbGFzcyAqcm9sZV9jbGFzczsKQEAg LTEzNSw2ICsxMzYsMzYgQEAgc3RydWN0IHVzYl9yb2xlX3N3aXRjaCAqdXNiX3JvbGVfc3dpdGNo X2dldChzdHJ1Y3QgZGV2aWNlICpkZXYpCiB9CiBFWFBPUlRfU1lNQk9MX0dQTCh1c2Jfcm9sZV9z d2l0Y2hfZ2V0KTsKIAorc3RhdGljIGludCBfX3N3aXRjaF9tYXRjaF9md25vZGUoc3RydWN0IGRl dmljZSAqZGV2LCBjb25zdCB2b2lkICpmd25vZGUpCit7CisJcmV0dXJuIGRldl9md25vZGUoZGV2 LT5wYXJlbnQpID09IChjb25zdCBzdHJ1Y3QgZndub2RlX2hhbmRsZSAqKWZ3bm9kZTsKK30KKwor LyoqCisgKiBmd25vZGVfdXNiX3JvbGVfc3dpdGNoX2dldCAtIEZpbmQgVVNCIHJvbGUgc3dpdGNo IGJ5IGl0J3MgcGFyZW50IGZ3bm9kZQorICogQGZ3bm9kZTogVGhlIGZ3bm9kZSB0aGF0IHJlZ2lz dGVyIFVTQiByb2xlIHN3aXRjaAorICoKKyAqIEZpbmRzIGFuZCByZXR1cm5zIHJvbGUgc3dpdGNo IHJlZ2lzdGVyZWQgYnkgQGZ3bm9kZS4gVGhlIHJlZmVyZW5jZSBjb3VudAorICogZm9yIHRoZSBm b3VuZCBzd2l0Y2ggaXMgaW5jcmVtZW50ZWQuCisgKi8KK3N0cnVjdCB1c2Jfcm9sZV9zd2l0Y2gg KgorZndub2RlX3VzYl9yb2xlX3N3aXRjaF9nZXQoc3RydWN0IGZ3bm9kZV9oYW5kbGUgKmZ3bm9k ZSkKK3sKKwlzdHJ1Y3QgdXNiX3JvbGVfc3dpdGNoICpzdzsKKwlzdHJ1Y3QgZGV2aWNlICpkZXY7 CisKKwlkZXYgPSBjbGFzc19maW5kX2RldmljZShyb2xlX2NsYXNzLCBOVUxMLCBmd25vZGUsCisJ CQkJX19zd2l0Y2hfbWF0Y2hfZndub2RlKTsKKwlpZiAoIWRldikKKwkJcmV0dXJuIEVSUl9QVFIo LUVQUk9CRV9ERUZFUik7CisKKwlzdyA9IHRvX3JvbGVfc3dpdGNoKGRldik7CisJV0FSTl9PTigh dHJ5X21vZHVsZV9nZXQoc3ctPmRldi5wYXJlbnQtPmRyaXZlci0+b3duZXIpKTsKKworCXJldHVy biBzdzsKK30KK0VYUE9SVF9TWU1CT0xfR1BMKGZ3bm9kZV91c2Jfcm9sZV9zd2l0Y2hfZ2V0KTsK KwogLyoqCiAgKiB1c2Jfcm9sZV9zd2l0Y2hfcHV0IC0gUmVsZWFzZSBoYW5kbGUgdG8gYSBzd2l0 Y2gKICAqIEBzdzogVVNCIFJvbGUgU3dpdGNoCmRpZmYgLS1naXQgYS9pbmNsdWRlL2xpbnV4L3Vz Yi9yb2xlLmggYi9pbmNsdWRlL2xpbnV4L3VzYi9yb2xlLmgKaW5kZXggYzA1ZmZhNmFiZGE5Li5k MjFjZDU1ZDllNDUgMTAwNjQ0Ci0tLSBhL2luY2x1ZGUvbGludXgvdXNiL3JvbGUuaAorKysgYi9p bmNsdWRlL2xpbnV4L3VzYi9yb2xlLmgKQEAgLTQ2LDYgKzQ2LDggQEAgaW50IHVzYl9yb2xlX3N3 aXRjaF9zZXRfcm9sZShzdHJ1Y3QgdXNiX3JvbGVfc3dpdGNoICpzdywgZW51bSB1c2Jfcm9sZSBy b2xlKTsKIGVudW0gdXNiX3JvbGUgdXNiX3JvbGVfc3dpdGNoX2dldF9yb2xlKHN0cnVjdCB1c2Jf cm9sZV9zd2l0Y2ggKnN3KTsKIHN0cnVjdCB1c2Jfcm9sZV9zd2l0Y2ggKnVzYl9yb2xlX3N3aXRj aF9nZXQoc3RydWN0IGRldmljZSAqZGV2KTsKIHZvaWQgdXNiX3JvbGVfc3dpdGNoX3B1dChzdHJ1 Y3QgdXNiX3JvbGVfc3dpdGNoICpzdyk7CitzdHJ1Y3QgdXNiX3JvbGVfc3dpdGNoICoKK2Z3bm9k ZV91c2Jfcm9sZV9zd2l0Y2hfZ2V0KHN0cnVjdCBmd25vZGVfaGFuZGxlICpmd25vZGUpOwogCiBz dHJ1Y3QgdXNiX3JvbGVfc3dpdGNoICoKIHVzYl9yb2xlX3N3aXRjaF9yZWdpc3RlcihzdHJ1Y3Qg ZGV2aWNlICpwYXJlbnQsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9907C4360F for ; Wed, 3 Apr 2019 02:10:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B4F33206DD for ; Wed, 3 Apr 2019 02:10:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="sBwqqxJX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B4F33206DD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=X+4Q82i9JsN8AwCI2Fh8ku1pJyE1P2Yc80YMDfy+FWo=; b=sBwqqxJXFQ3nXi g+gO3ze3ii1UJfO7qP70QFjN02UBdxEWytFSUQekOo17pdYcKiEdW5FiMxbFDEM3IuoMPkD4tmQGZ 6Pm6wrgReoi9MRMYK+bBBhteyuaouaWA4kfxEqW6uUIjrKQnNzyB+DWFiRTCXtAp0FshKBeq5O8an cayG02S+1mfKBOh6z8ljIG/KxCD/zqFfOxROm4NLKDhx54ezPWKQchCCRMzq98rHxe8/WktnDbURQ XeGoWrOzfmPAsbbo7fIxN2/SmISwTHplPZOkPDgiBx2qCsImsSdVpP5RMZ4cVx+4+mMtyM/Q58idI O4XYWxLmENcppzepX0bQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hBVMO-0004at-W2; Wed, 03 Apr 2019 02:10:41 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hBVLl-0002d2-BY; Wed, 03 Apr 2019 02:10:12 +0000 X-UUID: 2bf615806c2a4273b89675e54ee3bd28-20190402 X-UUID: 2bf615806c2a4273b89675e54ee3bd28-20190402 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1458993877; Tue, 02 Apr 2019 18:09:50 -0800 Received: from MTKMBS31N1.mediatek.inc (172.27.4.69) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 2 Apr 2019 19:09:48 -0700 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by MTKMBS31N1.mediatek.inc (172.27.4.69) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 3 Apr 2019 10:09:45 +0800 Received: from localhost.localdomain (10.17.3.153) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Wed, 3 Apr 2019 10:09:44 +0800 From: Chunfeng Yun To: Rob Herring , Greg Kroah-Hartman , Heikki Krogerus Subject: [v3 PATCH 4/6] usb: roles: add API to get usb_role_switch by node Date: Wed, 3 Apr 2019 10:09:12 +0800 Message-ID: <1554257354-7440-5-git-send-email-chunfeng.yun@mediatek.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1554257354-7440-1-git-send-email-chunfeng.yun@mediatek.com> References: <1554257354-7440-1-git-send-email-chunfeng.yun@mediatek.com> MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190402_191002_342049_D143C836 X-CRM114-Status: GOOD ( 12.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Hans de Goede , Badhri Jagan Sridharan , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Matthias Brugger , Andy Shevchenko , Alan Stern , Min Guo , Chunfeng Yun , linux-mediatek@lists.infradead.org, Adam Thomson , linux-arm-kernel@lists.infradead.org, Li Jun Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Add fwnode_usb_role_switch_get() to make easier to get usb_role_switch by fwnode which register it. It's useful when there is not device_connection registered between two drivers and only knows the fwnode which register usb_role_switch. Signed-off-by: Chunfeng Yun --- v3 changes: 1. use fwnodes instead of node suggested by Andy 2. rebuild the API suggested by Heikki v2 no changes --- drivers/usb/roles/class.c | 31 +++++++++++++++++++++++++++++++ include/linux/usb/role.h | 2 ++ 2 files changed, 33 insertions(+) diff --git a/drivers/usb/roles/class.c b/drivers/usb/roles/class.c index f45d8df5cfb8..5ecb57f8960b 100644 --- a/drivers/usb/roles/class.c +++ b/drivers/usb/roles/class.c @@ -12,6 +12,7 @@ #include #include #include +#include #include static struct class *role_class; @@ -135,6 +136,36 @@ struct usb_role_switch *usb_role_switch_get(struct device *dev) } EXPORT_SYMBOL_GPL(usb_role_switch_get); +static int __switch_match_fwnode(struct device *dev, const void *fwnode) +{ + return dev_fwnode(dev->parent) == (const struct fwnode_handle *)fwnode; +} + +/** + * fwnode_usb_role_switch_get - Find USB role switch by it's parent fwnode + * @fwnode: The fwnode that register USB role switch + * + * Finds and returns role switch registered by @fwnode. The reference count + * for the found switch is incremented. + */ +struct usb_role_switch * +fwnode_usb_role_switch_get(struct fwnode_handle *fwnode) +{ + struct usb_role_switch *sw; + struct device *dev; + + dev = class_find_device(role_class, NULL, fwnode, + __switch_match_fwnode); + if (!dev) + return ERR_PTR(-EPROBE_DEFER); + + sw = to_role_switch(dev); + WARN_ON(!try_module_get(sw->dev.parent->driver->owner)); + + return sw; +} +EXPORT_SYMBOL_GPL(fwnode_usb_role_switch_get); + /** * usb_role_switch_put - Release handle to a switch * @sw: USB Role Switch diff --git a/include/linux/usb/role.h b/include/linux/usb/role.h index c05ffa6abda9..d21cd55d9e45 100644 --- a/include/linux/usb/role.h +++ b/include/linux/usb/role.h @@ -46,6 +46,8 @@ int usb_role_switch_set_role(struct usb_role_switch *sw, enum usb_role role); enum usb_role usb_role_switch_get_role(struct usb_role_switch *sw); struct usb_role_switch *usb_role_switch_get(struct device *dev); void usb_role_switch_put(struct usb_role_switch *sw); +struct usb_role_switch * +fwnode_usb_role_switch_get(struct fwnode_handle *fwnode); struct usb_role_switch * usb_role_switch_register(struct device *parent, -- 2.20.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel