From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD85AC4360F for ; Wed, 3 Apr 2019 15:35:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9AF6D206B8 for ; Wed, 3 Apr 2019 15:35:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YRbXW7b3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726451AbfDCPfb (ORCPT ); Wed, 3 Apr 2019 11:35:31 -0400 Received: from mail-wr1-f49.google.com ([209.85.221.49]:46463 "EHLO mail-wr1-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725959AbfDCPfa (ORCPT ); Wed, 3 Apr 2019 11:35:30 -0400 Received: by mail-wr1-f49.google.com with SMTP id t17so8949419wrw.13; Wed, 03 Apr 2019 08:35:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:subject:to:cc:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=yAxJMOE1x3To24t2R0ABLokGVCW7S0c85+BdF2GgpYo=; b=YRbXW7b3UDrIcmBVWLMeeISLGT4zKE9q4xrpsuOQmKqLZLFf7g/9DVLXjzC2TdUFuE bDSc9BRZht9F5mlWVxzMTJyY5L3wpHcXWruYDSPemHx5FhUK9UJutlMChSEInEPz3MAA FtaQ/x3Du99DgFmZSrZPF6bUwDLSyJ4PFlXK0IZKTJYEuOi18RfUcW8ip7dTlNID5lh2 2iVYtfUtIEJEOyvOROxVaIHIWqUE835UyCGna8uAeCEaYl+xdxvJJ2Zyc7z2fiMxx4Up sE8YgjUlzNJeg4loX10hHGA5TOQZBHzfSN6gcqsXyClN5DqKd53O5lR+uyxkh17YxV24 z5bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:subject:to:cc:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=yAxJMOE1x3To24t2R0ABLokGVCW7S0c85+BdF2GgpYo=; b=YqRYdJqukaRT0L4DaIRto1WUSAD+6CpqrioooIrtmZmdkBae4irXFr6vc+I/icUMm0 YY6JNJA69Bh3KU9ltCz3cZUk9DKckhSjSUbi7cs+vSfmhdD1oB6zKkA2fW6DnT290e8+ ILzKPn417OL1uFRaVmlNLbTeCP8rDkHtNCKSl07zHo43OZoyBU/OwXuLF/mFSmsCWqKv kWcWYAhE/Edrx8F+zPi/Ei5CMYGfaB9fqWYvt9Lg+JrbPvtpC7LDCJmhMBBLwi6chHmd X/HlvPCxP2FnfzBUh/NPkD3ucqWlRyprh2rvvGb+K7l2aK/mSAV6Vam5T01ZEbWGXBOc X5iA== X-Gm-Message-State: APjAAAUmmkogRERJK+3HBJtoeG6gZSf59CzcjJRLX3ae92AXJwLyn0hx 18KfnqB6p568ZtPSfVPMQNE= X-Google-Smtp-Source: APXvYqz3JM5FO9pe7qTmq1bmbom6/QelC3GGtfaxVE3/aLZwPUlOp8fHV/AuXmwl/d/p3KN1QT/vPA== X-Received: by 2002:adf:e951:: with SMTP id m17mr87551wrn.287.1554305729287; Wed, 03 Apr 2019 08:35:29 -0700 (PDT) Received: from X555LD ([2a02:85f:510:b900:d5bf:dcd8:8640:a2fe]) by smtp.gmail.com with ESMTPSA id l12sm21808368wrt.31.2019.04.03.08.35.24 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 03 Apr 2019 08:35:28 -0700 (PDT) Date: Wed, 03 Apr 2019 18:35:21 +0300 From: "Leonidas P. Papadakos" Subject: RE: [PATCH 1/2] stmmac: introduce flag to dynamically disable TX offload for rockchip devices To: Jose Abreu Cc: Robin Murphy , Philipp Tomsich , Heiko =?iso-8859-1?q?St=FCbner?= , Christoph =?iso-8859-1?q?M=FCllner?= , Maxime Coquelin , Alexandre Torgue , netdev@vger.kernel.org, LKML , Linux ARM , Klaus Goger Message-Id: <1554305721.1328.0@gmail.com> In-Reply-To: <78EB27739596EE489E55E81C33FEC33A0B4254A0@de02wembxa.internal.synopsys.com> References: <20190401181840.31255-1-papadakospan@gmail.com> <9d65a22a-2288-dc53-0059-ec4a31424dd8@arm.com> <2312344.mOsv7YkeBG@diego> <9EC67532-2D43-4AAD-BFA7-8B6797067427@theobroma-systems.com> <78EB27739596EE489E55E81C33FEC33A0B421348@de02wembxa.internal.synopsys.com> <4a9839d6-3d90-4354-7b64-78d5c1126e99@arm.com> <78EB27739596EE489E55E81C33FEC33A0B423811@de02wembxa.internal.synopsys.com> <1554245296.1271.0@gmail.com> <78EB27739596EE489E55E81C33FEC33A0B4254A0@de02wembxa.internal.synopsys.com> X-Mailer: geary/3.32.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org =CE=A3=CF=84=CE=B9=CF=82 =CE=A4=CE=B5=CF=84, 3 =CE=91=CF=80=CF=81, 2019 at = 10:55 =CE=A0=CE=9C, =CE=BF/=CE=B7 Jose Abreu=20 =CE=AD=CE=B3=CF=81=CE=B1=CF=88=CE=B5: > From: Leonidas P. Papadakos > Date: Tue, Apr 02, 2019 at 23:48:16 >=20 >> I can confirm that snps,no-pbl-x8, currently set by uboot for the=20 >> fdt >> basically fixes the tx-checksumming issue. >> I get 700~800 Mbps myself but that might come down to the setup. >> You could say it affects performance slightly, as I saw in a=20 >> previous >> email. >>=20 >> Without the setting The rate consistently drops to 0. >> ethtool reports tx-checksumming is on in both cases >>=20 >> Pretty cool! >> Does that give you guys an idea on how to tackle it "officially"? >>=20 >>=20 >>=20 >=20 > Thank you all for testing ! >=20 > It's been on my todo list to cook up a patch that limits PBL=20 > according to > FIFO size but I didn't manage to have the time yet so for now it would > be better if you fix it by submitting the DT bindings changes. >=20 > Thanks, > Jose Miguel Abreu If snps,no-pbl-x8 does indeed have a performace hit, should the=20 workaround be to a) turn tx checksumming off or b) snps,no-pbl-x8 set? I'll test to see the difference = From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E72F6C4360F for ; Wed, 3 Apr 2019 15:35:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B212A206B8 for ; Wed, 3 Apr 2019 15:35:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pr4H5MRu"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YRbXW7b3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B212A206B8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:To: Subject:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LKC9Amxf69/RjPFyA090Wa+ze4NTAI6DQw6xJt9pI/s=; b=pr4H5MRuSaXFi56Oo6JhT4o9i THysjk0UWCbHbEcu9C7gNfoWET3DALw1d59L9/ymVdj8LvJdD88bDSuVedQdVYr8PsMKLX57royiO NnDkgqKTnThQS5xfVwOvvE3zUIdGiWs9mXyuVLztZ+ZtTwpMTa10EqfndHesh1S3igzItopwZSUew ypnNx4LPzn6PbHVHf1W3r4mVup+Oo2vXiRr3Hs7S0gSA5kA0D1YHAhfvBau0UornCCxOQlpavJ2g3 h9AMdb5bKi9tcHVQHylfHNj5Lk+wqKZOjuwsNvj6XonPuCerzXw7Ng1SQB2Qb7Mq+cUOv6gzoQ3QZ tTq2+3t7w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hBhvL-00053t-W4; Wed, 03 Apr 2019 15:35:36 +0000 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hBhvH-00053X-CN for linux-arm-kernel@lists.infradead.org; Wed, 03 Apr 2019 15:35:32 +0000 Received: by mail-wr1-x436.google.com with SMTP id j9so21995068wrn.6 for ; Wed, 03 Apr 2019 08:35:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:subject:to:cc:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=yAxJMOE1x3To24t2R0ABLokGVCW7S0c85+BdF2GgpYo=; b=YRbXW7b3UDrIcmBVWLMeeISLGT4zKE9q4xrpsuOQmKqLZLFf7g/9DVLXjzC2TdUFuE bDSc9BRZht9F5mlWVxzMTJyY5L3wpHcXWruYDSPemHx5FhUK9UJutlMChSEInEPz3MAA FtaQ/x3Du99DgFmZSrZPF6bUwDLSyJ4PFlXK0IZKTJYEuOi18RfUcW8ip7dTlNID5lh2 2iVYtfUtIEJEOyvOROxVaIHIWqUE835UyCGna8uAeCEaYl+xdxvJJ2Zyc7z2fiMxx4Up sE8YgjUlzNJeg4loX10hHGA5TOQZBHzfSN6gcqsXyClN5DqKd53O5lR+uyxkh17YxV24 z5bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:subject:to:cc:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=yAxJMOE1x3To24t2R0ABLokGVCW7S0c85+BdF2GgpYo=; b=WzPJ4Etb3gdrFw/vZshaXaoD6JhGxkGW2flLHj9WGieMP1/1pbotn38F8o00y3SRS7 sIftRxdX/MDFytlwb+ABCPrkQMOttOaspyMukMPwn8319fwX1ZsCONBNv/tdW2qHA5lp Z1Gb8YD7hrUv86dkbTSJ6vOPdrmWB4vWkmHCOcitcDv5/tUjQfUKfXxSOwjCj2H+nHoZ iraMS6eDPEh1CV+0wz/Dc3Diay0cFflaMXcXlW0B8gYMiduCJg2K2hNYcF37ClWws8R9 L45KOigdBP5lsCl1jNERR4siPsAIUocQERjV8YgTygwvIxnZZ3MWUwwUS7xhiak7Ysjy QFGQ== X-Gm-Message-State: APjAAAVcRYrb4bQ26p2rfEBhMMaYUOHpHLyWEm5u+5TB7eJLXkCry1v+ o+TvKS7tMO0CnMqzUm6fbJ8= X-Google-Smtp-Source: APXvYqz3JM5FO9pe7qTmq1bmbom6/QelC3GGtfaxVE3/aLZwPUlOp8fHV/AuXmwl/d/p3KN1QT/vPA== X-Received: by 2002:adf:e951:: with SMTP id m17mr87551wrn.287.1554305729287; Wed, 03 Apr 2019 08:35:29 -0700 (PDT) Received: from X555LD ([2a02:85f:510:b900:d5bf:dcd8:8640:a2fe]) by smtp.gmail.com with ESMTPSA id l12sm21808368wrt.31.2019.04.03.08.35.24 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 03 Apr 2019 08:35:28 -0700 (PDT) Date: Wed, 03 Apr 2019 18:35:21 +0300 From: "Leonidas P. Papadakos" Subject: RE: [PATCH 1/2] stmmac: introduce flag to dynamically disable TX offload for rockchip devices To: Jose Abreu Message-Id: <1554305721.1328.0@gmail.com> In-Reply-To: <78EB27739596EE489E55E81C33FEC33A0B4254A0@de02wembxa.internal.synopsys.com> References: <20190401181840.31255-1-papadakospan@gmail.com> <9d65a22a-2288-dc53-0059-ec4a31424dd8@arm.com> <2312344.mOsv7YkeBG@diego> <9EC67532-2D43-4AAD-BFA7-8B6797067427@theobroma-systems.com> <78EB27739596EE489E55E81C33FEC33A0B421348@de02wembxa.internal.synopsys.com> <4a9839d6-3d90-4354-7b64-78d5c1126e99@arm.com> <78EB27739596EE489E55E81C33FEC33A0B423811@de02wembxa.internal.synopsys.com> <1554245296.1271.0@gmail.com> <78EB27739596EE489E55E81C33FEC33A0B4254A0@de02wembxa.internal.synopsys.com> X-Mailer: geary/3.32.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190403_083531_448703_4415171A X-CRM114-Status: GOOD ( 12.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Torgue , netdev@vger.kernel.org, LKML , Christoph =?iso-8859-1?q?M=FCllner?= , Klaus Goger , Maxime Coquelin , Philipp Tomsich , Robin Murphy , Linux ARM , Heiko =?iso-8859-1?q?St=FCbner?= Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org CgrOo8+EzrnPgiDOpM61z4QsIDMgzpHPgM+BLCAyMDE5IGF0IDEwOjU1IM6gzpwsIM6/L863IEpv c2UgQWJyZXUgCjxqb3NlLmFicmV1QHN5bm9wc3lzLmNvbT4gzq3Os8+BzrHPiM61Ogo+IEZyb206 IExlb25pZGFzIFAuIFBhcGFkYWtvcyA8cGFwYWRha29zcGFuQGdtYWlsLmNvbT4KPiBEYXRlOiBU dWUsIEFwciAwMiwgMjAxOSBhdCAyMzo0ODoxNgo+IAo+PiAgSSBjYW4gY29uZmlybSB0aGF0IHNu cHMsbm8tcGJsLXg4LCBjdXJyZW50bHkgc2V0IGJ5IHVib290IGZvciB0aGUgCj4+IGZkdAo+PiAg YmFzaWNhbGx5IGZpeGVzIHRoZSB0eC1jaGVja3N1bW1pbmcgaXNzdWUuCj4+ICBJIGdldCA3MDB+ ODAwIE1icHMgbXlzZWxmIGJ1dCB0aGF0IG1pZ2h0IGNvbWUgZG93biB0byB0aGUgc2V0dXAuCj4+ ICBZb3UgY291bGQgc2F5IGl0IGFmZmVjdHMgcGVyZm9ybWFuY2Ugc2xpZ2h0bHksIGFzIEkgc2F3 IGluIGEgCj4+IHByZXZpb3VzCj4+ICBlbWFpbC4KPj4gCj4+ICBXaXRob3V0IHRoZSBzZXR0aW5n IFRoZSByYXRlIGNvbnNpc3RlbnRseSBkcm9wcyB0byAwLgo+PiAgZXRodG9vbCByZXBvcnRzIHR4 LWNoZWNrc3VtbWluZyBpcyBvbiBpbiBib3RoIGNhc2VzCj4+IAo+PiAgUHJldHR5IGNvb2whCj4+ ICBEb2VzIHRoYXQgZ2l2ZSB5b3UgZ3V5cyBhbiBpZGVhIG9uIGhvdyB0byB0YWNrbGUgaXQgIm9m ZmljaWFsbHkiPwo+PiAKPj4gCj4+IAo+IAo+IFRoYW5rIHlvdSBhbGwgZm9yIHRlc3RpbmcgIQo+ IAo+IEl0J3MgYmVlbiBvbiBteSB0b2RvIGxpc3QgdG8gY29vayB1cCBhIHBhdGNoIHRoYXQgbGlt aXRzIFBCTCAKPiBhY2NvcmRpbmcgdG8KPiBGSUZPIHNpemUgYnV0IEkgZGlkbid0IG1hbmFnZSB0 byBoYXZlIHRoZSB0aW1lIHlldCBzbyBmb3Igbm93IGl0IHdvdWxkCj4gYmUgYmV0dGVyIGlmIHlv dSBmaXggaXQgYnkgc3VibWl0dGluZyB0aGUgRFQgYmluZGluZ3MgY2hhbmdlcy4KPiAKPiBUaGFu a3MsCj4gSm9zZSBNaWd1ZWwgQWJyZXUKCklmIHNucHMsbm8tcGJsLXg4IGRvZXMgaW5kZWVkIGhh dmUgYSBwZXJmb3JtYWNlIGhpdCwgc2hvdWxkIHRoZSAKd29ya2Fyb3VuZCBiZSB0bwphKSB0dXJu IHR4IGNoZWNrc3VtbWluZyBvZmYgb3IKYikgc25wcyxuby1wYmwteDggc2V0PwoKSSdsbCB0ZXN0 IHRvIHNlZSB0aGUgZGlmZmVyZW5jZQoKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0t a2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFp bG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==