From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915/gvt: Prevent use-after-free in ppgtt_free_all_spt() Date: Thu, 04 Apr 2019 09:11:55 +0100 Message-ID: <155436551568.7532.6039435513500149424@skylake-alporthouse-com> References: <20190404073056.12407-1-chris@chris-wilson.co.uk> <20190404074834.GS2322@zhen-hp.sh.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190404074834.GS2322@zhen-hp.sh.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Zhenyu Wang Cc: intel-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org UXVvdGluZyBaaGVueXUgV2FuZyAoMjAxOS0wNC0wNCAwODo0ODozNCkKPiBPbiAyMDE5LjA0LjA0 IDA4OjMwOjU2ICswMTAwLCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4gPiBwcGd0dF9mcmVlX2FsbF9z cHQoKSBpdGVyYXRlcyB0aGUgcmFkaXh0cmVlIGFzIGl0IGlzIGRlbGV0aW5nIGl0LAo+ID4gZm9y Z29pbmcgYWxsIHByb3RlY3Rpb24gYWdhaW5zdCB0aGUgbGVhdmVzIGJlaW5nIGZyZWVkIGluIHRo ZSBwcm9jZXNzCj4gPiAobGVhdmluZyB0aGUgaXRlciBwb2ludGluZyBpbnRvIHRoZSB2b2lkKS4K PiA+IAo+ID4gQSBtaW5pbWFsIGZpeCBzZWVtcyB0byBiZSB0byB1c2UgdGhlIGF2YWlsYWJsZSBw b3N0X3NoYWRvd19saXN0IHRvCj4gPiBkZWNvbXBvc2UgdGhlIHRyZWUgaW50byBhIGxpc3QgcHJp b3IgdG8gZGVzdHJveWluZyB0aGUgcmFkaXh0cmVlLgo+ID4gCj4gPiBBbGVydGVkIGJ5IHRoZSBz cGFyc2Ugd2FybmluZ3M6Cj4gPiAKPiA+IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2d2dC9ndHQuYzo3 NTc6OTogd2FybmluZzogaW5jb3JyZWN0IHR5cGUgaW4gYXNzaWdubWVudCAoZGlmZmVyZW50IGFk ZHJlc3Mgc3BhY2VzKQo+ID4gZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3Z0L2d0dC5jOjc1Nzo5OiAg ICBleHBlY3RlZCB2b2lkICoqc2xvdAo+ID4gZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3Z0L2d0dC5j Ojc1Nzo5OiAgICBnb3Qgdm9pZCBbbm9kZXJlZl0gPGFzbjo0PiAqKgo+ID4gZHJpdmVycy9ncHUv ZHJtL2k5MTUvZ3Z0L2d0dC5jOjc1Nzo5OiB3YXJuaW5nOiBpbmNvcnJlY3QgdHlwZSBpbiBhc3Np Z25tZW50IChkaWZmZXJlbnQgYWRkcmVzcyBzcGFjZXMpCj4gPiBkcml2ZXJzL2dwdS9kcm0vaTkx NS9ndnQvZ3R0LmM6NzU3Ojk6ICAgIGV4cGVjdGVkIHZvaWQgKipzbG90Cj4gPiBkcml2ZXJzL2dw dS9kcm0vaTkxNS9ndnQvZ3R0LmM6NzU3Ojk6ICAgIGdvdCB2b2lkIFtub2RlcmVmXSA8YXNuOjQ+ ICoqCj4gPiBkcml2ZXJzL2dwdS9kcm0vaTkxNS9ndnQvZ3R0LmM6NzU4OjQ1OiB3YXJuaW5nOiBp bmNvcnJlY3QgdHlwZSBpbiBhcmd1bWVudCAxIChkaWZmZXJlbnQgYWRkcmVzcyBzcGFjZXMpCj4g PiBkcml2ZXJzL2dwdS9kcm0vaTkxNS9ndnQvZ3R0LmM6NzU4OjQ1OiAgICBleHBlY3RlZCB2b2lk IFtub2RlcmVmXSA8YXNuOjQ+ICoqc2xvdAo+ID4gZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3Z0L2d0 dC5jOjc1ODo0NTogICAgZ290IHZvaWQgKipzbG90Cj4gPiBkcml2ZXJzL2dwdS9kcm0vaTkxNS9n dnQvZ3R0LmM6NzU3Ojk6IHdhcm5pbmc6IGluY29ycmVjdCB0eXBlIGluIGFyZ3VtZW50IDEgKGRp ZmZlcmVudCBhZGRyZXNzIHNwYWNlcykKPiA+IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2d2dC9ndHQu Yzo3NTc6OTogICAgZXhwZWN0ZWQgdm9pZCBbbm9kZXJlZl0gPGFzbjo0PiAqKnNsb3QKPiA+IGRy aXZlcnMvZ3B1L2RybS9pOTE1L2d2dC9ndHQuYzo3NTc6OTogICAgZ290IHZvaWQgKipzbG90Cj4g PiBkcml2ZXJzL2dwdS9kcm0vaTkxNS9ndnQvZ3R0LmM6NzU3Ojk6IHdhcm5pbmc6IGluY29ycmVj dCB0eXBlIGluIGFzc2lnbm1lbnQgKGRpZmZlcmVudCBhZGRyZXNzIHNwYWNlcykKPiA+IGRyaXZl cnMvZ3B1L2RybS9pOTE1L2d2dC9ndHQuYzo3NTc6OTogICAgZXhwZWN0ZWQgdm9pZCAqKnNsb3QK PiA+IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2d2dC9ndHQuYzo3NTc6OTogICAgZ290IHZvaWQgW25v ZGVyZWZdIDxhc246ND4gKioKPiA+IAo+ID4gVGhpcyB3b3VsZCBhbHNvIGhhdmUgYmVlbiBsb3Vk bHkgd2FybmluZyBpZiBydW4gdGhyb3VnaCBDSSBmb3IgdGhlCj4gPiBpbnZhbGlkIFJDVSBkZXJl ZmVyZW5jZXMuCj4gPiAKPiA+IEZpeGVzOiBiNmMxMjZhMzkzNDUgKCJkcm0vaTkxNS9ndnQ6IE1h bmFnZSBzaGFkb3cgcGFnZXMgd2l0aCByYWRpeCB0cmVlIikKPiA+IFNpZ25lZC1vZmYtYnk6IENo cmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+ID4gQ2M6IENoYW5nYmluIER1 IDxjaGFuZ2Jpbi5kdUBpbnRlbC5jb20+Cj4gPiBDYzogWmhlbnl1IFdhbmcgPHpoZW55dXdAbGlu dXguaW50ZWwuY29tPgo+ID4gQ2M6IFpoaSBXYW5nIDx6aGkuYS53YW5nQGludGVsLmNvbT4KPiA+ IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2d2dC9ndHQuYyB8IDEyICsrKysrKysrKy0t LQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCA5IGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCj4g PiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9ndnQvZ3R0LmMgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9ndnQvZ3R0LmMKPiA+IGluZGV4IGNmMTMzZWYwMzg3My4uOTgxNDc3 Mzg4MmVjIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3Z0L2d0dC5jCj4g PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9ndnQvZ3R0LmMKPiA+IEBAIC03NTAsMTQgKzc1 MCwyMCBAQCBzdGF0aWMgdm9pZCBwcGd0dF9mcmVlX3NwdChzdHJ1Y3QgaW50ZWxfdmdwdV9wcGd0 dF9zcHQgKnNwdCkKPiA+ICAKPiA+ICBzdGF0aWMgdm9pZCBwcGd0dF9mcmVlX2FsbF9zcHQoc3Ry dWN0IGludGVsX3ZncHUgKnZncHUpCj4gPiAgewo+ID4gLSAgICAgc3RydWN0IGludGVsX3ZncHVf cHBndHRfc3B0ICpzcHQ7Cj4gPiArICAgICBzdHJ1Y3QgaW50ZWxfdmdwdV9wcGd0dF9zcHQgKnNw dCwgKnNwbjsKPiA+ICAgICAgIHN0cnVjdCByYWRpeF90cmVlX2l0ZXIgaXRlcjsKPiA+IC0gICAg IHZvaWQgKipzbG90Owo+ID4gKyAgICAgTElTVF9IRUFEKGFsbF9zcHQpOwo+ID4gKyAgICAgdm9p ZCBfX3JjdSAqKnNsb3Q7Cj4gPiAgCj4gPiArICAgICByY3VfcmVhZF9sb2NrKCk7Cj4gPiAgICAg ICByYWRpeF90cmVlX2Zvcl9lYWNoX3Nsb3Qoc2xvdCwgJnZncHUtPmd0dC5zcHRfdHJlZSwgJml0 ZXIsIDApIHsKPiA+ICAgICAgICAgICAgICAgc3B0ID0gcmFkaXhfdHJlZV9kZXJlZl9zbG90KHNs b3QpOwo+ID4gLSAgICAgICAgICAgICBwcGd0dF9mcmVlX3NwdChzcHQpOwo+ID4gKyAgICAgICAg ICAgICBsaXN0X21vdmUoJnNwdC0+cG9zdF9zaGFkb3dfbGlzdCwgJmFsbF9zcHQpOwo+ID4gICAg ICAgfQo+ID4gKyAgICAgcmN1X3JlYWRfdW5sb2NrKCk7Cj4gPiArCj4gPiArICAgICBsaXN0X2Zv cl9lYWNoX2VudHJ5X3NhZmUoc3B0LCBzcG4sICZhbGxfc3B0LCBwb3N0X3NoYWRvd19saXN0KQo+ ID4gKyAgICAgICAgICAgICBwcGd0dF9mcmVlX3NwdChzcHQpOwo+ID4gIH0KPiA+Cj4gCj4gQXMg d2UgZW5zdXJlIHRvIGZsdXNoIHBvc3Qgc2hhZG93IGxpc3QsIHNvIHRoaXMgaXMgc2FmZSB0byBy ZXVzZS4KClBoZXchIEkgbG9va2VkLCBjb3VsZG4ndCBzZWUgdGhhdCBpdCB3b3VsZCBiZSB1c2Vk IGF0IHRoaXMgcG9pbnQsIHNvCmhvcGVkIGZvciB0aGUgYmVzdC4KIAo+IFJldmlld2VkLWJ5OiBa aGVueXUgV2FuZyA8emhlbnl1d0BsaW51eC5pbnRlbC5jb20+CgpXaWxsIHlvdSB0YWtlIGJvdGgg b2YgdGhlc2UgcGF0Y2hlcyB0aHJvdWdoIHlvdXIgdHJlZT8KLUNocmlzCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QK SW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA==