From: Chris Wilson <chris@chris-wilson.co.uk>
To: Imre Deak <imre.deak@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915: Get power refs in encoder->get_power_domain()
Date: Sun, 07 Apr 2019 13:41:34 +0100 [thread overview]
Message-ID: <155464089466.17806.15026579571750409855@skylake-alporthouse-com> (raw)
In-Reply-To: <20190407120632.GB17917@ideak-desk.fi.intel.com>
Quoting Imre Deak (2019-04-07 13:06:32)
> On Sun, Apr 07, 2019 at 02:55:14PM +0300, Imre Deak wrote:
> > > get_power_domains() and atomic needs to take responsibility for the
> > > overlapping set of powerwells imo.
> >
> > ->get_power_domains() is essentially the powerref acquisition part of the
> > encoder->get_hw_state(). We have a separate hook for it since the latter
> > one is also called during verification, where we don't want to take the
> > long time refs (they must have been acquired already by the modeset we
> > are verifying).
>
> Note the similar logic for crtc powerrefs in
> intel_modeset_setup_hw_state()/modeset_get_crtc_power_domains().
Hmm. That's what I thought this was. I probably was confusing the paths.
Also while you are here, care to look over
https://patchwork.freedesktop.org/patch/296632/?series=59089&rev=2
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-04-07 12:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-05 15:36 [PATCH 1/2] drm/i915: Get power refs in encoder->get_power_domain() Imre Deak
2019-04-05 15:36 ` [PATCH 2/2] drm/i915/icl: Simplify release of encoder power refs Imre Deak
2019-04-05 17:37 ` ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Get power refs in encoder->get_power_domain() Patchwork
2019-04-06 15:53 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-04-07 10:48 ` Imre Deak
2019-04-06 16:05 ` [PATCH 1/2] " Chris Wilson
2019-04-07 10:25 ` Imre Deak
2019-04-07 11:41 ` Chris Wilson
2019-04-07 11:55 ` Imre Deak
2019-04-07 12:06 ` Imre Deak
2019-04-07 12:41 ` Chris Wilson [this message]
2019-04-07 12:46 ` [PATCH v2 1/2] drm/i915: Get power refs in encoder->get_power_domains() Imre Deak
2019-04-07 13:04 ` Chris Wilson
2019-04-07 13:32 ` ✓ Fi.CI.BAT: success for series starting with [v2,1/2] drm/i915: Get power refs in encoder->get_power_domains() (rev2) Patchwork
2019-04-07 14:40 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-04-08 15:40 ` Imre Deak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=155464089466.17806.15026579571750409855@skylake-alporthouse-com \
--to=chris@chris-wilson.co.uk \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.