From: Chris Wilson <chris@chris-wilson.co.uk>
To: Fernando Pacheco <fernando.pacheco@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/4] drm/i915/uc: Reserve upper range of GGTT
Date: Tue, 09 Apr 2019 22:43:12 +0100 [thread overview]
Message-ID: <155484618794.692.13397754469220081385@skylake-alporthouse-com> (raw)
In-Reply-To: <155484610085.692.15865772189882521087@skylake-alporthouse-com>
Quoting Chris Wilson (2019-04-09 22:41:40)
> Quoting Fernando Pacheco (2019-04-09 22:31:00)
> > @@ -3370,7 +3388,8 @@ int i915_ggtt_probe_hw(struct drm_i915_private *dev_priv)
> > * restriction!
> > */
> > if (USES_GUC(dev_priv)) {
> > - ggtt->vm.total = min_t(u64, ggtt->vm.total, GUC_GGTT_TOP);
> > + ggtt->vm.total = min_t(u64, ggtt->vm.total,
> > + GUC_GGTT_RESERVED_END);
>
> Should not be required now as you should have completely reserved the range
> for the guc, by the guc.
You can even then remove the comment, as we won't even try and put non
guc data here; guc or no guc is decided at module load.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-04-09 21:43 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-09 21:30 [PATCH 0/4] Perma-pin uC firmware and re-enable global reset Fernando Pacheco
2019-04-09 21:30 ` [PATCH 1/4] drm/i915/uc: Rename uC firmware init function Fernando Pacheco
2019-04-09 22:08 ` Chris Wilson
2019-04-09 21:31 ` [PATCH 2/4] drm/i915/uc: Reserve upper range of GGTT Fernando Pacheco
2019-04-09 21:41 ` Chris Wilson
2019-04-09 21:43 ` Chris Wilson [this message]
2019-04-09 22:40 ` Fernando Pacheco
2019-04-15 22:32 ` Fernando Pacheco
2019-04-16 7:21 ` Chris Wilson
2019-04-09 22:12 ` Daniele Ceraolo Spurio
2019-04-09 21:31 ` [PATCH 3/4] drm/i915/uc: Place uC firmware in " Fernando Pacheco
2019-04-09 21:53 ` Chris Wilson
2019-04-09 22:53 ` Fernando Pacheco
2019-04-09 23:04 ` Chris Wilson
2019-04-09 22:11 ` Chris Wilson
2019-04-09 23:18 ` Fernando Pacheco
2019-04-09 22:22 ` Chris Wilson
2019-04-16 14:51 ` Fernando Pacheco
2019-04-16 15:04 ` Chris Wilson
2019-04-16 15:21 ` Fernando Pacheco
2019-04-09 21:31 ` [PATCH 4/4] Revert "drm/i915/guc: Disable global reset" Fernando Pacheco
2019-04-09 21:54 ` Chris Wilson
2019-04-16 14:45 ` Fernando Pacheco
2019-04-16 15:05 ` Chris Wilson
2019-04-16 15:10 ` Fernando Pacheco
2019-04-09 22:31 ` ✗ Fi.CI.SPARSE: warning for Perma-pin uC firmware and re-enable global reset Patchwork
2019-04-09 22:56 ` ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=155484618794.692.13397754469220081385@skylake-alporthouse-com \
--to=chris@chris-wilson.co.uk \
--cc=fernando.pacheco@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.